From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F1773043D2 for ; Thu, 29 Jan 2026 14:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769695876; cv=none; b=SXzp/hybSdtV1nt1R8NjnQWh5gDGuWysAhTLOlNN6xPog2Wmc4+zPLHnM6EGnP5LNBF8lUaHIdK7puraU/HGXCuLGbUbBjR620+tXj5DZhkYAhdY0QxG9neVxloy5ShEGb2/LD60pA8mnbhnRrZtjZdxyBMvS4rOc87SF7k9f8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769695876; c=relaxed/simple; bh=/ykZcMAp0/hmfjN0oTjkHY/FPv9xSJ4Emd0fhE26KZ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oPdNa3fqNxqrVlE8ZwEO7yxMEU9m1o87cGdoDTVHdXN5fkewF9PcIwzKZsiZc/pyn6i6Bv2J2hT/rNqPuXEZlV5UVwLUevOTukUPgpIm2ivNDQ20JUhDUaAoc7iJCGidHWUqK96VfW5KvVKQEDEf+w8RYlz3NEa/otMHjXX24C4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=giXHduJy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZlF0vvLh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="giXHduJy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZlF0vvLh" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TA2pu93143877 for ; Thu, 29 Jan 2026 14:11:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lTy+/DrDMVLHO5FL74CxfRsfY3lzw1a+emT5zffUjhQ=; b=giXHduJy8iNLsGoI QuqGBUTZM8Z8/BWcQDJZLZ1V9rRf+Iixo2xNfatmsYQXLZHwUjIkUG5K2ALcrEeR xzimVcEvIM3rZKh2xWWKQgNRf4/9tQbHV1fK8HTW3cPAKZUDqCtvpoekeMg076Yp E7MJvdVclncFm6JOhn7lwtAzgLv6ZXOx2lFzQzS2za8Yr4ME/aXUuZRh9UsevU32 eT6Tbf9exdMJrY3DiR22tb/3dUMmRMGn68R3xPJccN/q6+aGIsGLO3M9BqbakEPb lgsvTFbBvVk3+Fomx1KojfWN39mm6Jio0d4GhYvLJ8RzKJxyMOcPrRbwdQVWzecH ADAmeA== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4byqpxk8hq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 14:11:14 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-9414fc8eb29so247337241.3 for ; Thu, 29 Jan 2026 06:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769695873; x=1770300673; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lTy+/DrDMVLHO5FL74CxfRsfY3lzw1a+emT5zffUjhQ=; b=ZlF0vvLhYvPbzJsjnjwUCv/eBmhu3jv5qhkf/SHciRgwzkthdye7A50LUohaI5L8VM RkTEbddIJSfCTUBJGTAFK+hb3+2jnmlH7sDLoz3cDRFaFT1Ek3S9lWSl79/A740O7XFi mqdc1cvspfCMqLEDJS+8Z564OnvSqrrFDMo/WVsVc14sV6mUzR9W+glcMF3ZZ7+YjlBa a8lQ004rgJKXR3lyieN7j7qITRIu3ouRB3WZXMAPlTjJC01OKS97bguwntx5pA05/ChO CDAuXRusEJ53e/GsNaaqOW5UYHxpqOqeRwHFpuj1+l+gf7pMXrcb8LZfuRhIwsZie0XT Bwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769695873; x=1770300673; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lTy+/DrDMVLHO5FL74CxfRsfY3lzw1a+emT5zffUjhQ=; b=fiYVOQk57WamQpdbKh2MfkckiAkDxwzMqXR5eluYSnx2WlRh7cvUXKTXvm3mzcJs5W nyZszPNPKWG71sjxKU7qzoiy4cRwbHNVQTT1yY0DLbtKxFAeQop6D7deWUnEKSagz7Tg ZUSqb7ePF19p7l3qkH2VDkacSwxuqOrE1KwxgbGyiKEzLQo/FtGDnl1TpSSQ5tJn43XG xhlR+K7Lo/hDTOjtj48DwYxqnBFNm7EdsfCYYW8ocEK/PqkskHELIhg75Cfwx3HVcekw nWC0tqrs7s6mwWZ2F4wVilhUtzwVEMUWDRMQQtCVZwJ/nz+/TTUOzkcRyMF4ft7W20Aa LP7g== X-Forwarded-Encrypted: i=1; AJvYcCWMNhSiUtDZ6S6GTzS1On6RZn8WpXycEUQ36GyyMI+t8b/mm+NbKW6eIMkclX2cg/3q+6aIPurzuPPW40A=@vger.kernel.org X-Gm-Message-State: AOJu0Yzv/B6oi2Mo9wBnq+d1wLX2svIZm31RSXehxuEf7Z/J/UzOcC0R 9IsdhYsLFgOPY7OvrL2UnN4jyTKPvPha5307SFKjMg+GZZKAhgrxU0j8UcOcTOCpgIdhEDagG96 +4LzCqULcak1/IDQn+/C4JfrMWaIVfVBqvQTSCZA0L0FBUQ6ylHxPXJOsQ4Hti+aktUE= X-Gm-Gg: AZuq6aLPt14oDYiw3bFN+UHf4Cg94GR5J4MOFw8IC+8Ls8ahdYbp5mtIx4VLtFMORoG Nqtzw4+2uTyEoS8Ycnv6mQSq3F3dc/dEAohntZii2NxoT9XbU8V3g9DBIe35rh2Ka9chBDq+Ggi EKN70v3eAmdKP/kaf8LicZuoYaRaBx5nUtBV0MEa5V+H+7+4+IRfJcwB1fYOS2zZ1eS8OWJSi0i e1P8TcyiEo28sbiEVjn2nXdSeUyid1uAPYlVJSdoaErcDz6R9XfX4eFJ1wkXjRle+FgBlaZyFEo w3soVS2inT5d3zuX7U5wvC+qFURfP0Zw13pEI2xOmZsGwDjABg2toXqeY/jZvq2KrIT+s3Rg4kW 9QGEHj+w4MTYBsuKGj7c0O07kIS8DTogCx9VxA7xnN2pPQS4CofB9S8/AcZgTQ5niH+0= X-Received: by 2002:a05:6122:365a:b0:559:9663:bfb1 with SMTP id 71dfb90a1353d-56689f43943mr723154e0c.0.1769695873119; Thu, 29 Jan 2026 06:11:13 -0800 (PST) X-Received: by 2002:a05:6122:365a:b0:559:9663:bfb1 with SMTP id 71dfb90a1353d-56689f43943mr723080e0c.0.1769695870332; Thu, 29 Jan 2026 06:11:10 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf1c02d0sm262175766b.55.2026.01.29.06.11.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 06:11:09 -0800 (PST) Message-ID: <9234e45d-4a48-4820-a42b-48e11d79c0ee@oss.qualcomm.com> Date: Thu, 29 Jan 2026 15:11:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: document the Eliza Top Level Mode Multiplexer To: Abel Vesa Cc: Krzysztof Kozlowski , Bjorn Andersson , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127-eliza-pinctrl-v2-0-1faf78efdc2e@oss.qualcomm.com> <20260127-eliza-pinctrl-v2-1-1faf78efdc2e@oss.qualcomm.com> <20260128-hot-camel-of-acumen-eef9f2@quoll> <8360708d-5d82-4cbe-bf0c-31107ab07bac@oss.qualcomm.com> <6244680d-f6c3-4aba-8e12-61093e51f76c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: -zA6jEt-dii0j89dpG4tKYW1JoyM6vVW X-Proofpoint-ORIG-GUID: -zA6jEt-dii0j89dpG4tKYW1JoyM6vVW X-Authority-Analysis: v=2.4 cv=dfSNHHXe c=1 sm=1 tr=0 ts=697b6a82 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=9alSFpSfKzYJ5GvhcA0A:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA5NiBTYWx0ZWRfX9CYJDE28M/m5 G81Cp13ccnWHf98cHz4/st0XPxev9syWIbIMAeX2mJy0Txr32/TCnsfdrApgdsJ2fHRGhRfKm7D n3zoyTIQNylFMxVFQL7V1k+7h95MZeS1P1dNQomo7vf5u0NExSlrgoUlA1mC2bSGEPDeJCHyqww FhSmr2O2QxxWqlOcMW7gPcor1yMnjb/Ej8HTOPpGBDAw6UBXPh8Hzffd2YnvoDRuupAUKE95DzN rqlc6vUAEZHwwFcv349qIzdacmIG+LPTkX1V8I/Tt/32oGkO3h3/fWTri2l96q0dTfv5jMw94fP HWCPppY6Y/N4GaT5yvTTaMlEmjmCySIEzsQBWyaUmKO5NuAGrDW2Dvf3Roe5Is8erpEb3uJrT1Q 1r3yxt4GmCZ++l6uQU3yhoU9G8XRpH+fOgdGEQp89xcNhAIfYIc8/Yxy3ggqrp+kWNliREBG3bj OX8m+Lo0v2rR4fkpVWQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290096 On 1/29/26 1:42 PM, Abel Vesa wrote: > On 26-01-29 13:04:23, Konrad Dybcio wrote: >> On 1/29/26 12:12 PM, Abel Vesa wrote: >>> On 26-01-29 11:45:59, Konrad Dybcio wrote: >>>> On 1/29/26 11:41 AM, Abel Vesa wrote: >>>>> On 26-01-29 11:34:07, Konrad Dybcio wrote: >>>>>> On 1/28/26 6:22 PM, Abel Vesa wrote: >>>>>>> On 26-01-28 12:38:32, Krzysztof Kozlowski wrote: >>>>>>>> On Tue, Jan 27, 2026 at 05:47:36PM +0200, Abel Vesa wrote: >>>>>>>>> Document the Top Level Mode Multiplexer on the Eliza Platform. >>>>>>>>> >>>>>>>>> Signed-off-by: Abel Vesa >>>>>>>>> --- >>>>>> >>>>>> [...] >>>>>> >>>>>>>>> + >>>>>>>>> + gpio-line-names: >>>>>>>>> + maxItems: 185 >>>>>>>> >>>>>>>> 186, your first GPIO is 0 and last is 185. >>>>>>> >>>>>>> Actually it is 0 through 184. The 185 is ufs reset. >>>>>> >>>>>> The UFS reset also happens to be a GPIO.. >>>>> >>>>> So the gpio-line-names should include the ufs reset, >>>>> but the pattern not. >>>> >>>> Why not? >>> >>> ufs reset cannot be configured as gpio, so why would it be part of the >>> pattern? >> >> It's certainly registered as a GPIO, as all users of UFSHC refer to it > > Well, technically yes, SW-wise. But it definitely doesn't have the same > configuration fields in HW. Anyway, that is not the point here. > > The point is the pattern has dedicated enum for ufs_reset and gpio185 is > not even part of the gpio groups anyway. [1] So, is the current behavior such that in case I wanted to set some properties on the ufs pin, the description would be: foo-state { pins = "ufs_reset"; }; ? TBF we don't have any such ones, possibly because whatever the bootloader had configured has always seemed to work well enough.. In that case, I agree that this pattern should not include the pin. I'm however a little surprised to see that would be the case, since we end up consuming this pin as a numbered GPIO via reset-gpios. > Also, are you saying that all older platforms (sm8[3-7]50, at least) are effectively > wrong since they do exactly the thing I described ? :-) > >> >>> For the same reason, it cannot be part of the gpio-line-names either. >> >> Since it's registered as a GPIO, why not? > > If what I'm saying above is true, you can't configure gpio185, so AFAICT you > won't be able to name it either. Or am I wrong ? I think the truth is more nuanced: The UFS_RESET is a GPIO in the sense of pinctrl-msm, as it has a ctl_reg and an io_reg. It's not capable of receiving interrupts and it seems to be output-only. It does not have a "gpio" pinmux function (func0 is named "ufs_reset" intead), but that's just human-facing naming, so whatever. It can be toggled and is consumed by its number, through the gpios/xxx-pins property. Running cat /sys/kernel/debug/gpios on x1e80100, where ngpios and gpio-ranges includes that pin though, I could not see it listed. I don't really know why. That's where I'd expect to see the name given by gpio-line-names. Now, I would also strongly expect that this pin would be only ever used for UFS reset, making the name override unnecessary but we've all seen things.. Konrad