From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753688AbdCMVlH (ORCPT ); Mon, 13 Mar 2017 17:41:07 -0400 Received: from zed.grinta.net ([109.74.203.128]:54654 "EHLO zed.grinta.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753071AbdCMVk6 (ORCPT ); Mon, 13 Mar 2017 17:40:58 -0400 X-Greylist: delayed 544 seconds by postgrey-1.27 at vger.kernel.org; Mon, 13 Mar 2017 17:40:57 EDT Subject: Re: [PATCH v2 1/2] staging: speakup: Added blank line after function/struct/union/enum declarations To: Arushi Singhal , w.d.hubbs@gmail.com References: <20170313204018.24601-1-arushisinghal19971997@gmail.com> <20170313204018.24601-2-arushisinghal19971997@gmail.com> Cc: chris@the-brannons.com, outreachy-kernel@googlegroups.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Daniele Nicolodi Message-ID: <9240fe49-0bb3-c439-188a-5a0b6ca24f02@grinta.net> Date: Mon, 13 Mar 2017 15:31:45 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170313204018.24601-2-arushisinghal19971997@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 3/13/17 2:40 PM, Arushi Singhal wrote: > This patch fixes the warnings reported by checkpatch.pl > for please use a blank line after function/struct/union/enum > declarations. I haven't seen this pointed out by others before: starting a commit message with "This patch..." is redundant (it is a commit message, thus what it describes is surely a patch) and most times leads to bad style commit messages. In this case the commit message can simply be: Add a blank line after enum and struct declarations. or Ensure that enum and struct declarations are followed by a blank line. Cheers, Daniele > > Signed-off-by: Arushi Singhal > --- > changes in v2 > - change the subject to make it more relevant. > > drivers/staging/speakup/main.c | 1 + > drivers/staging/speakup/serialio.c | 1 + > drivers/staging/speakup/speakup_dtlk.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c > index 6786cfab7460..4b750ec8cd59 100644 > --- a/drivers/staging/speakup/main.c > +++ b/drivers/staging/speakup/main.c > @@ -108,6 +108,7 @@ enum { > CT_Window, > CT_Max > }; > + > #define read_all_mode CT_Max > > static struct tty_struct *tty; > diff --git a/drivers/staging/speakup/serialio.c b/drivers/staging/speakup/serialio.c > index aade52ee15a0..d51e382cb835 100644 > --- a/drivers/staging/speakup/serialio.c > +++ b/drivers/staging/speakup/serialio.c > @@ -21,6 +21,7 @@ static void start_serial_interrupt(int irq); > static const struct old_serial_port rs_table[] = { > SERIAL_PORT_DFNS > }; > + > static const struct old_serial_port *serstate; > static int timeouts; > > diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c > index eede2d82183a..c0b2208aa8a7 100644 > --- a/drivers/staging/speakup/speakup_dtlk.c > +++ b/drivers/staging/speakup/speakup_dtlk.c > @@ -43,6 +43,7 @@ static int port_forced; > static unsigned int synth_portlist[] = { > 0x25e, 0x29e, 0x2de, 0x31e, 0x35e, 0x39e, 0 > }; > + > static u_char synth_status; > > static struct var_t vars[] = { >