From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7265B2F0C74 for ; Fri, 13 Mar 2026 12:17:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773404258; cv=none; b=HBIFXj/gqaOvZIsbD5eoW2paa1zaIJZAbp5Wl5+OdLsVM+XF1HFuXQFIRYH8+XQNtMwQs2vbBXK4t8wjWfZxOwSsQhib1rDAJcXAuo35zCE/u4d12NIjkwmKfqZ1PC5k4Dr1bvkDWcZywRRph6tXb0BSI6gh3E7JDwjsgYJbV2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773404258; c=relaxed/simple; bh=dH/LRUSNBatrGwHvEX3Iy06egEiIiZiFcoxmr7F53lw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IU9FdC1dZC90skuQnU3CUX9RdqsUnwIP0jSRHrm3OKsuhcBzteTiPZqYb71jxki1rVGjQ1eUgTUYzgNlz3NQAqL5fKit5kv0ssQRZ3c9QsEpve5M5OaqMniD84s2bwLptjvBWUPi5iO1REIcO11JXMsJcP5M2NI7FsdD4NdrpLc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=S2zuPGlI; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="S2zuPGlI" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b943a880577so289236966b.3 for ; Fri, 13 Mar 2026 05:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773404256; x=1774009056; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3s5B4wCXYFxF46H+9RZgBJPAFEqIaUF6//FgPVVAHcY=; b=S2zuPGlIvMArgiJbiTh839YX2dUIZitVPKFFfae4E4KrnUwsEU5zfTDpwC7/yPuxne 46IoNzj5dgBt//MxZK9J5PVdo97x0hOe90mChE0M1AXFizXkWrPyzt0tQWFUnWdFNnJW 2twpsABjZgr2XSOC2ytpD4qsYfhhiZnqXehNVc4QteLvDl2UiC71FbcHrpCGGIiYQbIe YUNjD+leYjMZYO709jzCqiIxC7jDcuIlLG3XaMvCjRAD07ikJ7lHwOJJ6lkzmoiWkG9t s4pE9n+q0NQztZiDV14T5oMHac52F2clHH/12FfXusd/ECoD63K2IuInIVl4/SZuXqEF OZFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773404256; x=1774009056; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3s5B4wCXYFxF46H+9RZgBJPAFEqIaUF6//FgPVVAHcY=; b=TsdUrb5jdZcQ7Ym4+VDh+1OzNEKV8sXpeozBFYYW+5h8BabSkLJd+d8p9WK6g4yBSa kT7kmZX4xg7UtU/GsdR4Yxf7My8tfqJxWVMvSweVpEfSgLXSH3AdwnmlPq+I9aYv9Mo4 v+XtySAI983jlDb5cRvXhkUhI1oJWuWdNKstVtnZGToIO/mcOrhP5QD3ks/PmuAHSXsk OSeQo76N/KR6YRPy/MJi6W4apXjBMyUx6GFJe7an+qE6DvrwUrFcfiTvwKb7ucGuN5AL 2atDy/iF1/X9Nvg4ob7k5ifvV8d1bqVWrjU/dj5+lCfbTdgeSfI7D16TM/M+V6WtYbYb nxlw== X-Forwarded-Encrypted: i=1; AJvYcCU9DLHHLrjku+OuozVurd1/fYBA0p0Qt9rlWiIKVCOVU1kbrQ13jMGbt3w31FFiekDM0+iH8zEIZOqybDo=@vger.kernel.org X-Gm-Message-State: AOJu0YzsdNvyXMTU/AHouJBvvY3qvQw9APrx61isDm/hkeOmdbBUZ6JM ZCO15doUgBCl4MDAM+D11s7hBNM2JmfjIZNdysk3BntmSq+3nP2tV7xpLUbqCMbUhlE= X-Gm-Gg: ATEYQzytFPOymQItuUDJX1UBDs+mO74/q1F5sV1/Va2xKS+WJtZTrUKOQxOA6mN2Pwl SBZG97te+0oxyVanLEvOOJrOszACFCxgSyTy3YFzRl/O067zsyYOqf3/bRIIUQljYIYQM686x59 VzMeN1zIBAlTeI2IGNQzqpkUF13+qb+r8DiXaCCAjqp6nA8KZuvFD5K3XeDpl12O20RvxTCj0HW IAV93dOdPQXgF5yrPv8ySAvtS3itkb5nj1WoteDnQe7HJ3JC2QX04HgXJKA9c6JH4t4yXYSFpgQ QWjeBx9b1vHADL3thf/CEn8LZv8sObB4o+BjI0E1fp4Eudisj3AUXDAUTjSVJDWL6WqxjBzxaKW hADFgpiCKFRsTZmoVOE79BLUmbpnVEANGQlnMbOmuH76Jicp9bLtiRSRkPX7hZlLjV8pt1lIPv+ +x3WdV2t1t3jNeolBQjsuvw3reMp70uKXYXw4= X-Received: by 2002:a17:907:174a:b0:b96:7e03:166c with SMTP id a640c23a62f3a-b97651b4282mr160852266b.53.1773404255612; Fri, 13 Mar 2026 05:17:35 -0700 (PDT) Received: from [192.168.0.35] ([109.76.176.163]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97756e59c4sm23182566b.35.2026.03.13.05.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 05:17:35 -0700 (PDT) Message-ID: <9241da21-6b02-434d-a746-6bccc25a335d@linaro.org> Date: Fri, 13 Mar 2026 12:17:38 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices To: Anvesh Jain P , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/03/2026 10:29, Anvesh Jain P wrote: > + * Read Response: > + * ---------------------------------------------------------------------- > + * | Offset | Name | Description | > + * ---------------------------------------------------------------------- > + * | 0x00 | Byte count | Number of bytes in response | > + * | | | (exluding byte count) | Great to see this documented in the code. Please run checkpatch and take heed of what it says. 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch has no obvious style problems and is ready for submission. 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:184: exluding ==> excluding, exuding 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:224: exluding ==> excluding, exuding total: 0 errors, 0 warnings, 0 checks, 28 lines checked --- bod