Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

[Timothy Pearson <tpearson@raptorengineering.com>]

----- Original Message -----
> From: "robh" <robh@kernel.org>
> To: "Timothy Pearson" <tpearson@raptorengineering.com>
> Cc: "devicetree" <devicetree@vger.kernel.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "Conor Dooley"
> <conor+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Lee Jones" <lee@kernel.org>, "Georgy
> Yakovlev" <Georgy.Yakovlev@sony.com>, "Shawn Anastasio" <sanastasio@raptorengineering.com>
> Sent: Monday, September 29, 2025 9:11:13 AM
> Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld

> On Thu, Sep 25, 2025 at 01:17:33PM -0500, Timothy Pearson wrote:
>> The Sony Cronos Platform Controller CPLD is a multi-purpose platform
>> controller that provides both a watchdog timer and an LED controller for
>> the Sony Interactive Entertainment Cronos x86 server platform. As both
>> functions are provided by the same CPLD, a multi-function device is
>> exposed as the parent of both functions.
>> 
>> Add a DT binding for this device.
>> 
>> Signed-off-by: Shawn Anastasio <sanastasio@raptorengineering.com>
>> Signed-off-by: Timothy Pearson <tpearson@raptorengineering.com>
>> ---
>>  .../bindings/mfd/sony,cronos-cpld.yaml        | 121 ++++++++++++++++++
>>  1 file changed, 121 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> 
>> diff --git a/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> new file mode 100644
>> index 000000000000..3cebf6c0153d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/sony,cronos-cpld.yaml
>> @@ -0,0 +1,121 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +# Copyright 2025 Raptor Engineering, LLC
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mfd/sony,cronos-cpld.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Sony Cronos Platform Controller CPLD multi-function device
>> +
>> +maintainers:
>> +  - Georgy Yakovlev <Georgy.Yakovlev@sony.com>
>> +
>> +description: |
> 
> Don't need '|' if no formatting or paragraphs to preserve.
> 
>> +  The Sony Cronos Platform Controller CPLD is a multi-purpose platform
>> +  controller that provides both a watchdog timer and an LED controller for the
>> +  Sony Interactive Entertainment Cronos x86 server platform. As both functions
>> +  are provided by the same CPLD, a multi-function device is exposed as the
>> +  parent of both functions.
>> +
>> +properties:
>> +  compatible:
>> +    const: sony,cronos-cpld
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  leds:
>> +    type: object
>> +    additionalProperties: false
>> +    description: |
>> +      The Cronos LED controller is a subfunction of the Cronos platform
>> +      controller, which is a multi-function device.
>> +
>> +      Each led is represented as a child node of sony,cronos-led. Fifteen RGB
>> +      LEDs are supported by the platform.
>> +
>> +    properties:
>> +      compatible:
>> +        const: sony,cronos-led
>> +
>> +      reg:
>> +        maxItems: 1
>> +
>> +      "#address-cells":
>> +        const: 1
>> +
>> +      "#size-cells":
>> +        const: 0
>> +
>> +    patternProperties:
>> +      "^multi-led@[0-15]$":
>> +        type: object
>> +        $ref: leds-class-multicolor.yaml#
>> +        unevaluatedProperties: false
>> +
>> +        properties:
>> +          reg:
>> +            description:
>> +              LED channel number (0..15)
>> +            minimum: 0
>> +            maximum: 15
>> +
>> +        required:
>> +          - reg
>> +
>> +    required:
>> +      - compatible
>> +      - "#address-cells"
>> +      - "#size-cells"
>> +
>> +  watchdog:
>> +    type: object
>> +    description: Cronos Platform Watchdog Timer
>> +
>> +    allOf:
>> +      - $ref: watchdog.yaml#
>> +
>> +    properties:
>> +      compatible:
>> +        const: sony,cronos-watchdog
> 
> There's no need for a child node here. 'timeout-sec' can just go in the
> parent node.

Could you elaborate on this please?  As far as I can tell we ref watchdog.yaml and need some kind of compatible string, so why would I break out timeout-sec directly here?

Thanks!