mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Qasim Ijaz <qasdev00@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	syzbot+3361c2d6f78a3e0892f9@syzkaller.appspotmail.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] net: fix uninitialised access in mii_nway_restart()
Date: Fri, 7 Mar 2025 18:56:20 +0100	[thread overview]
Message-ID: <9242fedf-3450-4d6e-b08d-846956f2cb9d@lunn.ch> (raw)
In-Reply-To: <Z8sywbV8B3Nm3BKR@qasdev.system>

> Hi Andrew,
> 
> Just following up on my patch regarding the uninitialized access fix in mii_nway_restart(). 
> As I mentioned in my previous message, how about an approach similar to the patch for ch9200_mdio_read() 
> for get_mac_address() where we immediately check the return value of each control_read() call and return 
> an error if any call fails? This way we don't continue if failure occurs. If you're good with this approach, 
> should I submit a patch v2?

Yes, this would be good.

Thanks
	Andrew

  reply	other threads:[~2025-03-07 17:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 12:19 Qasim Ijaz
2025-02-26 13:43 ` Andrew Lunn
2025-03-07 17:55   ` Qasim Ijaz
2025-03-07 17:56     ` Andrew Lunn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-27 23:15 Qasim Ijaz
2025-02-26 11:27 Qasim Ijaz
2025-02-18  0:24 Qasim Ijaz
2025-02-18  1:10 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9242fedf-3450-4d6e-b08d-846956f2cb9d@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=qasdev00@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+3361c2d6f78a3e0892f9@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®