From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Vimal Agrawal <avimalin@gmail.com>,
<linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<arnd@arndb.de>
Cc: <vimal.agrawal@sophos.com>
Subject: Re: [PATCH v2] misc: misc_minor_alloc to use ida for all dynamic/misc dynamic minors
Date: Tue, 15 Oct 2024 15:18:11 -0700 [thread overview]
Message-ID: <92435cd4-c0e1-4d05-8ecf-52dd9249adf4@quicinc.com> (raw)
In-Reply-To: <20241015070226.15790-1-vimal.agrawal@sophos.com>
On 10/15/24 00:02, Vimal Agrawal wrote:
...
> +static struct kunit_suite test_suite = {
> + .name = "misc_minor_test",
> + .test_cases = test_cases,
> +};
> +kunit_test_suite(test_suite);
> +
> +MODULE_LICENSE("GPL");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple
developers have been eradicating these warnings treewide, and very few
(if any) are left, so please don't introduce a new one :)
Please add the missing MODULE_DESCRIPTION()
/jeff
next prev parent reply other threads:[~2024-10-15 22:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 13:14 [PATCH] misc: misc_minor_alloc to allocate ids " Vimal Agrawal
2024-10-14 13:19 ` Greg KH
2024-10-15 7:02 ` [PATCH v2] misc: misc_minor_alloc to use ida " Vimal Agrawal
2024-10-15 7:52 ` Greg KH
2024-10-15 7:53 ` Greg KH
2024-10-15 7:57 ` Vimal Agrawal
2024-10-15 22:18 ` Jeff Johnson [this message]
2024-10-17 11:12 ` Vimal Agrawal
2024-10-17 11:43 ` [PATCH v1 2/2] misc:minor basic kunit tests Vimal Agrawal
2024-10-17 11:43 ` [PATCH v3 1/2] misc: misc_minor_alloc to use ida for all dynamic/misc dynamic minors Vimal Agrawal
2024-10-17 11:55 ` [PATCH v1 2/2] misc:minor basic kunit tests Greg KH
2024-10-17 11:56 ` Greg KH
2024-10-17 13:35 ` [PATCH v4 1/2] misc: misc_minor_alloc to use ida for all dynamic/misc dynamic minors Vimal Agrawal
2024-10-17 13:39 ` Greg KH
2024-10-17 14:06 ` Greg KH
2024-10-17 14:13 ` [PATCH v4 2/2] misc:minor basic kunit tests Vimal Agrawal
2024-10-21 13:38 ` [PATCH v5 1/2] misc: misc_minor_alloc to use ida for all dynamic/misc dynamic minors avimalin
2024-10-21 13:39 ` [PATCH v5 2/2] misc:minor basic kunit tests avimalin
2024-10-16 14:22 ` [PATCH] misc: misc_minor_alloc to allocate ids for all dynamic/misc dynamic minors Dan Carpenter
2024-10-17 11:08 ` Vimal Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92435cd4-c0e1-4d05-8ecf-52dd9249adf4@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=arnd@arndb.de \
--cc=avimalin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vimal.agrawal@sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®