From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754960AbeASJyE (ORCPT ); Fri, 19 Jan 2018 04:54:04 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:36583 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbeASJx5 (ORCPT ); Fri, 19 Jan 2018 04:53:57 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180119095354euoutp02acea68858f18d7064036f8fbef4cf202~LLWp270d00195701957euoutp02R X-AuditID: cbfec7f4-f790c6d0000075d3-cb-5a61c031eb2e Subject: Re: [PATCH 5/5] crypto: ahash.c: Require export/import in ahash To: Marek Vasut , linux-crypto@vger.kernel.org Cc: "David S. Miller" , Bartlomiej Zolnierkiewicz , Sonic Zhang , Fabio Estevam , Shawn Guo , Tom Lendacky , Jan Engelhardt , Arvind Yadav , Linus Walleij , Joakim Bech , linux-kernel@vger.kernel.org, Herbert Xu From: Kamil Konieczny Message-id: <9246bbcb-6cd0-8bc9-8286-02c44e6d01bc@partner.samsung.com> Date: Fri, 19 Jan 2018 10:53:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-version: 1.0 In-reply-to: <5db6f843-cc51-09f2-f388-8dade440c6bc@denx.de> Content-type: text/plain; charset="utf-8" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHee597nbVJrc182C+1MAiqcyQfMyMBIkLfelLoPtQ3eqmkk7b UrIQbb6i5cxJxYiw8i2pTF1mJmlWrhdRy7LEtwqdKWnWJJLM2nYN/PY75/8/nPN/eFhaOcz4 sAnak6JOKySqZe64qXO+e3NIu6DZ+r15E+k/f40m9ZfrGHKlJwcTc+FmUjTlSwyT0xSx145j UrZQTZHRkXmK9LVckZGveWcRGb9TQZOhe9ky8rTsEbPbk89980fGT72L4i03Byj+qvk55hef GCn+gXlYzje1B/L1tgnMD/W3yvhiSy3i7Q3++zw07juPiokJaaIueNch9/iFtlqcYlKeams2 4CzU7VmI3FjgQqGnc1Ym8WroHalzsDur5CoR2GqMjFTYEfSYevH/iayWfsbJSq4KQWf1Mclk Q/BzwOISVnE8vGmtoZys4iLBYGnGThPNzdAwVvnCJci4MPh8v8vFCm4PGMsHXMOYC4TRKpvc yV5cDBTaWhjJsxJ+mUZcV7hxEfBsstF1N81thC9zpVhib8jOHVjiAGi8NU07FwPXIIfHgx8Z KUI02HPmlngVTFktcol9oc9UhKUBI4LqDy/lUlGGwHrxHSW5IuCJ9TUjrfCE0qZLjhWso6+A gjylZOGhqfL6kj0K3tqL5dIb5VDQ/v47LkEB5mWJzMtSmJelMC9LUY5wLVKJqfqkOFEfukUv JOlTtXFbjiQnNSDHp3u1aJ1rRjc6d3QgjkXqFYq7Nw5plIyQpk9P6kDA0mqVYmavo6U4KqSf FnXJB3WpiaK+A61hsdpbEanJi1VyccJJ8bgopoi6/yrFuvlkofzfU4+8665tEKOGT/v7ld8t 8fhxeP37eNW22+V18UUmaj9ZtIX3Be3XZobxhu6RxIzhkpiwWxVnu4Ktgc9S/+arCZJ7+G0v 1AqCQTdYETMxo4yeNc58SziwjgvkH/qfKyvw0o0l45voE1l74qmq6AzKaG0LijVesMtVmZpw NdbHCyFBtE4v/AMBIdugcAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t/xa7qGBxKjDC7tEbS41ruQ2WLjjPWs FnPOt7BYzOrSteh+JWPR9PItk8XnVU9ZLKb8Wc5kcf/eTyaLy7vmsFm8aWtktHi6bgmzxZ2t zWwWR6bsY3Xg82i99JfN49VVR48tK28yecybdYLF49/hfiaPnbPusntsO6DqsfHZcxaPO9f2 sHn0bVnF6PF5k1wAdxSXTUpqTmZZapG+XQJXxp/9q1gKJgtV7N/RxNLAeI6vi5GTQ0LARKJh 1zVWCFtM4sK99WxdjFwcQgJLGCUO7NvMAuE8Y5R43H2XEaRKWMBD4tKeFUwgtoiArUTTlh1g RcwCn5gl3v+cyw7R0cIkMXvrU7AONgFziUfbz4B18Aq4SfQvuAm2j0VAVeL+smfsILaoQIRE 08y5rBA1ghI/Jt9jAbE5Bawljr7cDHQTB9AGdYkpU3JBwswC4hLNrTdZIGx5ic1r3jJPYBSc haR7FkLHLCQds5B0LGBkWcUoklpanJueW2ykV5yYW1yal66XnJ+7iREYj9uO/dyyg7HrXfAh RgEORiUe3g2LE6KEWBPLiitzDzFKcDArifC+8wYK8aYkVlalFuXHF5XmpBYfYpTmYFES5+3d szpSSCA9sSQ1OzW1ILUIJsvEwSnVwMi34drNkI1vWQ3F2upyD9m4H+lpqGGXvMTgWfzqw1z9 332sO248/yE98fM5kx/hEkXb1b6JNUwOrD+du/zH7gWF2/52lz9l33Wq1VTuZWl8biRf12Ne dZ9Usderpsnuv9ordaHmVfwkNif/La33nqlsbja4dF7m4OVpX95v4C+XSL5bFCLhbqjEUpyR aKjFXFScCACjlO+3wwIAAA== X-CMS-MailID: 20180119095353eucas1p24539e2a51580d8eb979e53f538508143 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180118183441eucas1p2ee3f046a594945299ea7b75ffb13e2ca X-RootMTR: 20180118183441eucas1p2ee3f046a594945299ea7b75ffb13e2ca References: <20180118183404.12583-1-k.konieczny@partner.samsung.com> <20180118183404.12583-6-k.konieczny@partner.samsung.com> <5db6f843-cc51-09f2-f388-8dade440c6bc@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.01.2018 22:31, Marek Vasut wrote: > On 01/18/2018 07:34 PM, Kamil Konieczny wrote: >> Export and import are mandatory in async hash. As drivers were >> rewritten, drop empty wrappers and correct init of ahash transformation. > > Are you moving checks from the core subsystem to drivers ? This looks > really nonsensical and the commit message doesn't explain the rationale > for that at all. I am removing checks from core. Export and import were optional in beginnig of crypto framework, but as time goes on they become mandatory. > >> Signed-off-by: Kamil Konieczny >> --- >> crypto/ahash.c | 18 ++---------------- >> 1 file changed, 2 insertions(+), 16 deletions(-) >> >> diff --git a/crypto/ahash.c b/crypto/ahash.c >> index 3a35d67de7d9..c3cce508c1d4 100644 >> --- a/crypto/ahash.c >> +++ b/crypto/ahash.c >> @@ -434,16 +434,6 @@ static int ahash_def_finup(struct ahash_request *req) >> return ahash_def_finup_finish1(req, err); >> } >> >> -static int ahash_no_export(struct ahash_request *req, void *out) >> -{ >> - return -ENOSYS; >> -} >> - >> -static int ahash_no_import(struct ahash_request *req, const void *in) >> -{ >> - return -ENOSYS; >> -} >> - >> static int crypto_ahash_init_tfm(struct crypto_tfm *tfm) >> { >> struct crypto_ahash *hash = __crypto_ahash_cast(tfm); >> @@ -451,8 +441,6 @@ static int crypto_ahash_init_tfm(struct crypto_tfm *tfm) >> >> hash->setkey = ahash_nosetkey; >> hash->has_setkey = false; >> - hash->export = ahash_no_export; >> - hash->import = ahash_no_import; >> >> if (tfm->__crt_alg->cra_type != &crypto_ahash_type) >> return crypto_init_shash_ops_async(tfm); >> @@ -462,15 +450,13 @@ static int crypto_ahash_init_tfm(struct crypto_tfm *tfm) >> hash->final = alg->final; >> hash->finup = alg->finup ?: ahash_def_finup; >> hash->digest = alg->digest; >> + hash->export = alg->export; >> + hash->import = alg->import; >> >> if (alg->setkey) { >> hash->setkey = alg->setkey; >> hash->has_setkey = true; >> } >> - if (alg->export) >> - hash->export = alg->export; >> - if (alg->import) >> - hash->import = alg->import; >> >> return 0; >> } >> > > -- Best regards, Kamil Konieczny Samsung R&D Institute Poland