From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12A1335202B for ; Tue, 19 May 2026 11:35:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779190539; cv=none; b=OJh3UTSiAdJdwGxNYVMjB7SHo6bu62upQJBlrWm7I9L0aPTEvG/p61C8dXc6kV4OZ8xghYAKgJxApKu0kF7pmJFTFYS+VpmSLZDSvZeezpUqyRCzNdIbum6GksexTdWD3SWpYT3/F1Io2JOH7AzV3CwYb+Gcg/86u6cSh/2nRTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779190539; c=relaxed/simple; bh=IJvmC4+MDzgDR3x1/mmW1jiZo0QKanZz2BpoZIZ7PFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cN5uzX2AILeo6RPR+k3uNjrSlafeJ2+MHu5xJxeUVTk1JPOHY371J+ViJQHdIwJMNxVwstxyHJar1hfWkvZv6hBJ4Xz6YW4YgHN7a8hXKMDU1J3U8SpC1oybGpl6ArHg/cGX4dQs32P2O4p8Q2FsHejbkCHuOyzBl3DjyV+UUHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YCHnO/kL; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YCHnO/kL" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5aa0da74eaaso4297674e87.1 for ; Tue, 19 May 2026 04:35:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779190535; x=1779795335; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VqQsxr0ZnYs3BWly02d5Mve2EarybI6uUYgpZNOCriw=; b=YCHnO/kLqqvl8T1wsIuBeskIsrPM+9yMORyhSlcdgUvXzvj9+EzpFQWpd6jk3RejOR wV6ozCH9Dp3cCBivqZai9l6nL7j08V2pGVXg7tN0reB4PNyWSi9SFGFcD3AjSkvihdW6 biuD2O0pT2zE4js8+2fE95cZoMANuFvtAWi7A468VmDMmOhwi+0yiW/gNqzubdRxK4vU mlLVkTnUKdU8XYpaxvS8SiVZH8r/EcocEGnuyoTan/NEszqm6/3bys0p55UvQM/t+9BC Y3i/dncsISPY1The3dlzONtCYZjh+k0o1C7b5osriOtuwMLdkIKhIfhAkmlJgMfTe3nv XcxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779190535; x=1779795335; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VqQsxr0ZnYs3BWly02d5Mve2EarybI6uUYgpZNOCriw=; b=cHGXm5YfUuHBEDEuvb7XfmQN7c4/rFkpALK9oC3hHlNRsWYcl9xHWGRjugbII62wGJ RjGCANiCxLaAKZ2xZwhKNqKJBZXC1+QtNLKitGIs3aiBlWvmxrHw7vyehaJsci88oXIA OkroUVjc8hDIn/NHgj0AKKEPMYL1uOE6hp4fPErOX6OdfamfBHeyZhucFGuzGezi3oOX LhrZxHWH+UfQJtyLks7jRuOZhgJTiLCrdpUfhh7QvL4ZRMXaXKL661t1Bj0pv2ssymvb Eu5PU7p7MLBQns0m0KCCMBk7D0gN3r6dfZJGjC6pcADwkqhz+OE1SzWxyU7E9dDsid0Q phAA== X-Forwarded-Encrypted: i=1; AFNElJ/7bKzNuRY41kuySfpog3tezpnkV4JuPPvRgWji5bv3DeqSRF4pvkRpM7zni5xT/LgA4cnjFYnWiNMgyGY=@vger.kernel.org X-Gm-Message-State: AOJu0YyIN39moL7oN/8B7fD/xFZ96YYOt8rKi8QnNcGDXnNd6MPJGLoE fZmwKQAJchCrBVQt+Q/ve6TaybQFZLTp252NvJb89ULdDEuFyfvIotkQ X-Gm-Gg: Acq92OGo7sXIy/kmiBhSdgRqwxhcIqtkl+9Y5yeEb42GOiXLxqEqMXL0LJQXENQ0MSf 61M4E400T69amIill0nMAv8TE2kluRefERN8UEqOqaHTjn17K0REro4nab224xpE8A0FBsdscUg 4g/ndzVS0sG46Uolk4YgXJK5UiuxCK+VMSF/aN32hNhqwOwd/NJe14sCAAwas40AsWoBvKVSfZO vlCjftx7BM+aSmqf6jB4HjrXAd4CDQSs9GT5j+1+VVWrpi2o8sL5u62DfP17pFYVbKxIjz4aZHy JZWID8gtESFN8Z16z1H96jLIpVpEkBXyiU1mECt3RGxaykpO4V6S71tZKpjfl4ejsNUfTBhSbD3 MCsmTq8PlAW2BmwU2mzp4ZQ6O0i9eWDu1BiScLQRaPJm9rEYU8lA34GYL97aUM0GlJslVyYOxIs Nl6IE7baOfD7LXBKuX4hlMqnmJ36+a8Wyx X-Received: by 2002:a05:6512:1044:b0:5a8:837a:2a98 with SMTP id 2adb3069b0e04-5a8ffc6705bmr7032449e87.14.1779190534830; Tue, 19 May 2026 04:35:34 -0700 (PDT) Received: from [10.38.18.54] ([213.255.186.37]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a9164cce46sm4083047e87.68.2026.05.19.04.35.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 04:35:34 -0700 (PDT) Message-ID: <924e453a-e991-4689-8f22-667b71f152f5@gmail.com> Date: Tue, 19 May 2026 14:35:31 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] iio: Initialize i2c_device_id arrays using member names To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Puranjay Mohan , Cosmin Tanislav , Marcelo Schmitt , Antoniu Miclaus , Ramona Gradinariu , Petre Rodan , Dan Robertson , Herve Codina , Francesco Dolcini , =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Hugo Villeneuve , Anshul Dalal , Gustavo Silva , Andreas Klinger , Tomasz Duszynski , Ariana Lazar , Rui Miguel Silva , Linus Walleij , Javier Carrasco , Li peiyu <579lpy@gmail.com>, Lorenzo Bianconi , Alex Lanzano , Jagath Jog J , Jean-Baptiste Maneyrol , Remi Buisson , Christian Eggers , Mudit Sharma , Kevin Tsai , =?UTF-8?Q?Ond=C5=99ej_Jirman?= , Dixit Parmar , Gerald Loacker , Akhilesh Patil , Eddie James , Petar Stoykov , Song Qiang , Siratul Islam , Crt Mori , Waqar Hameed , Sebastian Andrzej Siewior , Gustavo Vaz , Sakari Ailus , Marcus Folkesson , Guenter Roeck , Bartosz Golaszewski , Chuang Zhu , Kyle Hsieh , Giorgi Tchankvetadze , Chen-Yu Tsai , Oleksij Rempel , Romain Gantois , Sander Vanheule , David Jander , Andrew Davis , chuguangqing , Shrikant Raskar , Kurt Borja , Denis Benato , Ethan Tidmore , Tomas Borquez , Srinivas Pandruvada , Shi Hao , Xichao Zhao , Erikas Bitovtas , Aldo Conte , Colin Ian King , Gabriel Almeida , Gabriela Victor , Beatriz Viana Costa , Frank Li , Adrian Fluturel , Antoni Pokusinski , Yasin Lee , Felix Gu , Ben Collins , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <4b6ea3483356d758a90bfb8970ed0f1df2f31cfc.1779136001.git.u.kleine-koenig@baylibre.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <4b6ea3483356d758a90bfb8970ed0f1df2f31cfc.1779136001.git.u.kleine-koenig@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19/05/2026 11:13, Uwe Kleine-König (The Capable Hub) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > The mentioned robustness is relevant for a planned change to struct > i2c_device_id that replaces .driver_data by an anonymous union. > > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) I took a look at the ROHM/Kionix stuff. All of it looked good to me, thanks! So, for rohm-XXXX, bhXXXX, kxXXXX: Reviewed-by: Matti Vaittinen Yours, -- Matti -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~