From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5758FC4332F for ; Thu, 14 Dec 2023 02:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230096AbjLNCot (ORCPT ); Wed, 13 Dec 2023 21:44:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjLNCor (ORCPT ); Wed, 13 Dec 2023 21:44:47 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8BC1BD; Wed, 13 Dec 2023 18:44:51 -0800 (PST) X-UUID: 5c39719a134f4eef9e0ffa98abcdc5f6-20231214 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:6d9f5f62-07da-4d5b-a2a1-77fc2a26c4b6,IP:5,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-10 X-CID-INFO: VERSION:1.1.33,REQID:6d9f5f62-07da-4d5b-a2a1-77fc2a26c4b6,IP:5,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:-10 X-CID-META: VersionHash:364b77b,CLOUDID:91082d61-c89d-4129-91cb-8ebfae4653fc,B ulkID:231214104438TKVN4X1A,BulkQuantity:0,Recheck:0,SF:17|19|44|64|66|24|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS X-UUID: 5c39719a134f4eef9e0ffa98abcdc5f6-20231214 X-User: chentao@kylinos.cn Received: from [172.20.15.254] [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 238258755; Thu, 14 Dec 2023 10:44:37 +0800 Message-ID: <9250b0e9-360d-447d-b4bf-30e4bc4f697c@kylinos.cn> Date: Thu, 14 Dec 2023 10:44:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] igb: Add null pointer check to igb_set_fw_version To: Jakub Kicinski Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, jacob.e.keller@intel.com, przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan References: <20231211031336.235634-1-chentao@kylinos.cn> <20231212132637.1b0fb8aa@kernel.org> Content-Language: en-US From: Kunwu Chan In-Reply-To: <20231212132637.1b0fb8aa@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for your reply. I'll try to use snprintf in v2 patch. On 2023/12/13 05:26, Jakub Kicinski wrote: > On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote: >> kasprintf() returns a pointer to dynamically allocated memory >> which can be NULL upon failure. >> >> Fixes: 1978d3ead82c ("intel: fix string truncation warnings") >> Cc: Kunwu Chan >> Signed-off-by: Kunwu Chan > > The allocation is rather pointless here. > Can you convert this code to use snprintf() instead?