mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, jacob.e.keller@intel.com, horms@kernel.org,
	u.kleine-koenig@pengutronix.de, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ethernet: lantiq_etop: remove redundant device name setup
Date: Sat, 13 Jul 2024 20:02:49 +0200	[thread overview]
Message-ID: <92570003-ddcd-482b-80e1-1da1fa0cc91f@lunn.ch> (raw)
In-Reply-To: <20240713170920.863171-1-olek2@wp.pl>

On Sat, Jul 13, 2024 at 07:09:20PM +0200, Aleksander Jan Bajkowski wrote:
> The same name is set when allocating the netdevice structure in the
> alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there
> is no need to manually set it.

If this one is not needed:

grep -r "eth%d" *
3com/3c515.c:		sprintf(dev->name, "eth%d", unit);
8390/smc-ultra.c:	sprintf(dev->name, "eth%d", unit);
8390/wd.c:	sprintf(dev->name, "eth%d", unit);
8390/ne.c:	sprintf(dev->name, "eth%d", unit);
amd/lance.c:	sprintf(dev->name, "eth%d", unit);
atheros/atlx/atl2.c:	strcpy(netdev->name, "eth%d"); /* ?? */
cirrus/cs89x0.c:	sprintf(dev->name, "eth%d", unit);
dec/tulip/tulip_core.c:		strcpy(dev->name, "eth%d");			/* un-hack */
intel/ixgbe/ixgbe_main.c:	strcpy(netdev->name, "eth%d");
intel/ixgbevf/ixgbevf_main.c:	strcpy(netdev->name, "eth%d");
intel/e100.c:	strcpy(netdev->name, "eth%d");
intel/igbvf/netdev.c:	strcpy(netdev->name, "eth%d");
intel/e1000e/netdev.c:	strscpy(netdev->name, "eth%d", sizeof(netdev->name));
intel/igb/igb_main.c:	strcpy(netdev->name, "eth%d");
intel/igc/igc_main.c:	strscpy(netdev->name, "eth%d", sizeof(netdev->name));
intel/e1000/e1000_main.c:	strcpy(netdev->name, "eth%d");
lantiq_etop.c:	strcpy(dev->name, "eth%d");
micrel/ks8842.c:	strcpy(netdev->name, "eth%d");
smsc/smc9194.c:		sprintf(dev->name, "eth%d", unit);

maybe you can remove all these as well?

      Andrew

  reply	other threads:[~2024-07-13 18:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-13 17:09 Aleksander Jan Bajkowski
2024-07-13 18:02 ` Andrew Lunn [this message]
2024-07-15 14:03   ` Jakub Kicinski
2024-07-15 16:55   ` Aleksander Jan Bajkowski
2024-07-15 14:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92570003-ddcd-482b-80e1-1da1fa0cc91f@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    --cc=pabeni@redhat.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®