From: Hans Zhang <18255117159@163.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, jonathanh@nvidia.com,
thierry.reding@kernel.org, robh@kernel.org,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: tegra194: Clear event counter masks before programming
Date: Sun, 8 Nov 2026 07:15:37 +0800 [thread overview]
Message-ID: <92679da5-7203-4dbb-b00a-ea8ad51be8cb@163.com> (raw)
In-Reply-To: <179408823130.65886.4565928376292834631.b4-reply@b4>
On 11/8/26 05:50, Manivannan Sadhasivam wrote:
> On 2026-11-02 14:38 +0800, Hans Zhang wrote:
>> When programming the RAS-DES event counter control register, the code only
>> cleared the event-selection field before OR-ing in the new group, event,
>> and enable values. This leaves stale bits in the group-select and enable
>> fields from prior writes.
>>
>> Clear all three field masks before programming the register so that stale
>> bits are not preserved across updates.
>>
>> No functional change intended beyond ensuring the register is rewritten
>> without carrying over previous field values.
>>
>> Signed-off-by: Hans Zhang <18255117159@163.com>
>
> This patch got superseded by this commit:
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=fe84c0b370889bbf65f75bb75a1810227c7ce150
>
> - Mani
>
Hello Mani,
This is an evaluation comment from Bjorn regarding me. I didn't notice
that Manikanta Maddireddy had made the changes. Please drop this patch.
https://lore.kernel.org/linux-pci/20261019171244.GA2200874@bhelgaas/
Best regards,
Hans
prev parent reply other threads:[~2026-11-07 23:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 6:38 Hans Zhang
2026-11-07 21:50 ` Manivannan Sadhasivam
2026-11-07 23:15 ` Hans Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92679da5-7203-4dbb-b00a-ea8ad51be8cb@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®