From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6922C433F5 for ; Thu, 10 Feb 2022 17:02:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244993AbiBJRCR (ORCPT ); Thu, 10 Feb 2022 12:02:17 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242483AbiBJRCP (ORCPT ); Thu, 10 Feb 2022 12:02:15 -0500 Received: from relay4.hostedemail.com (relay4.hostedemail.com [64.99.140.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CF01B91 for ; Thu, 10 Feb 2022 09:02:16 -0800 (PST) Received: from omf03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B1DF2968; Thu, 10 Feb 2022 17:02:13 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA id 11C1660016; Thu, 10 Feb 2022 17:01:44 +0000 (UTC) Message-ID: <926e5c35d50ec5f6d7e789831be96744ca8d6423.camel@perches.com> Subject: Re: [PATCH v5 01/13] module: Move all into module/ From: Joe Perches To: Aaron Tomlin , Christophe Leroy Cc: "mcgrof@kernel.org" , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "atomlin@atomlin.com" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" Date: Thu, 10 Feb 2022 09:02:09 -0800 In-Reply-To: References: <20220209170358.3266629-1-atomlin@redhat.com> <20220209170358.3266629-2-atomlin@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout08 X-Rspamd-Queue-Id: 11C1660016 X-Stat-Signature: iz1wokkybbs73un6ik5i8wgk4d48418d X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+axLrpIxj27ofZZzUZv90vffF51j0MMg0= X-HE-Tag: 1644512504-437677 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2022-02-10 at 14:45 +0000, Aaron Tomlin wrote: > On Thu 2022-02-10 11:11 +0000, Christophe Leroy wrote: > > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > > @@ -13001,7 +13001,7 @@ L: linux-kernel@vger.kernel.org > > > S: Maintained > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next > > > F: include/linux/module.h > > > -F: kernel/module.c > > > +F: kernel/module/main.c > > > > Shouldn't it be the entire directory ? > > Indeed it should. Moving forward: kernel/module/* Better would be: F: kernel/module/ in case it ever gets subdirectories too.