From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757527Ab3A1RAf (ORCPT ); Mon, 28 Jan 2013 12:00:35 -0500 Received: from host171.canaca.com ([67.55.55.225]:37428 "EHLO host171.canaca.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756631Ab3A1RAd (ORCPT ); Mon, 28 Jan 2013 12:00:33 -0500 Message-ID: <926ebbac6c9e2f8db795dd0ef1ba3647.squirrel@mungewell.org> In-Reply-To: References: <1359095687-13398-1-git-send-email-simon@mungewell.org> <1b4d173a8f4cbb94f6d99ae5c75c10d5.squirrel@mungewell.org> Date: Mon, 28 Jan 2013 12:00:32 -0500 Subject: Re: [PATCH 1/4] USB: HID: SRW-S1 Gaming Wheel Driver From: simon@mungewell.org To: "Jiri Kosina" Cc: "Simon Wood" , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, rosegardener@freeode.co.uk User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host171.canaca.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mungewell.org X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, 28 Jan 2013, simon@mungewell.org wrote: > >> >> From: simon >> >> >> >> Add support the SRW-S1 by patching HID descriptor to read axis >> >> as Generic Desktop X, Y and Z (rather than Usage page being >> >> 'Simulation'). >> >> >> >> Signed-off-by: Simon Wood >> >> tested-by: John Murphy >> > >> > Hi Simon, >> > >> > thanks for the patch. >> > >> >> >> >> --- >> >> drivers/hid/Kconfig | 6 +++++ >> >> drivers/hid/Makefile | 1 + >> >> drivers/hid/hid-core.c | 1 + >> >> drivers/hid/hid-ids.h | 3 +++ >> >> drivers/hid/hid-srws1.c | 58 >> >> +++++++++++++++++++++++++++++++++++++++++++++++ >> > >> > Is hid-srws1 really the best name? My understanding is that the vendor >> is >> > called Steelseries, and we mostly stick to calling the drivers >> according >> > to the device vendors (and grouping the quirks accordingly). >> > >> > So how about hid-steelseries? >> >> I'm happy to change it; However Steelseries' other devices are all >> keyboards/mice intended for/marketed at gamers. Since other Steelseries >> devices are unlikely to have the same structure (OK I'm just guessing on >> that) is it better to keep this driver somewhat 'seperated'? >> >> I mean, not make life difficult trying to merge keyboard code in with >> this >> wheel's code.... if that is required in future. > > I don't think it's strictly required, but it seems to work quite nicely > for other drivers as well. OK I'll wait a couple of days in-case any more comments come in and re-do the patch with the file name 'hid-steelseries.c' towards the end of the week. Thanks, Simon