From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 477EAC10F1B for ; Tue, 13 Dec 2022 22:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236692AbiLMWeK (ORCPT ); Tue, 13 Dec 2022 17:34:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236695AbiLMWeG (ORCPT ); Tue, 13 Dec 2022 17:34:06 -0500 Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7D801D0D6; Tue, 13 Dec 2022 14:34:04 -0800 (PST) Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-143ffc8c2b2so14405273fac.2; Tue, 13 Dec 2022 14:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=/fFeUAjkN2sqCp/aWpmlhYqWcosd7bu4zCqaYFPx7tU=; b=fSFyvv+rGf7AeNxmo2f8BBkjF+DdH7K8ODoyHhIQtDHrcsYEJNBf++k9FH9D/8D7+o GyEzGW6O+QyCDS4jE5xbuiCHjvXJWoGaiNVBss+EZlhBCt07NzgsVPc7iIk0MZboufC8 ZZXe3h62JXiXsh+6k15xuByJ3xnDiDefvkCNQUH7FBM3xqTsMj1KnbYjsX7WDUY/2Ys4 NdOlFHFSPKFlaFqOrdbx9Lja7rLUOOjQ53c3ufSHeF3n0OR+Bwfjph0zywBU1e4E7lcT HbCdcfZofTu81uf4CbVPprZayLWJsBq/orOuFi57spUXHjM8mEJOT6jjOTTn7TWqlI3T K+kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/fFeUAjkN2sqCp/aWpmlhYqWcosd7bu4zCqaYFPx7tU=; b=BF3beeiY0abMEyDLGnj51rNuYeJeapxnr3Daln4jcRQ72k5mVZWL11U6qpa9PfR9wz IoaYfrp5zHvLnMy2cnnqYTGKdY1B81rMhfbg8DTDPTzVzvJxvIS7w/WD21Z7f4uw9t73 thv2U3dOdlXTurknW/sArw6Oz0mxlCi5ieDsw6v5fnNAUdMrUl6vaXnuC8Ee464jIjRE 774MwKVnY21qdbOPzDfAcG0eUIQTz6dcU3na3IBFq22y+9wdjh5f8HOwhX+yDsUaVsg2 QUleDs9gF3NjK53DEB/tmLL1HPzZgoVl3QTFy94DZT64uXpJLJtbmedqDuzkCQdDNch1 lqmg== X-Gm-Message-State: ANoB5pkoMhm7luOeKZdZAQtCAfTS7/sGphGERhv6xEvUX7J2uUGC/bky UoXYhLoIKGDPOBPZqx+UWwL2nfoQ3NY= X-Google-Smtp-Source: AA0mqf5E4RwQTasX6iyRJ7VELlNhdyDlkpvYi7MNhdNlFd0rLZjuEctPuXdf8b8hBIAygKL2/2xmxw== X-Received: by 2002:a05:6870:314:b0:13c:a5d1:35d7 with SMTP id m20-20020a056870031400b0013ca5d135d7mr9803405oaf.25.1670970843420; Tue, 13 Dec 2022 14:34:03 -0800 (PST) Received: from [127.0.0.1] ([187.19.236.93]) by smtp.gmail.com with ESMTPSA id l32-20020a05687106a000b0014b8347e1e3sm428649oao.12.2022.12.13.14.34.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 14:34:03 -0800 (PST) Date: Tue, 13 Dec 2022 19:33:42 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers , Athira Rajeev CC: Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Nick Desaulniers , LKML , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Subject: Re: [PATCH 2/3] perf build: Use libtraceevent from the system User-Agent: K-9 Mail for Android In-Reply-To: References: <36CD1041-0CAE-41C1-8086-C17854531B3E@linux.vnet.ibm.com> <8F6F0C27-53F3-4837-A19C-845768253249@linux.vnet.ibm.com> Message-ID: <927374FD-C6C0-42B3-9F93-5379A5898FB3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On December 13, 2022 7:09:07 PM GMT-03:00, Ian Rogers wrote: >Thanks Athira and Arnaldo=2E It is a little strange to me to be using >the shell to do a version number test=2E The intent was to be doing >these in the code: >#if LIBRTRACEEVENT_VERSION >=3D MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) >vs >=2E=2E=2E >LIBTRACEEVENT_VERSION_WITH_TEP_FIELD_IS_RELATIVE :=3D $(shell expr 1 \* >255 \* 255 + 5 \* 255 + 0) # 1=2E5=2E0 >ifeq ($(shell test $(LIBTRACEEVENT_VERSION_CPP) -gt >$(LIBTRACEEVENT_VERSION_WITH_TEP_FIELD_IS_RELATIVE); echo $$?),0) >CFLAGS +=3D -DHAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE >endif >=2E=2E=2E >#ifdef HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE >I'm a little selfish as I'm maintaining a bazel build and a single >version number to maintain is easier than lots of HAVE_=2E=2E=2E tests=2E= I'm >happy to follow Arnaldo's lead=2E I think the test should also be >greater-equal rather than greater-than: >https://git=2Ekernel=2Eorg/pub/scm/libs/libtrace/libtraceevent=2Egit/tree= /include/traceevent/event-parse=2Eh?h=3Dlibtraceevent-v1=2E5#n128 I'll fix that, and in a case like this please consider to send a patch wit= h your preference, I'd happily graft it=2E - Arnaldo=20 >