From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759400AbdAKUw2 (ORCPT ); Wed, 11 Jan 2017 15:52:28 -0500 Received: from mout.web.de ([212.227.17.11]:56709 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759331AbdAKUw0 (ORCPT ); Wed, 11 Jan 2017 15:52:26 -0500 Subject: [PATCH 16/18] mtd-cfi_cmdset_0020: Use kmalloc_array() in cfi_staa_setup() To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Marek Vasut , Richard Weinberger References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <927b2449-3de4-83aa-8d23-ef0a6461ecfe@users.sourceforge.net> Date: Wed, 11 Jan 2017 21:51:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CcvhOWTQxe4uhaiV3ee051jXSNclSM9/YblaD+x82DKDTZV2/P2 7yn6UwvTLcDp+GWVS8uaqv385XWioJZq1UN44rcJ9UXlRI48LymjKPrRvbX2IPtjVmH/Czf +GMiz5/ww8Mozx8HGpjJUVmmTRZv0t7x1DBw7RYHuUPbl+rvE7PfE+qLKwGHzSJ2pdugBJU 92H0GKDuusbiUs2suy3Gw== X-UI-Out-Filterresults: notjunk:1;V01:K0:S9Jjp62VhOM=:pmXghOIpHYr7C398x8X6W8 gbeFfhI5vxNSQXK4/Z4sc/scNuicObudez8iTq7AuOpzdW9IeAbiiPNEAiMh2ojuy7QuUabCT D6emWSOThcQP3wmPOsD9I1kzTiw/R6vgCOsBCuwxMr5S3+wq/BTCVxuFrVjfCoj1tDOuFDuYz H2+4ZAoke/QflXjwO/2ydfNOXFOHGqqEborartYtENXq6zNou/JrJubKzy4+eiV0IaSsVNdJX krlAOtWbnZNcaUbjGOBF5oKb0RPE4ro0RqQHM5KisesjgIjp5VGFDbuvP2fEflbx6oK5Z38Md CFIB5YQGL+XZZEqrt3N1NXv5U/J/IrE+p6Z5hOrnkFBBzdXY00jmi6dg8tGJhHYOKjGDadIhg sVHHIGEZ5tv86TIyS8cik2CjT6UMyNXDJ5JZ3L+/WNr8e9F8xyAunCaeEWt6UZ2pl/Xeb6Qgg DTSXZL+V4yDIMLTw0/coyK5+OhHOnagd1WteK6qi3osHcHpdKUh1uvLvq4Yua5YbrNKmJkVkn eGw+Y/tQxXjocfsUQaI2+YODxf54ZFPCS9N1ehwTwO8rbIxdECVHkABCNDNlshL12j466Bp1U xfo8+79kHqY4v/l1hXjkVT+zxWv3iFCzllS8Mgo12HA8n2d2kjEtzjsNZv3S4zHa/kW+h5uqD YF0XO/gvaY99zYtbjTNZy3ziTrBHHyQj3JcAsuoJVWRItXbodJWGMgWLqNVubqEvyomL72eJ+ 24JXQ9Y/5VRIjHpIOPKPpH0Z41sbD1+or6V3A98ydlHJamb2mbrhZ96nkPf+S87N4cgeNncU9 FivlnlV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 11 Jan 2017 19:33:48 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/chips/cfi_cmdset_0020.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0020.c b/drivers/mtd/chips/cfi_cmdset_0020.c index 94d3eb42c4d5..9cd7b1c6faba 100644 --- a/drivers/mtd/chips/cfi_cmdset_0020.c +++ b/drivers/mtd/chips/cfi_cmdset_0020.c @@ -184,8 +184,9 @@ static struct mtd_info *cfi_staa_setup(struct map_info *map) mtd->size = devsize * cfi->numchips; mtd->numeraseregions = cfi->cfiq->NumEraseRegions * cfi->numchips; - mtd->eraseregions = kmalloc(sizeof(struct mtd_erase_region_info) - * mtd->numeraseregions, GFP_KERNEL); + mtd->eraseregions = kmalloc_array(mtd->numeraseregions, + sizeof(*mtd->eraseregions), + GFP_KERNEL); if (!mtd->eraseregions) { kfree(cfi->cmdset_priv); kfree(mtd); -- 2.11.0