From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751637AbdLIMVM (ORCPT ); Sat, 9 Dec 2017 07:21:12 -0500 Received: from smtp.domeneshop.no ([194.63.252.55]:32930 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbdLIMVK (ORCPT ); Sat, 9 Dec 2017 07:21:10 -0500 Subject: Re: [PATCH v1 2/2] drm/tinydrm: add driver for ST7735R panels To: David Lechner , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Cc: limor@ladyada.net, Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org References: <1511924469-11448-1-git-send-email-david@lechnology.com> <1511924469-11448-3-git-send-email-david@lechnology.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <927ddfa7-92b5-7dd0-44c4-0b02a998cd88@tronnes.org> Date: Sat, 9 Dec 2017 13:21:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1511924469-11448-3-git-send-email-david@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 29.11.2017 04.01, skrev David Lechner: > This adds a new driver for Sitronix ST7735R display panels. > > This has been tested using an Adafruit 1.8" TFT. > > Signed-off-by: David Lechner > --- > diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tinydrm/st7735r.c > +static struct drm_driver st7735r_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME | > + DRIVER_ATOMIC, > + .fops = &st7735r_fops, > + TINYDRM_GEM_DRIVER_OPS, > + .lastclose = tinydrm_lastclose, I was reminded of this since it would have made it easy to turn off the panel and see if it turned white. Adding this makes it possible to send commands from userspace for testing:     .debugfs_init        = mipi_dbi_debugfs_init, If you do that you have to set this to NULL since it's not possible to read from the controller in this panel:     mipi->read_commands = NULL; Noralf.