Re: [PATCH 1/1 RESEND] drivers/pnp/resource.c: remove positive test on unsigned values

["Rafael J. Wysocki" <rjw@rjwysocki.net>]

On Saturday, May 10, 2014 12:47:15 PM Fabian Frederick wrote:
> irq and dma are both resource_size_t (derived from phys_addr_t <-> unsigned)
> 
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Queued up for 3.16, thanks!

> ---
>  drivers/pnp/resource.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index 01712cb..782e822 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -360,7 +360,7 @@ int pnp_check_irq(struct pnp_dev *dev, struct resource *res)
>  		return 1;
>  
>  	/* check if the resource is valid */
> -	if (*irq < 0 || *irq > 15)
> +	if (*irq > 15)
>  		return 0;
>  
>  	/* check if the resource is reserved */
> @@ -424,7 +424,7 @@ int pnp_check_dma(struct pnp_dev *dev, struct resource *res)
>  		return 1;
>  
>  	/* check if the resource is valid */
> -	if (*dma < 0 || *dma == 4 || *dma > 7)
> +	if (*dma == 4 || *dma > 7)
>  		return 0;
>  
>  	/* check if the resource is reserved */
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.