From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16CEE32F764 for ; Mon, 24 Aug 2026 19:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787598007; cv=none; b=oxYW9NQWa9ZbASG+inrlBjp74afMQ6JMgLu6etWa1JZmcTwDrsR/0NkIgfsR2mkz+GOfSR2fUUPKGaZfrJCsCdO619p04IOY4auHIITwSTgENicDuiW22gd9eCG5U16evwsc3afWQLjrE/A+MtYENeWEu3vtyN8Hhdb8bKlvE5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787598007; c=relaxed/simple; bh=/G/bhdwSBXgxLht/9l67PKXD25LbrwqjA+HqIWeioC4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dWXyl8kp0SMphomdShoV2ZTT3tyKxqiY3w8viepDTEPy0GPp0vDVqs0ClVaQjNrX4uvtbeNpEe0r16k11hfljzbUa7qgJaDSsepyXq3bPAtbSHYf+q9mJhi2Zc6o1g4CWyo4+ixvoBzE30N7tzTLWTxZdZDbKicY50HEtTS4UDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CqhQ2Cov; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CqhQ2Cov" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-472326ca506so2017901f8f.2 for ; Mon, 24 Aug 2026 12:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787598004; x=1788202804; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=65NP61gKnJpo0qnqpfFXMm215YvFjmk0/dMgC3HflCE=; b=CqhQ2CovTnjNsDHLfRzsBDCBMflZ3nmgmCQ2ttNac4r0ephCrq7kk40ArA3VF64apJ C4oGdHi/ooplzLyLqJGkwkxsRgXYeMbxTZ9y2wiERESFOBJKmf1AdQYjOYPJUjAADhDv cs58/yBC5fqCaDYEtjgoS5TwEX1258XjBMUv89KzOG3yhxa9FHMzBQ9TgjbRpm9jj6ww 9Z8zZfxuvkxfutc+PB9Y4Y71u2nF60ZGYedHrZD110WOzoAcDOj84oQGQDodKNW2v2v2 qzv78t2OyP4/HQ5fr/FThfUV7XHwVw56bqNe8so1sQNiT/QEXKgp+9/UK2xQOh4wZ0S0 MXfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787598004; x=1788202804; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=65NP61gKnJpo0qnqpfFXMm215YvFjmk0/dMgC3HflCE=; b=HcEFi9N6+ZVuAQqNn7MEafooOZ4p//qHcn7GIawpMECva7FzQ1I2EWMnbbXlWNkTbK RDzvTM3Rw8gYdwE7VSdcV+4gJXPzWQkH3cIskbW6CI3spid/3jfXEUk5S0UGyd4wYjq2 eNuPRt8PNMhLhGaEA8kRM4FfcOU5pdfwlWgBaxlP616HTUdGKz/s1YbFPFp4U3NpbPHW trRkBmKHnZjhVjsOBzhNc8Qz0IAZEOg4cjNpPMsVom3/vjES5q+qI6P1iS4zZ2wmAghE b0VzFKD5cW4Z5rc34HXjuhaaiK4Pv4oJv/5O/I3RcL8coCVCuyA/xfXkC9ibizJoYNpb IPVw== X-Forwarded-Encrypted: i=1; AHgh+Rps2h/5cgkamVQu8ZIi4wUsgRBA6REciIcUzUL2INXK+0dQn4zrFC0eYjyQSwkpGs+8cEXJuVESJdqgPBY=@vger.kernel.org X-Gm-Message-State: AFuF++lTfhQ76QkfN56gOdpZgUPnuaNs8L+Rh88iHjW/DiR/+DgJapQx dX9k0ZEaytItcwj6lUwjx48EOTxTuc7Klj/807M6RNDGi4HYEaWCQRjM X-Gm-Gg: AR+sD10CAowKk9ilekRenApgYI1uG7/WXlJbCqn4QNnWTzPIvOklQkhHDmZz3E/O9KH jMyPRvXGCwIyoVrb/9DRXEv8lSGBYsn9MWpNhAYXKO7FfLTRzST30uw57E66kQQBfSUV8Y1ak8U ACKtSfi6Aw9tgu56npycRhjhublpGodJJ1p0B1bWPVveto1V0MI4FD/Oh+eYPN/TZZ/vJiOiszW QKRBNBHAfUv22oFA8sDRdZK2Oh4tGV51KCQtjemI1hcVP+sHPMw7G0tj7GYsjAQaY8m34Jwd5RJ 3xP6RLz4X5T/XELHpQd5JpF7JftiJgs74gvq39+9Se9A5IQ3MVnxkqpvSJ7KUHWk8WA2L0FmLg4 Kg/T/Wq6qIwL651762DU9Pq1a+jRvOCxRLWgDEaBjLmobIWuyTShNAsHULrHegMvLLHWmX+6fr4 e7XtIk/1PzpJBAIyjm1UoVgqwA6Td0fC59ua+XjRQB48tcfaU0yQhWObR6C97vF5wFXnmZSkwTg 40BlBLhCaIOdXiDvpVu4Liqm8JsNxWYU50dr+/up9wX+W7we9pZRdKXOJMdidEXXvkx X-Received: by 2002:a05:6000:400c:b0:481:5bce:44b3 with SMTP id ffacd0b85a97d-482c0ba22e3mr37716386f8f.16.1787598004049; Mon, 24 Aug 2026 12:00:04 -0700 (PDT) Received: from [10.128.10.232] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482c9bfd865sm8813534f8f.22.2026.08.24.12.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 12:00:03 -0700 (PDT) Sender: Julian Braha Message-ID: <928e0a09-edd0-4f1d-ac6b-c225b4cd6fab@gmail.com> Date: Mon, 24 Aug 2026 20:00:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW To: Marc Zyngier Cc: florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, linux@armlinux.org.uk, tglx@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, bcm-kernel-feedback-list@broadcom.com, radu@rendec.net, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, arnd@arndb.de, sudeep.holla@kernel.org, mark.rutland@arm.com, lpieralisi@kernel.org References: <20260823180832.1246363-1-julianbraha@gmail.com> <87cxv7o62i.wl-maz@kernel.org> Content-Language: en-US From: Julian Braha In-Reply-To: <87cxv7o62i.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Marc, On 8/24/26 17:07, Marc Zyngier wrote: > On Sun, 23 Aug 2026 19:08:32 +0100, > Julian Braha wrote: >> >> ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its >> dependency, ARM_PSCI_FW, is met. However, ARM_PSCI_FW is always enabled on >> for arm64, and the GICv3 driver only uses HAVE_ARM_SMCCC_DISCOVERY to >> identify the NVIDIA T241, which is arm64 anyway. >> >> Also adds fallbacks for callers to avoid needing #ifdef guards when >> HAVE_ARM_SMCCC_DISCOVERY is disabled (32bit arm). > > What does this 'Also' tell you? That this part is in the wrong patch. > > This should be split in two different patches, fixing different > problems. One to allow graceful fallback of the SMCCC_DISCOVERY stuff > when it isn't selected, and another to only force the selection of > that option on arm64 when GICv3 is selected. > Thank you for reviewing, will split out these changes. - Julian Braha