mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Coly Li <i@coly.li>
To: Helge Deller <deller@gmx.de>
Cc: linux-kernel@vger.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH 06/14] md/bcache: Use %pS printk format for direct addresses
Date: Thu, 7 Sep 2017 15:49:57 +0800	[thread overview]
Message-ID: <928ff0ac-41e3-7e5e-45f4-bee69c6a4503@coly.li> (raw)
In-Reply-To: <30e9400c-b95d-5720-f9a0-6086f08ecd4a@gmx.de>

On 2017/9/7 下午3:42, Helge Deller wrote:
> On 07.09.2017 06:50, Coly Li wrote:
>> On 2017/9/7 上午4:27, Helge Deller wrote:
>>> Use the %pS instead of the %pF printk format specifier for printing symbols
>>> from direct addresses. This is needed for the ia64, ppc64 and parisc64
>>> architectures.
>>>
>>> Signed-off-by: Helge Deller <deller@gmx.de>
>>> Cc: linux-bcache@vger.kernel.org
>>> Cc: linux-raid@vger.kernel.org
>>> ---
>>>  drivers/md/bcache/closure.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
>>> index 864e673..0b0c9bc 100644
>>> --- a/drivers/md/bcache/closure.c
>>> +++ b/drivers/md/bcache/closure.c
>>> @@ -175,7 +175,7 @@ static int debug_seq_show(struct seq_file *f, void *data)
>>>  	list_for_each_entry(cl, &closure_list, all) {
>>>  		int r = atomic_read(&cl->remaining);
>>>  
>>> -		seq_printf(f, "%p: %pF -> %pf p %p r %i ",
>>> +		seq_printf(f, "%p: %pS -> %pf p %p r %i ",
>>>  			   cl, (void *) cl->ip, cl->fn, cl->parent,
>>>  			   r & CLOSURE_REMAINING_MASK);
>>>  
>>> @@ -187,7 +187,7 @@ static int debug_seq_show(struct seq_file *f, void *data)
>>>  			   r & CLOSURE_SLEEPING	? "Sl" : "");
>>>  
>>>  		if (r & CLOSURE_WAITING)
>>> -			seq_printf(f, " W %pF\n",
>>> +			seq_printf(f, " W %pS\n",
>>>  				   (void *) cl->waiting_on);
>>>  
>>>  		seq_printf(f, "\n");
>>>
>>
>> It is unclear to me, that if %pF is used, on ia64/ppc64/parisc64 a
>> function descriptor conversion happens, what negative effect exactly
>> takes place ?
> 
> On ia64/ppc64/parisc64 the kernel will crash here in the worst case, because
> vsprintf() will try to read a pointer from that address and resolve it. 
> But you hand over a return address (_RET_IP_) which should be 
> resolved directly to a symbol. For that you need to use the %pS specifier,
> which is what my patch does.
> 
> The patch has no negative effect on any platform. Output will still be the
> same on x86/mips/arm/... as it has been before with %pF. The only positive
> effect of the patch is that the seq_printf will now show correct output on 
> ia64/ppc64/parisc64 too.

Oh I see. The patch is OK to me, but could you please add the above
information in the commit log, it will help other bcache developers to
understand the patch. Thanks in advance for doing this.

BTW, I also suggest to fix vsprintf() for this issue. For most of
developers, we don't have sense for such issue on ia64/ppc64/parisc64,
it is still very probably someone else makes similar mistake in future.
If vsprintf() can be fixed, the potential risk can be safe.


-- 
Coly Li

  reply	other threads:[~2017-09-07  7:50 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 20:27 [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Helge Deller
2017-09-06 20:27 ` [PATCH 01/14] arm: Use %pS printk format for symbols from direct addresses Helge Deller
2017-09-06 20:27 ` [PATCH 02/14] um: " Helge Deller
2017-09-12 12:10   ` Petr Mladek
2017-09-21 20:13     ` Richard Weinberger
2017-09-06 20:27 ` [PATCH 03/14] x86: " Helge Deller
2017-09-06 20:27 ` [PATCH 04/14] ti_sci: Use %pS printk format for " Helge Deller
2017-09-08 23:30   ` Nishanth Menon
2017-09-09  0:30     ` Santosh Shilimkar
2017-09-06 20:27 ` [PATCH 05/14] i915: " Helge Deller
2017-09-27 12:24   ` [Intel-gfx] " Daniel Vetter
2017-09-06 20:27 ` [PATCH 06/14] md/bcache: " Helge Deller
2017-09-07  4:50   ` Coly Li
2017-09-07  7:42     ` Helge Deller
2017-09-07  7:49       ` Coly Li [this message]
2017-09-07  8:05       ` Sergey Senozhatsky
2017-09-06 20:27 ` [PATCH 07/14] power/avs: " Helge Deller
2017-09-08 23:37   ` Nishanth Menon
2017-09-06 20:27 ` [PATCH 08/14] fs/f2fs: " Helge Deller
2017-09-06 20:27 ` [PATCH 09/14] fs/pstore: " Helge Deller
2018-11-29 23:26   ` Kees Cook
2018-11-29 23:49     ` Luck, Tony
2018-11-30  0:40       ` Kees Cook
2017-09-06 20:27 ` [PATCH 10/14] fs/xfs: " Helge Deller
2017-09-08  7:38   ` Christoph Hellwig
2017-09-18 18:37   ` Darrick J. Wong
2017-09-06 20:27 ` [PATCH 11/14] smp: Use %pF printk format specifier for function pointers Helge Deller
2017-09-06 20:27 ` [PATCH 12/14] mm/memblock: Use %pS printk format for direct addresses Helge Deller
2017-09-06 20:28 ` [PATCH 13/14] netfilter/ipvs: " Helge Deller
2017-10-09  5:52   ` Simon Horman
2017-11-06 13:46     ` Pablo Neira Ayuso
2017-09-06 20:28 ` [PATCH 14/14] sound/core: " Helge Deller
2017-09-07  8:36   ` Takashi Iwai
2017-09-07  0:45 ` [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Sergey Senozhatsky
2017-09-07  6:01   ` Helge Deller
2017-09-07  7:56     ` Sergey Senozhatsky
2017-09-07  8:32       ` Sergey Senozhatsky
2017-09-07  9:12         ` Helge Deller
2017-09-07  9:36           ` Sergey Senozhatsky
2017-09-07  9:51             ` Sergey Senozhatsky
2017-09-07 12:38               ` Helge Deller
2017-09-07 16:05                 ` Luck, Tony
2017-09-08  6:18                   ` Sergey Senozhatsky
2017-09-08 17:25                     ` Luck, Tony
2017-09-08 18:28                       ` Helge Deller
2017-09-14  7:40                         ` Sergey Senozhatsky
2017-09-14  8:03                           ` Sergey Senozhatsky
2017-09-14  8:39                             ` Helge Deller
2017-09-14  9:27                               ` Sergey Senozhatsky
2017-09-14  9:47                                 ` Helge Deller
2017-09-14 16:01                                   ` Luck, Tony
2017-09-18  7:03                                     ` Sergey Senozhatsky
2017-09-14  6:53                       ` Sergey Senozhatsky
2017-09-08 20:49                     ` Helge Deller
2017-09-12 11:18                       ` Petr Mladek
2017-09-14  6:44                       ` Sergey Senozhatsky
2017-09-08 22:23                     ` Yu, Fenghua
2017-09-14  6:35                       ` Sergey Senozhatsky
2017-09-07 16:50                 ` Joe Perches
2017-09-08  6:23 ` Sergey Senozhatsky
2017-09-08 20:39   ` Helge Deller
2017-09-12 12:23 ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=928ff0ac-41e3-7e5e-45f4-bee69c6a4503@coly.li \
    --to=i@coly.li \
    --cc=akpm@linux-foundation.org \
    --cc=deller@gmx.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®