From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C603C5B57E for ; Sun, 30 Jun 2019 17:11:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 05E3520673 for ; Sun, 30 Jun 2019 17:11:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbfF3RLg (ORCPT ); Sun, 30 Jun 2019 13:11:36 -0400 Received: from mga05.intel.com ([192.55.52.43]:55552 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbfF3RLg (ORCPT ); Sun, 30 Jun 2019 13:11:36 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2019 10:11:35 -0700 X-IronPort-AV: E=Sophos;i="5.63,436,1557212400"; d="scan'208";a="157070002" Received: from spandruv-mobl.amr.corp.intel.com ([10.251.15.131]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2019 10:11:34 -0700 Message-ID: <92900b0ce2333e3d04f197d3b7d3eaaf0b95432f.camel@linux.intel.com> Subject: Re: [PATCH 10/10] tools/power/x86: A tool to validate Intel Speed Select commands From: Srinivas Pandruvada To: Andy Shevchenko Cc: Darren Hart , Andy Shevchenko , Andriy Shevchenko , Jonathan Corbet , "Rafael J. Wysocki" , Alan Cox , Len Brown , prarit@redhat.com, darcari@redhat.com, Linux Documentation List , Linux Kernel Mailing List , Platform Driver Date: Sun, 30 Jun 2019 10:11:34 -0700 In-Reply-To: References: <20190626223851.19138-1-srinivas.pandruvada@linux.intel.com> <20190626223851.19138-11-srinivas.pandruvada@linux.intel.com> <1c4238f7d18d316df82d3ba1618fecdcf014f98a.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-06-29 at 19:00 +0300, Andy Shevchenko wrote: > On Sat, Jun 29, 2019 at 5:53 PM Srinivas Pandruvada > wrote: > > On Sat, 2019-06-29 at 17:31 +0300, Andy Shevchenko wrote: > > > On Thu, Jun 27, 2019 at 1:39 AM Srinivas Pandruvada > > > wrote: > > > > +++ b/tools/power/x86/intel_speed_select/Makefile > > > > > > My experience with some tools are not good in order of their > > > build > > > process. > > > Can this one use tools build infrastructure from the day 1? > > > > Can you give some pointers? > > Sure. > > At least simple ones are under tools/gpio, tools/iio, etc. > > You may compare them to see what's different and what's common and > base Makefile here on that. > > I dunno if there is any tool under tools/power to use that, it might > give an example of `descend` feature in Makefile. Sent an update to include this change. Thanks, Srinivas > > > > > @@ -0,0 +1,31 @@ > > > > +# SPDX-License-Identifier: GPL-2.0 > > > > +CC = $(CROSS_COMPILE)gcc > > > > +BUILD_OUTPUT := $(CURDIR) > > > > +PREFIX ?= /usr > > > > +DESTDIR ?= > > > > + > > > > +override CFLAGS += -D__EXPORTED_HEADERS__ -Wall -D_GNU_SOURCE > > > > +override CFLAGS += -I$(CURDIR)/../../../../include/uapi/ > > > > +override CFLAGS += -I$(CURDIR)/../../../../include/ > > > > + > > > > +%: %.c > > > > + @mkdir -p $(BUILD_OUTPUT) > > > > + $(CC) $(CFLAGS) $< -o $(BUILD_OUTPUT)/$@ $(LDFLAGS) > > > > + > > > > +DEPS = isst.h > > > > +OBJ = isst_config.o isst_core.o isst_display.o > > > > + > > > > +%.o: %.c $(DEPS) > > > > + $(CC) -c -o $(BUILD_OUTPUT)/$@ $< $(CFLAGS) > > > > + > > > > +intel-speed-select: $(OBJ) > > > > + $(CC) -o $(BUILD_OUTPUT)/$@ $^ $(CFLAGS) > > > > + > > > > +.PHONY : clean > > > > +clean : > > > > + @rm -f $(BUILD_OUTPUT)/intel-speed-select > > > > + @rm -f $(BUILD_OUTPUT)/*.o > > > > + > > > > +install : intel-speed-select > > > > + install -d $(DESTDIR)$(PREFIX)/sbin > > > > + install $(BUILD_OUTPUT)/intel-speed-select > > > > $(DESTDIR)$(PREFIX)/sbin/intel-speed-select > >