From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752034AbdEBJ3R (ORCPT ); Tue, 2 May 2017 05:29:17 -0400 Received: from mout.web.de ([212.227.17.11]:49317 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdEBJ3O (ORCPT ); Tue, 2 May 2017 05:29:14 -0400 Subject: [PATCH 9/9] pinctrl: Adjust nine checks for null pointers From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <9294b4fd-f4f1-9540-973b-08c0cfee04c8@users.sourceforge.net> Date: Tue, 2 May 2017 11:29:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:em9/yu7jlfDpSjGSkulSJEkqnWxo77YKwXlkz3dRXaqs7fAzNTH QZbwDqXWx626VIy75qh9jI1+ookHAfLaqz7Ts4G0yPlABnE08rr740IuG8CVIp67AzutO9t 9P5GJTRHEQQhEVQ88uyGAxsnFjWT0ypFykTWiVXeLMH/5HArmjJQ9egPP26awQ9Cvs6ffTX XZ8z33FY6RxNirTJVcWYg== X-UI-Out-Filterresults: notjunk:1;V01:K0:kiFmpPRFWlE=:WwADJcvZEbVf/hq5t+SobP O5HK8CKzdrG1cG321St2/qzg3tK0oVSX/TujTAmAmJcH+vKMSNiC0DncJ59liFInr7gCC0TRF G0qjVWvfJXaa3o8p/Zc4uaqM1Gz71pdD9wwHT2BbJysSF5ylFTi0BlMHQo52TG56MJHvaDrLj oaqrRCiZSOxj9oid4MGXorSnlFfzjw8cg8f0SbBfaPt5CRkMSO23qD41vw80ehq9OjWdZr6+3 rTLOGsU8g0sroCthFNUyEpGXZ49kbONLTFs2U44CpkCavEFR9PeMyeZcyWoWVp/oFrVFkKX/B dGJZDojiXLzJykkf9uPT2kjma+GCI3JcMaZwQS5ZFu4exdvwG+CH/TAMCaxNOoHqPscAaondo K6ZlDp6E/8OCG5PRB4tYro5KdgMXGfCP2xlsBbSw0Ru/zc05b5Q3RfWjniPtLRzVy6vAwXdUT ZPuoY6qU6g1r1rhktDF6tmPHesJRqyb7yjhS8RrCnkfxCezlDD/vMSb/iNyPBIaWZy/Jug199 f1rTTyA7MBGYdYYKaDx8iZM9rvs0kzsyPpqEVoCriQqEpcUCanJckONMIIZg85a2nULvzEv9l LqQzun3k5MibhUF2LCfuQeQBUejjIIimxtCyZ/jj0eCrM1AZVLwTvB8XLgWsCysi/g70+o0V6 0YANz2hb6dFJz0ZOFv39PGCkW1jvZdNT9jU40z1cGX2ySEXK5lM5zW1NC99pm97ht88vUInxo +W4YJAa7W7i2temdkPqlmQfUO0k1qneiSV+zjUTIZGS7IMn2iUDYkKOOcFlszLOuxdADzXuOS hWREDpg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 11:04:55 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/pinctrl/core.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 7df16771fa13..b1044f07e0a1 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -170,7 +170,7 @@ const char *pin_get_name(struct pinctrl_dev *pctldev, const unsigned pin) const struct pin_desc *desc; desc = pin_desc_get(pctldev, pin); - if (desc == NULL) { + if (!desc) { dev_err(pctldev->dev, "failed to get pin(%d) name\n", pin); return NULL; @@ -214,7 +214,7 @@ static void pinctrl_free_pindescs(struct pinctrl_dev *pctldev, pindesc = radix_tree_lookup(&pctldev->pin_desc_tree, pins[i].number); - if (pindesc != NULL) { + if (pindesc) { radix_tree_delete(&pctldev->pin_desc_tree, pins[i].number); if (pindesc->dynamic_name) @@ -230,7 +230,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev, struct pin_desc *pindesc; pindesc = pin_desc_get(pctldev, pin->number); - if (pindesc != NULL) { + if (pindesc) { dev_err(pctldev->dev, "pin %d already registered\n", pin->number); return -EINVAL; @@ -248,7 +248,7 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev, pindesc->name = pin->name; } else { pindesc->name = kasprintf(GFP_KERNEL, "PIN%u", pin->number); - if (pindesc->name == NULL) { + if (!pindesc->name) { kfree(pindesc); return -ENOMEM; } @@ -402,7 +402,7 @@ static int pinctrl_get_device_gpio_range(unsigned gpio, struct pinctrl_gpio_range *range; range = pinctrl_match_gpio_range(pctldev, gpio); - if (range != NULL) { + if (range) { *outdev = pctldev; *outrange = range; mutex_unlock(&pinctrldev_list_mutex); @@ -947,7 +947,7 @@ static int add_setting(struct pinctrl *p, struct pinctrl_dev *pctldev, else setting->pctldev = get_pinctrl_dev_from_devname(map->ctrl_dev_name); - if (setting->pctldev == NULL) { + if (!setting->pctldev) { kfree(setting); /* Do not defer probing of hogs (circular loop) */ if (!strcmp(map->ctrl_dev_name, map->dev_name)) @@ -1094,7 +1094,7 @@ struct pinctrl *pinctrl_get(struct device *dev) * return another pointer to it. */ p = find_pinctrl(dev); - if (p != NULL) { + if (p) { dev_dbg(dev, "obtain a copy of previously claimed pinctrl\n"); kref_get(&p->users); return p; @@ -1565,7 +1565,7 @@ static int pinctrl_pins_show(struct seq_file *s, void *what) pin = pctldev->desc->pins[i].number; desc = pin_desc_get(pctldev, pin); /* Pin space may be sparse */ - if (desc == NULL) + if (!desc) continue; seq_printf(s, "pin %d (%s) ", pin, desc->name); @@ -2145,7 +2145,7 @@ void pinctrl_unregister(struct pinctrl_dev *pctldev) { struct pinctrl_gpio_range *range, *n; - if (pctldev == NULL) + if (!pctldev) return; mutex_lock(&pctldev->mutex); -- 2.12.2