From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CEEF3D967F for ; Tue, 14 Jul 2026 08:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784018195; cv=none; b=Doy1MGM0+sm27BjtD2U221vwzGie2kfS8f3Maj6OXKlebQuRoHq6lfaKxw0tMRf9bjUwotFoFh+tFLISU/tOIP3JWvxrdy+81D3+5kXh1CyK6IJihFbvw92jN8rbIX6N/9fuO4E9QbJ67ZS4s07dSrQoh5bciTxkg3SKAq6Rsms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784018195; c=relaxed/simple; bh=AGh5lIWu+Wfrmi++dxD+3aI9DBae6CwPDFEGYSFnVIA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XWO/Yc7HiOpZ/StioYIVIZ39qNIZjlnu9+2VanAnxyoa503lY8VFXTWVcUsCxg42QOCf8oHA/AAsCcazQ5YVyKGharv57b31PnFv8tRvekInRB4L3a+3RFY8xFP7UGuIBf9fB7iz/CIe47thiHZRi2MLkYgAnjC89PdegY7FR+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=Rw7b4Ah+; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="Rw7b4Ah+" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C13E51476; Tue, 14 Jul 2026 01:36:22 -0700 (PDT) Received: from [10.174.43.51] (unknown [10.174.43.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F4743F7B4; Tue, 14 Jul 2026 01:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784018186; bh=AGh5lIWu+Wfrmi++dxD+3aI9DBae6CwPDFEGYSFnVIA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Rw7b4Ah+uga3FnevhlB/g0Y+OhmjMpx14GqulYuXCa//NJplqDatQszbIzym3ESTS sW9yHfsriNZHqLPswLscBCKXftbr0qmWcmhocrkKU1NYPwT6nfnJwbTcrPXFtiUE7A rtngZO/Fhzaxh7c0pZgrcQhTQJrcs+OabQ3b3I0E= Message-ID: <929dedc2-eea3-4153-be6d-d2dd727fed89@arm.com> Date: Tue, 14 Jul 2026 14:06:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/6] mm/vmalloc: Speed up ioremap, vmalloc and vmap with contiguous memory To: Wen Jiang , Andrew Morton Cc: catalin.marinas@arm.com, linux-mm@kvack.org, urezki@gmail.com, will@kernel.org, Xueyuan.chen21@gmail.com, ajd@linux.ibm.com, david@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rppt@kernel.org, ryan.roberts@arm.com, dev.jain@arm.com, Wen Jiang References: <20260709073823.6643-1-jiangwen6@xiaomi.com> <20260709160805.26e63bae89dd03cf2951104e@linux-foundation.org> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/07/26 2:24 PM, Wen Jiang wrote: > On Fri, 10 Jul 2026 at 07:08, Andrew Morton wrote: >> >> On Thu, 9 Jul 2026 15:38:17 +0800 Wen Jiang wrote: >> >>> This patchset accelerates ioremap, vmalloc, and vmap when the memory >>> is physically fully or partially contiguous. >> >> Thanks, I added this to mm.git's mm-new branch for wider testing. >> >> AI review asked some questions, and some of them are new since the v5 >> series: >> https://sashiko.dev/#/patchset/20260709073823.6643-1-jiangwen6@xiaomi.com > > Hi Andrew, > > I've gone through the Sashiko findings: > > - Patch 1 (find_num_contig): Over-interpretation. No new hugetlbfs hstate > is added. The extra sizes are only used by init_mm kernel mappings via. But not sure if that is a right approach. If these multi CONT_PTE sized mappings need to be supported in vmalloc() but without adding corresponding HugeTLB sizes, probably these required helpers could just be factored outside HugeTLB. > > - Patch 5/6 (NULL page): Invalid input. vmap() expects a fully populated > array of valid struct page pointers. > > - Patch 6 (32-bit count << PAGE_SHIFT overflow): Pre-existing. This was > already discussed in the V3 thread, and a separate fix was proposed > there. > > Thanks, > Wen