From: "Adrian McMenamin" <adrianmcmenamin@gmail.com>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Improve behaviour of Dreamcast aica ALSA driver in poor resource conditions
Date: Tue, 3 Jul 2007 22:36:40 +0100 [thread overview]
Message-ID: <92a12cdb0707031436k74a10405p6d3a9976860074de@mail.gmail.com> (raw)
This patch stops the driver from crashing in certain situations (eg if
the network fails when NFS mounted), please apply.
Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
--- alsa-kernel/sh/aica.c 2007-06-23 15:25:55.000000000 +0100
+++ linux-2.6.21/sound/sh/aica.c 2007-07-03 22:28:16.000000000 +0100
@@ -366,7 +366,9 @@
*substream)
{
struct snd_card_aica *dreamcastcard = substream->pcm->private_data;
+ flush_workqueue(aica_queue);
del_timer(&dreamcastcard->timer);
+ aica_chn_halt();
kfree(dreamcastcard->channel);
spu_disable();
return 0;
@@ -402,16 +404,11 @@
static int snd_aicapcm_pcm_trigger(struct snd_pcm_substream
*substream, int cmd)
{
- struct snd_card_aica *dreamcastcard;
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
spu_begin_dma(substream);
break;
case SNDRV_PCM_TRIGGER_STOP:
- dreamcastcard = substream->pcm->private_data;
- if (dreamcastcard->timer.data)
- del_timer(&dreamcastcard->timer);
- aica_chn_halt();
break;
default:
return -EINVAL;
next reply other threads:[~2007-07-03 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 21:36 Adrian McMenamin [this message]
2007-07-03 23:08 ` Adrian McMenamin
2007-07-04 8:51 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92a12cdb0707031436k74a10405p6d3a9976860074de@mail.gmail.com \
--to=adrianmcmenamin@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®