From: Andrew Lunn <andrew@lunn.ch>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Chris Snook <chris.snook@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] net: ag71xx: Use default NAPI weight
Date: Wed, 7 Oct 2026 20:28:22 +0200 [thread overview]
Message-ID: <92a33bec-c409-4595-bb75-8bc83d595cf9@lunn.ch> (raw)
In-Reply-To: <20261007173628.657527-1-rosenp@gmail.com>
On Wed, Oct 07, 2026 at 10:36:28AM -0700, Rosen Penev wrote:
> Drop the custom NAPI weight and let netif_napi_add() use the core
> default.
>
> The old comment claimed larger weights wasted cycles and cache, but
> recent RX and TX path changes altered those tradeoffs. Keep the driver
> on the standard default unless measurements show a device-specific value
> is needed.
>
> iperf3:
>
> Before:
>
> [ ID][Role] Interval Transfer Bitrate Retr
> [ 5][TX-C] 0.00-10.00 sec 327 MBytes 274 Mbits/sec 31 sender
> [ 5][TX-C] 0.00-10.00 sec 325 MBytes 273 Mbits/sec receiver
> [ 7][RX-C] 0.00-10.00 sec 170 MBytes 143 Mbits/sec 0 sender
> [ 7][RX-C] 0.00-10.00 sec 170 MBytes 143 Mbits/sec receiver
>
> After:
>
> [ ID][Role] Interval Transfer Bitrate Retr
> [ 5][TX-C] 0.00-10.00 sec 341 MBytes 286 Mbits/sec 30 sender
> [ 5][TX-C] 0.00-10.00 sec 338 MBytes 284 Mbits/sec receiver
> [ 7][RX-C] 0.00-10.00 sec 184 MBytes 154 Mbits/sec 0 sender
> [ 7][RX-C] 0.00-10.00 sec 184 MBytes 154 Mbits/sec receiver
>
> Assisted-by: LLM
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2026-10-07 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 17:36 Rosen Penev
2026-10-07 18:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92a33bec-c409-4595-bb75-8bc83d595cf9@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®