From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a2-smtp.messagingengine.com (fhigh-a2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A750184A30; Sat, 1 Feb 2025 12:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738411479; cv=none; b=Rl4zl6RzV3MEFhAsXMX0BXfF2ocQvqXqZakgBhYYcA+dK3jjuhCPNPdOkRxD2t6Sut5/UBtSiYLcdSpz+HUofdBLzmSqSC5dP1e0b6qx4lH1j/WB5KB0jhQnVSe+9S6aalPpUef9UiTbSpigo+fYbJvxaBNEPvur4SLV+wO7QMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738411479; c=relaxed/simple; bh=8iKncPFvFN/KqWv1IJCRHmAS1yVFc6ETLBHRNLvI8Kw=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=qKr8rZipwzO5Q2oU343Bc5LOI6iBd5t3FWqACiPGyH8z1WD4xGvXRK7q73+fq9nTxCuy1WYYOluh+7P6N/VlPBqRO/86z3UOyE5yISNYDQzByeRa4Rj71LBET1FK9lVYLZAKtxM9i0MgzJEy8ghtuACPDIoZ4g1+qHwoM50vVOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dxuuu.xyz; spf=pass smtp.mailfrom=dxuuu.xyz; dkim=pass (2048-bit key) header.d=dxuuu.xyz header.i=@dxuuu.xyz header.b=CrdinWTj; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=jFO81lW9; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dxuuu.xyz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dxuuu.xyz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dxuuu.xyz header.i=@dxuuu.xyz header.b="CrdinWTj"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="jFO81lW9" Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id 96E0511400EE; Sat, 1 Feb 2025 07:04:35 -0500 (EST) Received: from phl-imap-08 ([10.202.2.84]) by phl-compute-03.internal (MEProxy); Sat, 01 Feb 2025 07:04:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dxuuu.xyz; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1738411475; x=1738497875; bh=q94BrnE8GmmvJEToiUwE2COPlRZW+gxKKN9ufHNcoBU=; b= CrdinWTj4j5pemeHmxTFUcHhyq1eVgwwCnGEBCWsKTnDsud/lCeo6RLNw5PM2HU9 T4GBS/ADFZkDlXkzFSiQjD2gn6M5WfeRoLuIHCzyqHiVipLlUDaqshyuQImMrUm3 1ATdB/7Z0QUOdjgi3Pe+xDJsPOev7O7k2cHkDPiQf4q7k/ruH7yraOdN7stKO3bR Wfky5D16/eFUJUUNVXhGPgjkgBlTr2q7gjmwMIhBwZB8ZT4o++2vF+H+1+sU2SI+ qekES0KJaqqDXpf3UA/EmcdStGW9reSVGAFosk+X1OWL6SK/2F5ttSj3VK38pS2M Gvt0L3EydwA1XzY+9TkUfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1738411475; x= 1738497875; bh=q94BrnE8GmmvJEToiUwE2COPlRZW+gxKKN9ufHNcoBU=; b=j FO81lW99zu6h7WGYlOzMkDHp2OHlTYjdjlM/rtXJg/fm/yYlw33QG9X673KPNj/y lh1Lq7Zf5mWkV5KWq+DMRFE26UwhTbaFvkaNTjqLin5JLVQZ2OvFOfikDDLbO5PI Edx66nP07RDLV+zUhm8px7s7dgtfR6rhrlX9UuYTMoFXZmQm+8pdyzXLV/rw+0La r961ZEjNR29+kTNR6flxxVNlgBvY+tl9d4R1cXti1oRXYwJJTwk7xYSQ6fTyU0jD t35mrYX14KLGfs2cKqfFmBreZ+9FPSPYQe1QUYkYT4FSWhQhYwPMqos0XUVVsEDj Xht27mdyIBoxfE4ACNL4w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduudeijecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenfghrlhcuvffnffculdefhedmnecujfgurhepofggfffhvfev kfgjfhfutgfgsehtqhertdertdejnecuhfhrohhmpedfffgrnhhivghlucgiuhdfuceoug iguhesugiguhhuuhdrgiihiieqnecuggftrfgrthhtvghrnhepieekudevieffkeevffei hefhtdfftdevteejfeeiveevffevveduteekffffleelnecuffhomhgrihhnpehgihhthh husgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpegugihusegugihuuhhurdighiiipdhnsggprhgtphhtthhopeduledpmhhouggvpe hsmhhtphhouhhtpdhrtghpthhtohepmhihkhholhgrlhesfhgsrdgtohhmpdhrtghpthht ohepshgufhesfhhomhhitghhvghvrdhmvgdprhgtphhtthhopegvugguhiiikeejsehgmh grihhlrdgtohhmpdhrtghpthhtohepjhhohhhnrdhfrghsthgrsggvnhgusehgmhgrihhl rdgtohhmpdhrtghpthhtohephhgrohhluhhosehgohhoghhlvgdrtghomhdprhgtphhtth hopegurghnihgvlhesihhoghgvrghrsghogidrnhgvthdprhgtphhtthhopegrnhgurhhi iheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghstheskhgvrhhnvghlrdhorhhgpd hrtghpthhtohepjhholhhsrgeskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i6a694271:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id BFC0718A006B; Sat, 1 Feb 2025 07:04:33 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sat, 01 Feb 2025 13:04:13 +0100 From: "Daniel Xu" To: "Ilya Leoshkevich" Cc: "Shuah Khan" , "Eduard Zingerman" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "John Fastabend" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Mykola Lysenko" , "bpf@vger.kernel.org" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "Marc Hartmayer" Message-Id: <92a6f664-01b8-46bc-8712-6e5a5ac3d851@app.fastmail.com> In-Reply-To: <20f56c02-688d-4f22-97dc-cc5b3800de3f@app.fastmail.com> References: <68f3ea96ff3809a87e502a11a4bd30177fc5823e.1736886479.git.dxu@dxuuu.xyz> <78b2e750b4568e294b5fc5a33cf4bc8f62fae7f6.camel@linux.ibm.com> <20f56c02-688d-4f22-97dc-cc5b3800de3f@app.fastmail.com> Subject: Re: [PATCH bpf-next v7 4/5] bpf: verifier: Support eliding map lookup nullness Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jan 30, 2025, at 7:41 PM, Daniel Xu wrote: > Hi Ilya, > > On Thu, Jan 30, 2025, at 2:06 AM, Ilya Leoshkevich wrote: >> On Wed, 2025-01-29 at 10:45 -0700, Daniel Xu wrote: >>> On Wed, Jan 29, 2025 at 09:49:12AM -0700, Daniel Xu wrote: >>> > Hi Ilya, >>> >=20 >>> > On Wed, Jan 29, 2025 at 03:58:54PM +0100, Ilya Leoshkevich wrote: >>> > > On Tue, 2025-01-14 at 13:28 -0700, Daniel Xu wrote: >>> > > > This commit allows progs to elide a null check on statically >>> > > > known >>> > > > map >>> > > > lookup keys. In other words, if the verifier can statically >>> > > > prove >>> > > > that >>> > > > the lookup will be in-bounds, allow the prog to drop the null >>> > > > check. >>> > > >=20 >>> > > > This is useful for two reasons: >>> > > >=20 >>> > > > 1. Large numbers of nullness checks (especially when they >>> > > > cannot >>> > > > fail) >>> > > > =C2=A0=C2=A0 unnecessarily pushes prog towards >>> > > > BPF_COMPLEXITY_LIMIT_JMP_SEQ. >>> > > > 2. It forms a tighter contract between programmer and verifier. >>> > > >=20 >>> > > > For (1), bpftrace is starting to make heavier use of percpu >>> > > > scratch >>> > > > maps. As a result, for user scripts with large number of >>> > > > unrolled >>> > > > loops, >>> > > > we are starting to hit jump complexity verification errors.=C2=A0 >>> > > > These >>> > > > percpu lookups cannot fail anyways, as we only use static key >>> > > > values. >>> > > > Eliding nullness probably results in less work for verifier as >>> > > > well. >>> > > >=20 >>> > > > For (2), percpu scratch maps are often used as a larger stack, >>> > > > as the >>> > > > currrent stack is limited to 512 bytes. In these situations, it >>> > > > is >>> > > > desirable for the programmer to express: "this lookup should >>> > > > never >>> > > > fail, >>> > > > and if it does, it means I messed up the code". By omitting the >>> > > > null >>> > > > check, the programmer can "ask" the verifier to double check >>> > > > the >>> > > > logic. >>> > > >=20 >>> > > > Tests also have to be updated in sync with these changes, as >>> > > > the >>> > > > verifier is more efficient with this change. Notable, iters.c >>> > > > tests >>> > > > had >>> > > > to be changed to use a map type that still requires null >>> > > > checks, as >>> > > > it's >>> > > > exercising verifier tracking logic w.r.t iterators. >>> > > >=20 >>> > > > Signed-off-by: Daniel Xu >>> > > > --- >>> > > > =C2=A0kernel/bpf/verifier.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 92 >>> > > > ++++++++++++++++++- >>> > > > =C2=A0tools/testing/selftests/bpf/progs/iters.c=C2=A0=C2=A0=C2= =A0=C2=A0 | 14 +-- >>> > > > =C2=A0.../selftests/bpf/progs/map_kptr_fail.c=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >>> > > > =C2=A0.../selftests/bpf/progs/verifier_map_in_map.c |=C2=A0 2 = +- >>> > > > =C2=A0.../testing/selftests/bpf/verifier/map_kptr.c |=C2=A0 2 = +- >>> > > > =C2=A05 files changed, 99 insertions(+), 13 deletions(-) >>> > >=20 >>> > > [...] >>> > >=20 >>> > > > @@ -9158,6 +9216,7 @@ static int check_func_arg(struct >>> > > > bpf_verifier_env *env, u32 arg, >>> > > > =C2=A0 enum bpf_arg_type arg_type =3D fn->arg_type[arg]; >>> > > > =C2=A0 enum bpf_reg_type type =3D reg->type; >>> > > > =C2=A0 u32 *arg_btf_id =3D NULL; >>> > > > + u32 key_size; >>> > > > =C2=A0 int err =3D 0; >>> > > > =C2=A0 >>> > > > =C2=A0 if (arg_type =3D=3D ARG_DONTCARE) >>> > > > @@ -9291,8 +9350,13 @@ static int check_func_arg(struct >>> > > > bpf_verifier_env *env, u32 arg, >>> > > > =C2=A0 verbose(env, "invalid map_ptr to >>> > > > access map- >>> > > > > key\n"); >>> > > > =C2=A0 return -EACCES; >>> > > > =C2=A0 } >>> > > > - err =3D check_helper_mem_access(env, regno, >>> > > > meta- >>> > > > > map_ptr->key_size, >>> > > > - =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 BPF_READ, false, >>> > > > NULL); >>> > > > + key_size =3D meta->map_ptr->key_size; >>> > > > + err =3D check_helper_mem_access(env, regno, >>> > > > key_size, >>> > > > BPF_READ, false, NULL); >>> > > > + if (err) >>> > > > + return err; >>> > > > + meta->const_map_key =3D >>> > > > get_constant_map_key(env, reg, >>> > > > key_size); >>> > > > + if (meta->const_map_key < 0 && meta- >>> > > > >const_map_key >>> > > > !=3D -EOPNOTSUPP) >>> > > > + return meta->const_map_key; >>> > >=20 >>> > > Mark Hartmayer reported a problem that after this commit the >>> > > verifier >>> > > started refusing to load libvirt's virCgroupV2DevicesLoadProg(), >>> > > which >>> > > contains the following snippet: >>> > >=20 >>> > > 53: (b7) r1 =3D -1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 ; R1_w=3D-1 >>> > > 54: (7b) *(u64 *)(r10 -8) =3D r1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 ; R1_w=3D-1 R10=3Dfp0 fp-8_w=3D-1 >>> > > 55: (bf) r2 =3D r10=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ; R2_w=3Dfp0 R10=3Dfp0 >>> > > 56: (07) r2 +=3D -8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 ; R2_w=3Dfp-8 >>> > > 57: (18) r1 =3D 0x9553c800=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ; R1_w=3Dmap_ptr(ks=3D8,vs=3D4) >>> > > 59: (85) call bpf_map_lookup_elem#1 >>> > >=20 >>> > > IIUC here the actual constant value is -1, which this code >>> > > confuses >>> > > with an error. >>> >=20 >>> > Thanks for reporting. I think I know what the issue is - will send >>> > a >>> > patch shortly. >>> >=20 >>> > Daniel >>> >=20 >>>=20 >>> I cribbed the source from [0] and tested before and after. I think >>> this >>> should work. Mind giving it a try? >>>=20 >>> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c >>> index 9971c03adfd5..e9176a5ce215 100644 >>> --- a/kernel/bpf/verifier.c >>> +++ b/kernel/bpf/verifier.c >>> @@ -9206,6 +9206,8 @@ static s64 get_constant_map_key(struct >>> bpf_verifier_env *env, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return reg->var_off.value; >>> =C2=A0} >>>=20 >>> +static bool can_elide_value_nullness(enum bpf_map_type type); >>> + >>> =C2=A0static int check_func_arg(struct bpf_verifier_env *env, u32 ar= g, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 struct bpf_call_arg_meta *meta, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 const struct bpf_func_proto *fn, >>> @@ -9354,9 +9356,11 @@ static int check_func_arg(struct >>> bpf_verifier_env *env, u32 arg, >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 err =3D check_helper_mem_access(env, regno, key_si= ze, >>> BPF_READ, false, NULL); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 if (err) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 re= turn err; >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 meta->const_map_key =3D get_constant_map_key(env, reg, >>> key_size); >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (meta->const_map_key < 0 && meta->const_map_key !=3D >>> -EOPNOTSUPP) >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return m= eta->const_map_key; >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (can_elide_value_nullness(meta->map_ptr- >>> >map_type)) { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 meta->co= nst_map_key =3D >>> get_constant_map_key(env, reg, key_size); >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (meta= ->const_map_key < 0 && meta- >>> >const_map_key !=3D -EOPNOTSUPP) >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return meta->const_map_key; >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 } >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 break; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case ARG_PTR_TO_MAP_VALUE: >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 if (type_may_be_null(arg_type) && >>> register_is_null(reg)) >>>=20 >>> Thanks, >>> Daniel >>>=20 >>>=20 >>> [0]: >>> https://github.com/libvirt/libvirt/blob/c1166be3475a0269f5164d87fec6= 227d6cb34b47/src/util/vircgroupv2devices.c#L66-L135 >> >> Thanks, I tried this in isolation and it fixed the issue for me. >> I talked to Mark and he will try it with his libvirt scenario. > > Thanks for testing!=20 > >> >> The code looks reasonable to me, but I have a small concern regarding >> what will happen if the BPF code uses a -EOPNOTSUPP immediate with an >> array. Unlike other immediates, IIUC this will cause check_func_arg() >> to return 0. Is there a reason to have this special? > > That's a good point. Lemme check on that. Seems like the verifier tracks the s32 spill as a u32.=20 So I couldn=E2=80=99t craft a repro for this. But it=E2=80=99ll be a good refactor to make anyways.=20