From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4F0C433ED for ; Fri, 9 Apr 2021 09:11:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2AFD61181 for ; Fri, 9 Apr 2021 09:11:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232688AbhDIJLr (ORCPT ); Fri, 9 Apr 2021 05:11:47 -0400 Received: from smtprelay0236.hostedemail.com ([216.40.44.236]:41654 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S232490AbhDIJLq (ORCPT ); Fri, 9 Apr 2021 05:11:46 -0400 Received: from omf07.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 4584F1E08; Fri, 9 Apr 2021 09:11:32 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA id DABA3315D78; Fri, 9 Apr 2021 09:11:30 +0000 (UTC) Message-ID: <92af36981fa72db5944d28c6a8d6974ec7aff3f2.camel@perches.com> Subject: Re: [PATCH][next] mlxsw: spectrum_router: remove redundant initialization of variable force From: Joe Perches To: Dan Carpenter , Colin King Cc: Jiri Pirko , Ido Schimmel , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 09 Apr 2021 02:11:29 -0700 In-Reply-To: <20210329060441.GI1717@kadam> References: <20210327223334.24655-1-colin.king@canonical.com> <20210329060441.GI1717@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DABA3315D78 X-Stat-Signature: epsbekqwcfuww9tkg9yy6qf5xhxy1zq6 X-Rspamd-Server: rspamout01 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+qOqSKZ/cujGok3IbgmEO4rhbVz7nVTK4= X-HE-Tag: 1617959490-278192 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-03-29 at 09:04 +0300, Dan Carpenter wrote: > On Sat, Mar 27, 2021 at 10:33:34PM +0000, Colin King wrote: > > From: Colin Ian King > > > > The variable force is being initialized with a value that is > > never read and it is being updated later with a new value. The > > initialization is redundant and can be removed. > > > > Addresses-Coverity: ("Unused value") > > Signed-off-by: Colin Ian King > > --- > >  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > > index 6ccaa194733b..ff240e3c29f7 100644 > > --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > > +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c > > @@ -5059,7 +5059,7 @@ mlxsw_sp_nexthop_obj_bucket_adj_update(struct mlxsw_sp *mlxsw_sp, > >  { > >   u16 bucket_index = info->nh_res_bucket->bucket_index; > >   struct netlink_ext_ack *extack = info->extack; > > - bool force = info->nh_res_bucket->force; > > + bool force; > >   char ratr_pl_new[MLXSW_REG_RATR_LEN]; > >   char ratr_pl[MLXSW_REG_RATR_LEN]; > >   u32 adj_index; > > Reverse Christmas tree. Is still terrible style.