From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE0FC14601E; Mon, 29 Jul 2024 14:57:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722265063; cv=none; b=eIV+dtmy6WAzVPXBxyFtXgIh9rVi1gPBQUiydLpCqsbGjQrhx71bpw3BFzunErEZhbktA6TBYHgs7OtzrJdgf0vgFTuJcqn+Jfs8c31bbwuugSFUuPgBSR8s7W0A/GvnjnDq/oUUzraFHZt+aFOrEO4SSZzBQf+ffIqNa1UWKq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722265063; c=relaxed/simple; bh=XVKgyTWR8+f7LtxjNU/kic+26Xoff6phqUlkCrKMH9s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=izhKa1wZAGBozYIXEir6UMoSvZkQXf4NaaHX0W/9R8GM8uusmJjuHrtMKGq/g5g98vmxzsJxPMnbj5GGFhxj2BYEH57m0ikLMuK9B5exdE8zo9arLANC94TARrR/pfbjapIpi/kkFhDG68F7lOHg0oTFc9zPKN4mSrolX54fn8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=lWIYDCVH; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="lWIYDCVH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1722265060; bh=XVKgyTWR8+f7LtxjNU/kic+26Xoff6phqUlkCrKMH9s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lWIYDCVHmQyK59Nns2eQOkyexXlSc98SxM/QPPBXdjHesZTC82SeuhdziL19hAuLZ 5QvSIY5GXX4/1TvqhoIwNjxXPLPMhR0RZLJLCt5Y3nQu/HVxh6YzZtPEUdriU8Epf9 /e96UR39cBRBYFkJAEZcXM3eCwwNUVDPRyI4STJHbGaDVZL2Yv1e6prDOhLoWWeTpk oY2PCgBg5WqRzzFr3CobHlyLRP2xV53xm6ETdfu/dhyMYm5L+dVTp4DXkQUzYFGXdG UCF5rgwkkHo8+e0yKUbo2JIWCsx+PyJCwi1nzNux/LvmRGkuoMPZeqj2yP8gKsZHUT BDSdlFWpX78Og== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id CC6F03780C11; Mon, 29 Jul 2024 14:57:38 +0000 (UTC) Message-ID: <92b18918-979d-43f6-890d-888caea08561@collabora.com> Date: Mon, 29 Jul 2024 16:57:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/5] dt-bindings: media: add mediatek ISP3.0 sensor interface To: Julien Stephan , Laurent Pinchart , Andy Hsieh , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Louis Kuo , Phi-Bang Nguyen References: <20240729-add-mtk-isp-3-0-support-v6-0-c374c9e0c672@baylibre.com> <20240729-add-mtk-isp-3-0-support-v6-1-c374c9e0c672@baylibre.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20240729-add-mtk-isp-3-0-support-v6-1-c374c9e0c672@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 29/07/24 16:48, Julien Stephan ha scritto: > From: Louis Kuo > > This adds the bindings, for the mediatek ISP3.0 SENINF module embedded in > some Mediatek SoC, such as the mt8365 > > Signed-off-by: Louis Kuo > Signed-off-by: Phi-Bang Nguyen > Signed-off-by: Laurent Pinchart > Reviewed-by: Laurent Pinchart > Signed-off-by: Julien Stephan > --- > .../bindings/media/mediatek,mt8365-seninf.yaml | 259 +++++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 266 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > new file mode 100644 > index 000000000000..8bd78ef424ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > @@ -0,0 +1,259 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (c) 2023 MediaTek, BayLibre > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/mediatek,mt8365-seninf.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Sensor Interface 3.0 > + ..snip.. > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + csi@15040000 { > + compatible = "mediatek,mt8365-seninf"; > + reg = <0 0x15040000 0 0x6000>; > + interrupts = ; > + clocks = <&camsys CLK_CAM_SENIF>, > + <&topckgen CLK_TOP_SENIF_SEL>; > + clock-names = "camsys", "top_mux"; > + > + power-domains = <&spm MT8365_POWER_DOMAIN_CAM>; > + > + phys = <&mipi_csi0 PHY_TYPE_DPHY>, <&mipi_csi1>; > + phy-names = "csi0", "csi1"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + seninf_in1: endpoint { > + clock-lanes = <2>; > + data-lanes = <1 3 0 4>; > + remote-endpoint = <&isp1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + }; > + > + port@2 { > + reg = <2>; > + }; > + > + port@3 { > + reg = <3>; > + }; I don't really get why you got all those empty ports here, as you could simply avoid adding all of the empty nodes instead. I don't have strong opinions about that anyway so, regardless of that.... Reviewed-by: AngeloGioacchino Del Regno > + > + port@4 { > + reg = <4>; > + seninf_camsv1_endpoint: endpoint { > + remote-endpoint = <&camsv1_endpoint>; > + }; > + }; > + > + port@5 { > + reg = <5>; > + seninf_camsv2_endpoint: endpoint { > + remote-endpoint = <&camsv2_endpoint>; > + }; > + }; > + > + port@6 { > + reg = <6>; > + }; > + > + port@7 { > + reg = <7>; > + }; > + > + port@8 { > + reg = <8>; > + }; > + > + port@9 { > + reg = <9>; > + }; > + }; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d6c90161c7bf..6bd7df1c3e08 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14158,6 +14158,13 @@ M: Sean Wang > S: Maintained > F: drivers/char/hw_random/mtk-rng.c > > +MEDIATEK ISP3.0 DRIVER > +M: Laurent Pinchart > +M: Julien Stephan > +M: Andy Hsieh > +S: Supported > +F: Documentation/devicetree/bindings/media/mediatek,mt8365-seninf.yaml > + > MEDIATEK SMI DRIVER > M: Yong Wu > L: linux-mediatek@lists.infradead.org (moderated for non-subscribers) >