From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABEFBC43334 for ; Sun, 17 Jul 2022 13:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231938AbiGQNC1 (ORCPT ); Sun, 17 Jul 2022 09:02:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbiGQNCY (ORCPT ); Sun, 17 Jul 2022 09:02:24 -0400 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32AF71408B for ; Sun, 17 Jul 2022 06:02:22 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R471e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VJY78e._1658062934; Received: from 30.63.244.244(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VJY78e._1658062934) by smtp.aliyun-inc.com; Sun, 17 Jul 2022 21:02:17 +0800 Message-ID: <92b6f01c-52ca-92a8-20ea-450e23f4a10e@linux.alibaba.com> Date: Sun, 17 Jul 2022 21:02:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Shuai Xue Subject: Re: [RESEND PATCH v2 2/3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC To: Randy Dunlap , Jonathan.Cameron@Huawei.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, will@kernel.org, mark.rutland@arm.com Cc: baolin.wang@linux.alibaba.com, yaohongbo@linux.alibaba.com, nengchen@linux.alibaba.com, zhuo.song@linux.alibaba.com References: <20220617111825.92911-1-xueshuai@linux.alibaba.com> <20220715151310.90091-3-xueshuai@linux.alibaba.com> <9da48b8e-adbb-9223-5687-549c66526c47@infradead.org> Content-Language: en-US In-Reply-To: <9da48b8e-adbb-9223-5687-549c66526c47@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Randy, Thank you for your quick reply. 在 2022/7/16 AM3:05, Randy Dunlap 写道: > Hi-- > > On 7/15/22 08:13, Shuai Xue wrote: >> Add the DDR Sub-System Driveway Performance Monitoring Unit (PMU) driver >> support for Alibaba T-Head Yitian 710 SoC chip. Yitian supports DDR5/4 >> DRAM and targets cloud computing and HPC. >> >> Each PMU is registered as a device in /sys/bus/event_source/devices, and >> users can select event to monitor in each sub-channel, independently. For >> example, ali_drw_21000 and ali_drw_21080 are two PMU devices for two >> sub-channels of the same channel in die 0. And the PMU device of die 1 is >> prefixed with ali_drw_400XXXXX, e.g. ali_drw_40021000. >> >> Due to hardware limitation, one of DDRSS Driveway PMU overflow interrupt >> shares the same irq number with MPAM ERR_IRQ. To register DDRSS PMU and >> MPAM drivers successfully, add IRQF_SHARED flag. >> >> Signed-off-by: Shuai Xue >> Co-developed-by: Hongbo Yao >> Signed-off-by: Hongbo Yao >> Co-developed-by: Neng Chen >> Signed-off-by: Neng Chen >> --- >> drivers/perf/Kconfig | 8 + >> drivers/perf/Makefile | 1 + >> drivers/perf/alibaba_uncore_drw_pmu.c | 793 ++++++++++++++++++++++++++ >> 3 files changed, 802 insertions(+) >> create mode 100644 drivers/perf/alibaba_uncore_drw_pmu.c >> >> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig >> index 1e2d69453771..dfafba4cb066 100644 >> --- a/drivers/perf/Kconfig >> +++ b/drivers/perf/Kconfig >> @@ -183,6 +183,14 @@ config APPLE_M1_CPU_PMU >> Provides support for the non-architectural CPU PMUs present on >> the Apple M1 SoCs and derivatives. >> >> +config ALIBABA_UNCORE_DRW_PMU >> + tristate "Alibaba T-Head Yitian 710 DDR Sub-system Driveway PMU driver" >> + depends on (ARM64 && ACPI) >> + default m > > Why should this driver be automatically built? > I.e., why is the "default m" here at all? Sorry, we automatically build this driver internally. I forgot to delete it. I will delete "default m" in next version. Best regards, Shuai > > Thanks. > >> + help >> + Support for Driveway PMU events monitoring on Yitian 710 DDR >> + Sub-system. > >