From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: marijn.suijten@somainline.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] Revert "dt-bindings: power: rpmpd: Add SM4250 support"
Date: Fri, 13 Jan 2023 17:36:20 +0100 [thread overview]
Message-ID: <92b7955c-bcac-20ad-ccde-3eef17f092b6@linaro.org> (raw)
In-Reply-To: <e1782f36-5a28-1fe4-47d5-b3bc00317b57@linaro.org>
On 13.01.2023 17:33, Krzysztof Kozlowski wrote:
> On 13/01/2023 16:22, Konrad Dybcio wrote:
>> SM4250 and SM6115 use a shared device tree and the RPMPDs are
>> identical. There's no need for a separate entry, so remove it.
>>
>> This reverts commit 45ac44ed10e58cf9b510e6552317ed7d2602346f.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 -
>> include/dt-bindings/power/qcom-rpmpd.h | 10 ----------
>> 2 files changed, 11 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> index 633d49884019..5bb9f59d196f 100644
>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
>> @@ -39,7 +39,6 @@ properties:
>> - qcom,sdm845-rpmhpd
>> - qcom,sdx55-rpmhpd
>> - qcom,sdx65-rpmhpd
>> - - qcom,sm4250-rpmpd
>
> Yet, dedicated compatibles are usually recommended. Maybe this should be
> used with fallback:
> "qcom,sm4250-rpmpd", "qcom,sm6115-rpmpd"
The compatible has never been used so far and it's really the
same situation as SDM630/660 AFAIK, so I don't think it makes
much sense.
Konrad
> ?
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-01-13 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 15:22 [PATCH 1/2] Revert "soc: qcom: " Konrad Dybcio
2023-01-13 15:22 ` [PATCH 2/2] Revert "dt-bindings: power: " Konrad Dybcio
2023-01-13 16:33 ` Krzysztof Kozlowski
2023-01-13 16:36 ` Konrad Dybcio [this message]
2023-01-13 16:49 ` Krzysztof Kozlowski
2023-01-19 4:53 ` (subset) [PATCH 1/2] Revert "soc: qcom: " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92b7955c-bcac-20ad-ccde-3eef17f092b6@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®