From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A92376BDE; Fri, 12 Jun 2026 08:35:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.18 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781253347; cv=fail; b=uehnpc7YcdvSrvxXkyXcZ9rIuwCabf/O3O/gmyslfPVi8l9TEUyPB/Iw8Dl8PV0ETa+JybcUMDHsDIJvssyHLjmupO6Sz3merG1vF0q0kJCLnrfGxdOdse6JkuvGNmPLTMfvssoR+0SRPmv2Kupd6FGIzvsIBBMX2tvMThMe+1c= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781253347; c=relaxed/simple; bh=YQzySe95WLxv/4IyCGQBv0jDXo4EanrMKupj1UKHyNs=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=oiDoK2vrkehEbFLsJZ4E0zVifWPC28Oja2f1XYVJj5agvOt/scBCChvqu+WktDcA0c98/L3aVNphqSC8G8rtMaXvdbk+SjERq7vNQ1brMtLEIEaquMnNDMenRTHxMpZgcGK7NoWyGATbQnw82mmQ3pAtCJ2uCS/JHYZUUAB1ZJM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SZ9AHIMC; arc=fail smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SZ9AHIMC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781253345; x=1812789345; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YQzySe95WLxv/4IyCGQBv0jDXo4EanrMKupj1UKHyNs=; b=SZ9AHIMCN8EuM2SbB9QUO4sPKPc0Aks03VtgFUxg5twuxz6IZbTHpUYM iPb/DbPZw7g262cc7LMCFXjyeXy/+PWow13W8hRJQd41PPq6w6Ht2oif6 cInRNG6ZEW2pOwWqHm2lE7D4QJ0kLcl56bg+trEzHocPHHdgymx4jMNgu b3muPRsC65O5/TdV/EvLNhG6cIJczlelUWf16ZVBqflDE5MXE2tH+wDD9 jDhcSWKYW4BlGsWRSsgT6JYr5X1bNebNDe1VBKh3O0r6MxexaIWS7dx4B rwHAfeK5meox5L0CLaI8I+RVahZGigYJKcbjdoJfNAkiMh2Ry04AnEvzi Q==; X-CSE-ConnectionGUID: D9w0LCRQTKy4bc5sKEYPUA== X-CSE-MsgGUID: SDwXrjFzRnGgkS2YNSVbNA== X-IronPort-AV: E=McAfee;i="6800,10657,11813"; a="82144430" X-IronPort-AV: E=Sophos;i="6.24,200,1774335600"; d="scan'208";a="82144430" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2026 01:35:45 -0700 X-CSE-ConnectionGUID: wI5ExCknSySSep8vGRDNpQ== X-CSE-MsgGUID: hN6qWu4tTJWBgnJNkWV0Gw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,200,1774335600"; d="scan'208";a="250693485" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2026 01:35:45 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 12 Jun 2026 01:35:44 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Fri, 12 Jun 2026 01:35:44 -0700 Received: from BL2PR02CU003.outbound.protection.outlook.com (52.101.52.14) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 12 Jun 2026 01:35:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LWBGUGJnHgRf2XxE3RU978vHYPdbtTuhOsz0bjaGBSywbu/eCNaZxroF4iLC63FnO5xWbrwt4QJ2wuy+bhdFBhDqUFEhTgG/cMHJ+sATHzcz7dqB7ZKYIv5atFiEyt7lLtST2+LPIXsL/YTE8elYWc2UlSNLKRA1ciEW4xA76zlbT/HfzV4Pwjw0UpVAxJNM1bHXThzFTD8iqamF9O8j22hTqDeUDYDT0ckAdOm0tLQxhW6ENNxWmXYwxHcXX9BYyJp2+tvVArEL2qBScjm9Zr0ohRE0DOqUnl1fcNoB69DJtjukP/aBfUfxA15Cbwf7iLAp7h/ngiW+p/tuvso+RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RbldQrA8KlqL0I8BhhY4p6VYEPrQqw+jwRH87t8ppvk=; b=OTI1hAd+WqyuepkfYmIs4sOw1jECSx8YRDTVY7wReODxA6cQCAJY4TrS/juqP1hGi04UA+EowtPLQ3m+GUtulNRc7GAhvIoq3o+iTPcsLFULqgdfg2XRCw4kTYx2qS5LvClbw21deBk0qO6iZQsrXoScTlBnym8iz3UOYjM9AmQ0WYcYB3orCSYjm66a4WW/9fsbuV23+G9Ln0Qo7Irrj73JsgA0MvSa2+YD6yaxkqC3fO/6n9ESXC4g8kIDsM05l0Hh0H9hYy+ngT09VuDZGQ3yFpt7ytlTH2JeCRPOCOMUBnf9joAY/Fm7ngA6PTabycRmDtTpKfnA3ff57tAVRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB6978.namprd11.prod.outlook.com (2603:10b6:510:206::12) by IA3PR11MB9013.namprd11.prod.outlook.com (2603:10b6:208:57c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.113.14; Fri, 12 Jun 2026 08:35:41 +0000 Received: from PH7PR11MB6978.namprd11.prod.outlook.com ([fe80::f60e:1044:67d7:d8fc]) by PH7PR11MB6978.namprd11.prod.outlook.com ([fe80::f60e:1044:67d7:d8fc%5]) with mapi id 15.21.0092.011; Fri, 12 Jun 2026 08:35:41 +0000 Message-ID: <92be4fb7-4605-4359-907a-eb17729fb588@intel.com> Date: Fri, 12 Jun 2026 10:35:35 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/20] ASoC: Intel: catpt: ipc: Use guard() for mutex & spin locks To: Bui Duc Phuc CC: Jaroslav Kysela , Takashi Iwai , "Peter Ujfalusi" , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , , , Mark Brown , "Liam Girdwood" References: <20260611115901.80438-1-phucduc.bui@gmail.com> <20260611115901.80438-2-phucduc.bui@gmail.com> Content-Language: en-US From: Cezary Rojewski In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: WA1PEPF00005B8E.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d8::62f) To PH7PR11MB6978.namprd11.prod.outlook.com (2603:10b6:510:206::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB6978:EE_|IA3PR11MB9013:EE_ X-MS-Office365-Filtering-Correlation-Id: 54a51a2d-1b2b-4d02-75bb-08dec85d9609 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|23010399003|18002099003|22082099003|56012099006|4143699003|11063799006; X-Microsoft-Antispam-Message-Info: l8X2uxD7jEzk0i6bie7JIEMHt63Z9ATXZbm6aNgOPwNdYLe3sMlPtQKmWpJUoXVGfIBvfRmQBniSqNX2OsLy1ROYw7iMx9MRKZBjcSZXApZ9w/Q3mzVlWg632AScXue8nC7ohP8mCkF+nm/HVLCvzUDf7IM3k7TKdbnXjA29tGMKFNwshfJqX2KiPhZqjKKtlIuir2MezicJYCNGBrWno/+L0UqNSfdWO4S2RZmD5izuNxw7j++JRqkQHKVx4naK26NCafQon264+E0DaFDqSNUU/zhkLAsnxZ5EQI0jspEMWUUyLGitsXvaaYVU47pW8mqiwU5eB856im5ryWKtcuBRx+qoHGKDc1oTB5YIjTMFuGzFg3AwiCqyaseLohPmxVK8L5sUHiKKZXRzn17GQOiFL7s7YxiqC3qNlLrYjfJT6KJS6LE36Y1/upxj0bpAKPMQtqajPrnXi10zwvPaeRnkCNSsfLb+HCmcwvKzdbCrpGaCfpST1G7n3s9tNiw4sz8jWfxpQN0a3lTy/Vemgj6Pj4OCU3JF/yDpOouavsT1URk1DaSGC/20g3pWy9vRcMPk0tVc3vtC+O895vZf18vOqr/TGHwkEFzXuf0NDC2QSKUW3srcjMDwb1T4O4XhQk7lvOsBZbE7/1zkCffDdmAg/gfVrhZvJiJvXCYQgrWQtXz2P89k61Y245MFhF6+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6978.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(23010399003)(18002099003)(22082099003)(56012099006)(4143699003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWhkTTVsemIzVld5QWFkcGRFcVJ5TitOUmszTndLMTlEQnNydk50TkJ5YXZq?= =?utf-8?B?MVRDek9RcjR5STcvblNPdm00RUVCOVFJc1F0Q1JIOGF4bG51QnJUc3I1WUdH?= =?utf-8?B?ZGo5TlZhUitIajdoOERRTXl2VTRvcWZmYkRqa29xRTI5ZGZRaklnVEFISE5H?= =?utf-8?B?QitqZEQwL1U3SEVteEl5bkdEbnQzNWpMSkpkOS84UkxIN0lXMlNBWWtOQ3VD?= =?utf-8?B?RHdvcnRIdVBqY3FjTkV1TElEQ3VKTW9YbytJMHhmN1NQRkNoUUp5dHZ3dTll?= =?utf-8?B?cjRySU5XN01uenJUWUp0NXU4OUNQeXBsZmNHZVord0JrRnBJdlY5Zk1YNzVa?= =?utf-8?B?ME5MWFo0czQ4bU9vSVNlelJTcW1JVnI5L3dkZ3ZIRysvNVZnTnRiQTQxd01m?= =?utf-8?B?VU5tZzNLQUVjRkxibHhER3dRV2hDR2pqbit6SWRPdkYraDRRdW1oNWhMT3Rn?= =?utf-8?B?NFFpeEdwV202dUVGRnQwc2hyb3krcDFCeVlCZitaNEVOWmxRdzRFNmtiZmhH?= =?utf-8?B?S09oRk52Wk83YmNmZVNEMlJsYUFRbkNaQ1h0Z0t4aU12djlhN2duQlJEaTQ4?= =?utf-8?B?QkVsUGtrZnBDN2JScFBobU1iTm5JS0F5djgvbUZ5b3VpbDZ6bUV6elprOXpv?= =?utf-8?B?OWlkb3gvS01YT0NNQWo5VExDcUlIL2VjNFNZcUhxZ3NDTHZOSGJ1Tm04OURY?= =?utf-8?B?aHI4ZCs1ZGpSMjZMaWxnWE5ZWjVETlpHdC9wMWlmK1Eyc3p4TktzV3JhNVpW?= =?utf-8?B?VDZrdXp1N1I5ejBOR1YvT1BPVXdwUXVLTWdxOVdKSzU1RHg3dEh5MDhLWnpX?= =?utf-8?B?cThsemxoVDZQKzJ6NlR4eHhCbjBESHFiWUREaHhBZ1hOTk1XdFY3cnRQSG1h?= =?utf-8?B?NVVQaElnRERHb3NQRWt3c2NobjBjYkZqK2ZjWlUwbjFieVFENUFZdG5CbWox?= =?utf-8?B?T0JNcjROR3AxVG9mUCttbnBMUmU5a201UElOeUtwMTQ4R1lmWlV6ZHJRQ1F6?= =?utf-8?B?VVFHR1A2L1FEczRDRER0bmwrbmVlSXl5Z2NDOEVlc2dIZHp2QXV2UlgyQWta?= =?utf-8?B?Rnh5b0lFK254OVprVExkSDgrOG1aN3N6Nk1sL0pKejVNaXgzNTh3NXZtR1Jt?= =?utf-8?B?REJuYzZLVU9IR1lSazdTemlOeVlLKzNaY3A3TCsvb2xYL21uZ1YwSDdUUVJS?= =?utf-8?B?L0NvWmowd0lRdFpaN1lkakQ2YmkxSGNmbkxiZlYvdGxsMFVwbkNyNk9EYk1v?= =?utf-8?B?WTVTZlQyK1I5aDNYL1d3dEhDV28zOG11MzIwa3o4ZFEzMzNrRU1xLzljVGdT?= =?utf-8?B?RVRlSmw3ckRtUHVmRlFmdldlZ1R6eThXZzR0S1plbGdEZzBEYXg4WHlRVUdI?= =?utf-8?B?cXEwa0xEellROElIOFNIK0RXRkIzR2lKNjJ0eGtwOGpBNlR0ZDVsNXZsbjJ1?= =?utf-8?B?NVhhVmlaN0JCS0RCMTEwa25sSjNEMENYTFcrcjNCNndIMXduWGNlbEJqMXRN?= =?utf-8?B?L0hYR2pRYTZTQnlOV2pyaDM3QUNZbWdOS3pRMjZmU3NlOWN4dTNBWjc1VjJI?= =?utf-8?B?TmtNRXdZelo5VCtKTDlrZU9DYjJJQWtBRlRHcVBsUURRZGplWEpUbmQzUEs4?= =?utf-8?B?My9yTTdxTldJdzJQTlZhcGZvQkFHU0ErSTRpQitkb0JQYmNFbEZpOWd6WjlF?= =?utf-8?B?UXcwYUlOZXc3Tk9MQjVkdXJNK1NEYjdLcGh6QTZVdzdYM1dvbkh5OWRlejlJ?= =?utf-8?B?VnJZajMxakFlaWtHMW5ZSWUwZmRBNGphQjk4ZE1TdHkrVDhIbDdtZm1Tb0Nx?= =?utf-8?B?UXBWeFRCc09ZQ3BEUVBRRnRKM2M2OENmdkR5WTdrRm5GOXZpUUVHNzFtRWNU?= =?utf-8?B?cnhRQXUvUmVnWElpT1JGeHBxU0xRM3VwOXNGbGZQaW1XRnZZeHhTMHg1TURy?= =?utf-8?B?NTU0UmZxR1RwL1FSRTV5UDQvNldnWkI2YlZTa2NESFBmR2F5MVFMZCtQeWJj?= =?utf-8?B?dHdtTUpoSXdqSmtVazUzQmljT2tPQnkvOGJVWDhaMzk2QXFmMm5ackNWNXBQ?= =?utf-8?B?aEdEamJvdUdZWE55TERRcDljd2ZTM0JlNE1YZFBtSG1GaUl0ekhLTkpjVC9R?= =?utf-8?B?ckJaWXJVRGFROG0yT1VDTkhWNjR5bzVESnNvb2ExdjhuS2ZNZ2hFaEVSREhU?= =?utf-8?B?cnZTWmlUeUlxcUxsTnZ2U1E0Mm82d2l3a0I5UnVNT0VWQWtqRll6L0htT1A3?= =?utf-8?B?OUxacVh1UUhoMUhlcnZjZUFxL1ZqcFVYQzZYQUVsaWVBUzYzQ3Q5S0g3UnUv?= =?utf-8?B?RjhpeVV3OU9PT1VCekphWHVacGJkOEU1am9kL1NTNzNrUjFFYmdIZz09?= X-Exchange-RoutingPolicyChecked: s1/heSUP2+gTxYVR6VypZJ8PVQomZncKrZ74EtiknlUVUp2kRT5ki400TWQUpW0g8uWmyQn53hlGsv1rvCDMJptsfw+QHGEsRVd8Hl/3GfNBuhGhoIc9fPKGGo0tzWnl8g8Q3CSrP6nixhySfpMxm89aEqiyOqD3lBs8xmmNL5VxYfDk9oA0RPZVATVxyWHnzDZOEcoIo4mug6rXik7hVAWvxT1sqYXVNMKxAGW4JI/5XEuKbJOZdIFt6lq19TeKpBKxZmes8aXzDfHP3T04f7o0k/6MEbnfNzBjTCSY6R5G2ErnkKL2Q6NWeKaWEfuBa5kDaFNhZ+hp7jh+CwMcxg== X-MS-Exchange-CrossTenant-Network-Message-Id: 54a51a2d-1b2b-4d02-75bb-08dec85d9609 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6978.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2026 08:35:41.6292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A90nz3+Vm0cDPez22pLS5pfOjkd2mwT0KB+kkKAGv5lCS16lsNZmlleU44MA+FjjhMIgM4AGrE51sBiMGMlPrXtOJv2W25Y36nCYw6CQi9A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR11MB9013 X-OriginatorOrg: intel.com On 6/12/2026 6:05 AM, Bui Duc Phuc wrote: > Hi, > >> The catpt_dsp_send_msg_timeout is already part of Mark's tree [1]. At >> the same time I'm against using scoped_guard() for >> catpt_dsp_do_send_msg(). The existing code is small and transparent, >> there is no need to tabify it. >> > >>> @@ -97,10 +96,10 @@ static int catpt_dsp_do_send_msg(struct catpt_dev *cdev, >>> (reply && reply->size > ipc->config.outbox_size)) >>> return -EINVAL; >>> >>> - spin_lock_irqsave(&ipc->lock, flags); >>> - catpt_ipc_msg_init(ipc, reply); >>> - catpt_dsp_send_tx(cdev, &request); >>> - spin_unlock_irqrestore(&ipc->lock, flags); >>> + scoped_guard(spinlock_irqsave, &ipc->lock) { >>> + catpt_ipc_msg_init(ipc, reply); >>> + catpt_dsp_send_tx(cdev, &request); >>> + } >>> >>> ret = catpt_wait_msg_completion(cdev, timeout); > > So I understand that, for this conversion effort, you would prefer a > case-by-case approach rather than converting everything to > guard()/scoped_guard() purely for consistency. Is that correct? Yeah. As stated previously, I see no reason to update the catpt-driver, simply drop 1/20 and 2/20. Let's focus on the avs- and the atom- drivers.