From: Oliver Neukum <oneukum@suse.com>
To: Hector Martin <marcan@marcan.st>,
Jacky Chou <jackychou@asix.com.tw>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: usb: ax88179_178a: Bind only to vendor-specific interface
Date: Tue, 21 Jun 2022 14:33:57 +0200 [thread overview]
Message-ID: <92c163f6-0527-e8dd-8e4a-e721594630a5@suse.com> (raw)
In-Reply-To: <20220621102150.202475-1-marcan@marcan.st>
On 21.06.22 12:21, Hector Martin wrote:
> The Anker PowerExpand USB-C to Gigabit Ethernet adapter uses this
> chipset, but exposes CDC Ethernet configurations as well as the
> vendor specific one. This driver ends up binding first to both CDC
> interfaces, tries to instantiate two Ethernet interfaces talking to
> the same device, and the result is a nice fireworks show.
Could you explicitly state here that the root cause is that the
driver for the vendor specific mode binds to the device based only
on vendor:product ID, thus taking interfaces that only the
class driver can handle properly?
This log reads like the basic issue is that it binds to two
interfaces.
The patch itself is fine.
Regards
Oliver
prev parent reply other threads:[~2022-06-21 12:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 10:21 Hector Martin
2022-06-21 12:33 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c163f6-0527-e8dd-8e4a-e721594630a5@suse.com \
--to=oneukum@suse.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jackychou@asix.com.tw \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®