From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDECC41604 for ; Tue, 6 Oct 2020 04:55:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FA2E208C3 for ; Tue, 6 Oct 2020 04:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbgJFEzH (ORCPT ); Tue, 6 Oct 2020 00:55:07 -0400 Received: from smtprelay0242.hostedemail.com ([216.40.44.242]:60730 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725912AbgJFEzH (ORCPT ); Tue, 6 Oct 2020 00:55:07 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id E8DE618025614; Tue, 6 Oct 2020 04:55:05 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: smell79_1c14f78271c4 X-Filterd-Recvd-Size: 2318 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Tue, 6 Oct 2020 04:55:04 +0000 (UTC) Message-ID: <92c4f9bd1d43b80a424a52131fcbc6a1a416de64.camel@perches.com> Subject: Re: [RFC PATCH] DRM: amd: powerplay: don't undef pr_warn() {causes ARC build errors} From: Joe Perches To: Randy Dunlap , LKML , dri-devel Cc: kernel test robot , Evan Quan , "amd-gfx@lists.freedesktop.org" , Alex Deucher , Vineet Gupta , "linux-snps-arc@lists.infradead.org" Date: Mon, 05 Oct 2020 21:55:03 -0700 In-Reply-To: <9c86375d-34a9-6584-0069-452b193076d6@infradead.org> References: <9c86375d-34a9-6584-0069-452b193076d6@infradead.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-10-05 at 21:50 -0700, Randy Dunlap wrote: > From: Randy Dunlap > > arch/arc/ implements BUG_ON() with BUG(). ARC has its own BUG() > function and that function uses pr_warn() as part of its implementation. > > Several (8) files in amd/powerplay/ #undef various pr_xyz() functions so > that they won't be used by these drivers, since dev_() functions are > preferred here and the #undefs make the pr_() functions unavailable. [] > --- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > +++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/navi10_ppt.c > @@ -52,7 +52,7 @@ > * They are more MGPU friendly. > */ > #undef pr_err > -#undef pr_warn > +//#undef pr_warn > #undef pr_info > #undef pr_debug > > --- lnx-59-rc7.orig/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c > +++ lnx-59-rc7/drivers/gpu/drm/amd/powerplay/sienna_cichlid_ppt.c > @@ -54,7 +54,7 @@ > * They are more MGPU friendly. > */ > #undef pr_err > -#undef pr_warn > +//#undef pr_warn > #undef pr_info > #undef pr_debug These are bad ideas as all of these pr_ entries may become functions in a near-term future.