mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: devel@driverdev.osuosl.org, lustre-devel@lists.lustre.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Ben Evans <bevans@cray.com>, Bobi Jam <bobijam.xu@intel.com>,
	Emoly Liu <emoly.liu@intel.com>, Fan Yong <fan.yong@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Gregoire Pichon <gregoire.pichon@bull.net>,
	Henri Doreau <henri.doreau@cea.fr>,
	James Simmons <jsimmons@infradead.org>,
	Jinshan Xiong <jinshan.xiong@intel.com>,
	"John L. Hammond" <john.hammond@intel.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Lai Siyao <lai.siyao@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Sebastien Buisson <sbuisson@ddn.com>,
	Stephen Champion <schamp@sgi.com>, wang di <di.wang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/5] staging/lustre/obdclass: Combine two seq_printf() calls into one call in lprocfs_rd_state()
Date: Sun, 1 Jan 2017 17:38:21 +0100	[thread overview]
Message-ID: <92ca443f-4791-f291-e2ea-5e67e3a846ac@users.sourceforge.net> (raw)
In-Reply-To: <45ae8939-a775-865b-ade0-9e38a7ff2b5d@users.sourceforge.net>

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 1 Jan 2017 16:26:36 +0100

Some data were printed into a sequence by two separate function calls.
Print the same data by a single function call instead.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index 3f6fcab5a1fc..a167cbe8a50e 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -853,10 +853,8 @@ int lprocfs_rd_state(struct seq_file *m, void *data)
 		return rc;
 
 	imp = obd->u.cli.cl_import;
-
-	seq_printf(m, "current_state: %s\n",
+	seq_printf(m, "current_state: %s\nstate_history:\n",
 		   ptlrpc_import_state_name(imp->imp_state));
-	seq_printf(m, "state_history:\n");
 	k = imp->imp_state_hist_idx;
 	for (j = 0; j < IMP_STATE_HIST_LEN; j++) {
 		struct import_state_hist *ish =
-- 
2.11.0

  parent reply	other threads:[~2017-01-01 16:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-01 16:30 [PATCH 0/5] staging-Lustre: Fine-tuning for some function implementations SF Markus Elfring
2017-01-01 16:33 ` [PATCH 1/5] staging/lustre/llite: Use seq_puts() in three functions SF Markus Elfring
2017-01-01 16:35 ` [PATCH 2/5] staging/lustre/mgc: Combine two seq_printf() calls into one call in lprocfs_mgc_rd_ir_state() SF Markus Elfring
2017-01-13  6:58   ` Oleg Drokin
2017-01-13  7:41     ` Greg Kroah-Hartman
2017-01-01 16:37 ` [PATCH 3/5] staging/lustre/obdclass: Use seq_putc() in four functions SF Markus Elfring
2017-01-01 16:38 ` SF Markus Elfring [this message]
2017-01-13  6:59   ` [PATCH 4/5] staging/lustre/obdclass: Combine two seq_printf() calls into one call in lprocfs_rd_state() Oleg Drokin
2017-01-01 16:40 ` [PATCH 5/5] staging/lustre/obdclass: Use seq_puts() in three functions SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92ca443f-4791-f291-e2ea-5e67e3a846ac@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=andreas.dilger@intel.com \
    --cc=bevans@cray.com \
    --cc=bobijam.xu@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=di.wang@intel.com \
    --cc=emoly.liu@intel.com \
    --cc=fan.yong@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gregoire.pichon@bull.net \
    --cc=henri.doreau@cea.fr \
    --cc=jinshan.xiong@intel.com \
    --cc=john.hammond@intel.com \
    --cc=jsimmons@infradead.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=lai.siyao@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    --cc=sbuisson@ddn.com \
    --cc=schamp@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome