From: Andrew Lunn <andrew@lunn.ch>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Michael Grzeschik <mgr@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: arcnet: com20020-pci: clean up failed channels
Date: Tue, 15 Sep 2026 18:08:40 +0200 [thread overview]
Message-ID: <92cbc37a-833e-4369-b5ff-4199dbefce6e@lunn.ch> (raw)
In-Reply-To: <20260915013946.73963-1-mhun512@gmail.com>
On Mon, Sep 14, 2026 at 09:39:45PM -0400, Myeonghun Pak wrote:
> After com20020_found() registers a netdev and requests its IRQ, seven
> allocation or LED-registration failure paths free the netdev without
> unregistering it or freeing the IRQ. The unfinished channel is not yet
> on list_dev, so the common remove path cannot clean it up.
>
> Route those failures through unregister_netdev() and free_irq() before
> free_arcdev(). Keep failures before successful com20020_found() on the
> existing free-only path.
>
> This issue was identified during our ongoing static-analysis research
> while reviewing kernel code.
>
> Fixes: 6b17a597fc2f ("arcnet: restoring support for multiple Sohard Arcnet cards")
I think this tag is wrong. Please check it.
Andrew
prev parent reply other threads:[~2026-09-15 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 1:39 Myeonghun Pak
2026-09-15 1:39 ` [PATCH net 2/2] net: arcnet: com20020-pci: balance PCI enable on cleanup Myeonghun Pak
2026-09-15 16:08 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92cbc37a-833e-4369-b5ff-4199dbefce6e@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgr@kernel.org \
--cc=mhun512@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®