From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D637523AE87 for ; Wed, 25 Mar 2026 20:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774468925; cv=none; b=p6x+QHMlR+lmO+kP8UXbuFtLiZK1QKPDa97v6Kvr5EkaHI1WVm6nSOG5U7gaRHVaWGvMMLHw+/XMYDfUSEFaVsdWB02198Eom3VQgX8Dx6T/ICEC/IzjkFsW1gpZ+mVbUqYcF3yKsQvlOqZJkW3mTVVtFvLg5HDpGE+Yh8mwxZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774468925; c=relaxed/simple; bh=+OqoUI19RCnwsXWZDsm2j1Cqhad6FqDcZ1vJXoAX90E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jZBzDNt88E2qMT34SXmU5rv4KbMSYk3a4tvlSAaRnQLupPGP+iL35HOzTZimyDmoHyaVdBCpw3tXpoYsChhAejHjpNyIcMv3SNtRvqmBz+Btx5nGeqGEoLm/awZuZECLCJN1z9JYADd8FeFGBSqp3lvlURaBGICpNsNIOamtUO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KNzJpixB; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KNzJpixB" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-1273349c56bso345223c88.0 for ; Wed, 25 Mar 2026 13:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774468923; x=1775073723; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=e3CZCnTqRxUjMNPGN8nVHqOW8jYHy07xQcrdoN086uw=; b=KNzJpixBRB7CM4y1g0h2C4JkhEyOb0jH0MWX2ssdwKGoT6P3g9sX0KNkhkUUtN6F3y 4gQB8rysXbKwlPhC/zmJLOf2239BpPIlY942e8zBTETLyPv7cq2WAYCQXxoMYOwLF8zR OCBj5c2Cr3GpfY9Z+ecFCq16esI5RpakqD/Tcyh7lYvsVPsEiCBCb6H9x462S5QYG9nD QeZWRuv04bMqyojZ3YtdVH1e3Qp5ld3mWBP96SsW62Uob7NXuAVHUAO0GcMQKKzYXs1W g2dadA7k6BEHZ1g/bG5MsqD4cYzxOznBfM5ijTHy0M6f4B6PJwOyNQNucFVqKeWm6zhg EOGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774468923; x=1775073723; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e3CZCnTqRxUjMNPGN8nVHqOW8jYHy07xQcrdoN086uw=; b=IXdPkhv/pGTFMFgAHAr4nXbxO3OUQhn2bySWeDwuqhLVJqD1mf55AIHOqa8tFEDehH 6VQIvU6seo3G32sK+9AHX5Pm+RPqyp8uRtps82onWXb4cgXUMr2jYvpFaw+NZTOhz3T5 dn4VGjOoDQnsIj1V8fzb6HLagfmHuDzdQj8K321o2TCSGTaSqihz2wiukCY0QK9HlvCF aCKrgBy6y6gJAkYxNfQ8Hzo+gX/iBs7uD8XSCgTuTHuwgluelyF6aO3jERq6tApNhpyj nsyZuh0IIzcjZNqSSvWpaNTKlhG4hJcaF4tYZy6I4kC2iV4mJ8NfoGMbujjcHEVycc5d NZ9Q== X-Forwarded-Encrypted: i=1; AJvYcCWHvNMc/udsbyI/wgXPV6hE/LBIQkFUqgne/LrXUMau8fVMU4aeikaYp0jLmlAsR2FqZ8f1EIhJ62/HtLA=@vger.kernel.org X-Gm-Message-State: AOJu0YweUFtGzTIJyImJE+LWWQoXzjekLATlzbx1NO2N2v0p7Dl5HWhw 0+ET34Ccd5cw0uWt1xLov3OzJDxXI++oWB72q4/PPhIvZPc5q3Vms0gK X-Gm-Gg: ATEYQzzXgpvs+jO8y98vscp4OIPkVv8hWxZ+nIj8zwsrdNKbBymDlrCvjSDoKudw5Me N8H3usu4Utmy7pwk++KmXRyp9l9EwbsIWM0uM1x9pm4+F/K0PoLyJInA1SnxKNCCnNzsIEBH7/R +rAsmwrVbH8plrasnwIYbtq4ss3AUXJrT3OF1ARVvRSa2hu4npTfZSieBCj8xaTER2KqjFuBDrC iyvLOni+30Ul1EMbiZfY9eGZa42UeoLV8fEpuL8M9rRQT5iWzba7TP8S/8uNxiJlLWHvMKB8Jai qXjE0upw49hMSEEKsbiUEApI3bL2vSHa6yFEHKbMMDfqUd59l+t6hfJb/j3dG/9vqqTYAYjW0TV YMNgUwrFwN9HB7RKAo6/Kk3Wcrqdj1PhYZk4fqSCCRbmQAlKNBlmH3Ytf8EwEaeyqzwNywfL72Y NUNqEuSV4clygL+FrDR3vbmfJt9QC2rpsShq5AnOpKFFvr3kdcMsumEGxIktZ8a8k32usaOp4I X-Received: by 2002:a05:7022:50e:b0:11b:9386:8265 with SMTP id a92af1059eb24-12a96f2a003mr2352775c88.42.1774468922845; Wed, 25 Mar 2026 13:02:02 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12aa782ca4fsm895971c88.14.2026.03.25.13.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 13:02:02 -0700 (PDT) Sender: Guenter Roeck Message-ID: <92ccdb7a-e182-4fab-8141-14fb34386bc1@roeck-us.net> Date: Wed, 25 Mar 2026 13:02:01 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] hwmon: (pmbus/core) Protect regulator operations with mutex To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sanman Pradhan References: <20260325181631.17259-4-linux@roeck-us.net> <20260325190502.109001-1-sanman.pradhan@hpe.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260325190502.109001-1-sanman.pradhan@hpe.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 3/25/26 12:05, Pradhan, Sanman wrote: > From: Sanman Pradhan > > Reviewed the series. > > Very minor hardening thought: the notifier worker is > initialized after the devm_regulator_register() loop. > > The current probe ordering makes that fine, so I don't > think this is a bug, but would it be cleaner to initialize > the notifier state a bit earlier just to keep that > setup self-contained? > The interrupt handler is installed after registering the regulator, so I don't think that is a problem since the regulator notifier is called from the interrupt handler. > Don't see any blocking issues in the rest of the series. > Thanks a lot for the review and feedback. Surprisingly, Sashiko did not find anything either: https://sashiko.dev/#/patchset/20260325181631.17259-1-linux%40roeck-us.net If you don't mind, please send me a formal Reviewed-by: tag for the series or for individual patches. Thanks, Guenter