From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933767AbcI0LvO (ORCPT ); Tue, 27 Sep 2016 07:51:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:58858 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932240AbcI0LvH (ORCPT ); Tue, 27 Sep 2016 07:51:07 -0400 Subject: Re: [PATCH] fs/select: add vmalloc fallback for select(2) To: Nicholas Piggin , David Laight References: <20160922152831.24165-1-vbabka@suse.cz> <006101d21565$b60a8a70$221f9f50$@alibaba-inc.com> <20160923172434.7ad8f2e0@roar.ozlabs.ibm.com> <57E55CBB.5060309@akamai.com> <5014387d-43da-03f6-a74b-2dc4fbf4fe32@suse.cz> <20160927212458.3ab42b41@roar.ozlabs.ibm.com> <063D6719AE5E284EB5DD2968C1650D6DB010A97D@AcuExch.aculab.com> <20160927214229.2b0b49ac@roar.ozlabs.ibm.com> Cc: Jason Baron , Hillf Danton , "'Alexander Viro'" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "'Michal Hocko'" , "netdev@vger.kernel.org" , Eric Dumazet From: Vlastimil Babka Message-ID: <92d1ec2c-3246-bd1f-eae5-53ca425ab315@suse.cz> Date: Tue, 27 Sep 2016 13:51:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160927214229.2b0b49ac@roar.ozlabs.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/27/2016 01:42 PM, Nicholas Piggin wrote: > On Tue, 27 Sep 2016 11:37:24 +0000 > David Laight wrote: > >> From: Nicholas Piggin >> > Sent: 27 September 2016 12:25 >> > On Tue, 27 Sep 2016 10:44:04 +0200 >> > Vlastimil Babka wrote: >> > >> > >> > What's your customer doing with those selects? If they care at all about >> > performance, I doubt they want select to attempt order-4 allocations, fail, >> > then use vmalloc :) >> >> If they care about performance they shouldn't be passing select() lists that >> are anywhere near that large. >> If the number of actual fd is small - use poll(). > > Right. Presumably it's some old app they're still using, no? Process name suggests it's part of db2 database. It seems it has to implement its own interface to select() syscall, because glibc itself seems to have a FD_SETSIZE limit of 1024, which is probably why this wasn't an issue for all the years...