From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753860AbdFMR4m (ORCPT ); Tue, 13 Jun 2017 13:56:42 -0400 Received: from foss.arm.com ([217.140.101.70]:52142 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbdFMR4g (ORCPT ); Tue, 13 Jun 2017 13:56:36 -0400 Subject: Re: [PATCH 01/12] coresight replicator: Cleanup programmable replicator naming To: Mathieu Poirier References: <1497278211-5001-1-git-send-email-suzuki.poulose@arm.com> <1497278211-5001-2-git-send-email-suzuki.poulose@arm.com> <20170613165528.GA6392@xps15> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Pratik Patel , "Ivan T . Ivanov" , devicetree@vger.kernel.org, Rob Herring , Mark Rutland From: Suzuki K Poulose Message-ID: <92dd4d1f-171c-905c-13a3-80cd9663bbbf@arm.com> Date: Tue, 13 Jun 2017 18:56:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170613165528.GA6392@xps15> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/17 17:55, Mathieu Poirier wrote: > On Mon, Jun 12, 2017 at 03:36:40PM +0100, Suzuki K Poulose wrote: >> The Linux coresight drivers define the programmable ATB replicator as >> Qualcom replicator, while this is designed by ARM. This can cause confusion >> to a user selecting the driver. Cleanup all references to make it >> explicitly clear. This patch : >> >> 1) Adds a new compatible string for the same, retaining the old one for >> compatibility. >> 2) Changes the Kconfig symbol (since this is not part of any defconfigs) >> CORESIGHT_QCOM_REPLICATOR => CORESIGHT_DYNAMIC_REPLICATOR >> 3) Improves the help message in the Kconfig. >> 4) Changes the name of the driver : >> coresight-replicator-qcom => coresight-dynamic-replicator >> >> Cc: Pratik Patel >> Cc: Ivan T. Ivanov >> Cc: Mathieu Poirier >> Cc: devicetree@vger.kernel.org >> Cc: Rob Herring >> Cc: Mark Rutland >> Signed-off-by: Suzuki K Poulose > > Hi Suzuki, > >> --- >> Documentation/devicetree/bindings/arm/coresight.txt | 4 +++- >> drivers/hwtracing/coresight/Kconfig | 10 +++++----- >> drivers/hwtracing/coresight/Makefile | 2 +- >> drivers/hwtracing/coresight/coresight-replicator-qcom.c | 2 +- >> 4 files changed, 10 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt >> index fcbae6a..f77329f 100644 >> --- a/Documentation/devicetree/bindings/arm/coresight.txt >> +++ b/Documentation/devicetree/bindings/arm/coresight.txt >> @@ -34,7 +34,9 @@ its hardware characteristcs. >> - Embedded Trace Macrocell (version 4.x): >> "arm,coresight-etm4x", "arm,primecell"; >> >> - - Qualcomm Configurable Replicator (version 1.x): >> + - Coresight programmable Replicator (version 1.x): >> + "arm,coresight-dynamic-replicator", "arm,primecell"; >> + OR >> "qcom,coresight-replicator1x", "arm,primecell"; > > Rob, what's your view on keeping the old binding around? We could simply change > the two occurences we find in the DTs (Juno and 410c) to the new name and be > done with the old one. ... >> --- a/drivers/hwtracing/coresight/coresight-replicator-qcom.c >> +++ b/drivers/hwtracing/coresight/coresight-replicator-qcom.c > > While at it, I would also change the name of the file. Sure, will do. Thanks Suzuki