From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1477C43381 for ; Thu, 14 Jan 2021 19:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C369E23A59 for ; Thu, 14 Jan 2021 19:04:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729642AbhANTE2 (ORCPT ); Thu, 14 Jan 2021 14:04:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728881AbhANTE0 (ORCPT ); Thu, 14 Jan 2021 14:04:26 -0500 Received: from smtp-8faa.mail.infomaniak.ch (smtp-8faa.mail.infomaniak.ch [IPv6:2001:1600:4:17::8faa]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BA9AC0613C1 for ; Thu, 14 Jan 2021 11:03:41 -0800 (PST) Received: from smtp-2-0001.mail.infomaniak.ch (unknown [10.5.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4DGty40K9jzMq8Xg; Thu, 14 Jan 2021 20:03:40 +0100 (CET) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-2-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4DGty16Bhkzlh8T2; Thu, 14 Jan 2021 20:03:37 +0100 (CET) Subject: Re: [PATCH v26 00/12] Landlock LSM To: Jann Horn Cc: James Morris , "Serge E . Hallyn" , Al Viro , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , Jeff Dike , Jonathan Corbet , Kees Cook , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , Kernel Hardening , Linux API , linux-arch , "open list:DOCUMENTATION" , linux-fsdevel , kernel list , "open list:KERNEL SELFTEST FRAMEWORK" , linux-security-module , the arch/x86 maintainers References: <20201209192839.1396820-1-mic@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <92df89c9-3442-0761-224a-ab53bb917850@digikod.net> Date: Thu, 14 Jan 2021 20:03:47 +0100 User-Agent: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/01/2021 04:22, Jann Horn wrote: > On Wed, Dec 9, 2020 at 8:28 PM Mickaël Salaün wrote: >> This patch series adds new built-time checks, a new test, renames some >> variables and functions to improve readability, and shift syscall >> numbers to align with -next. > > Sorry, I've finally gotten around to looking at v26 - I hadn't > actually looked at v25 either yet. I think there's still one remaining > small issue in the filesystem access logic, but I think that's very > simple to fix, as long as we agree on what the expected semantics are. > Otherwise it basically looks good, apart from some typos. > > I think v27 will be the final version of this series. :) (And I'll try > to actually look at that version much faster - I realize that waiting > for code reviews this long sucks.) > I'm improving the tests, especially with bind mounts and overlayfs tests. The v27 will also contains a better documentation to clarify the semantic and explain how these mounts are handled. Thanks!