From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D30B29BD91 for ; Sat, 2 May 2026 13:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777729445; cv=none; b=cFUB3zMbkEEZLPYtFhuwWz34aB9GvU4iecnUxd73PoL23N1sEgONPHjh6ROprwoFVaxhC4JWmvNAoeX6yRl7fob3n/pchdyi5FPD3IMw9G9U/zhtnukvcq50c9RXlWNgFoS7JX8N0te+WUzey1rLJwutuwb2KVi2ZkVmYh4nRlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777729445; c=relaxed/simple; bh=osKNb4RpunutQgQWMI8Hh4Is46XBHW6kqUb9T9dtGis=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=H45lVqi/IXDm7RlM9teJ5+nLQYla0IWCPYFrhQlcHaMDDvPQlPOdqXgiPIDhy9OZoDFOj62T4PQp7xcH4DoKjZ63dErB8/Acs7tf/RQpY8ii2Zkt9BGZkjSASY8yeMy3XlD+YCgdvuqbfFtmGC4ld9YYDJNoW7eJiyisAQhi1RU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=ZAnApmCG; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="ZAnApmCG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1777729440; bh=osKNb4RpunutQgQWMI8Hh4Is46XBHW6kqUb9T9dtGis=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=ZAnApmCGhX0tjqlHpI02GLHg876hFXGEvKt5qvd9WpkdX7OGCXdIhFj3YPqDLgijV h6R+zXaReaS9NBFLWWH7TlUoJMe51flpm7R53XixiWllZUHjwQTsJRG8NYHgww+zyn KSLHc9BrJKu7Pn6e1k4hElCVohn259yNNsHVff7w= Date: Sat, 2 May 2026 15:43:54 +0200 From: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= To: Daniel Palmer Cc: w@1wt.eu, linux-kernel@vger.kernel.org Message-ID: <92e2cc56-2e7f-4af0-bb14-fdb4abb305b1@weissschuh.net> In-Reply-To: <20260502072527.1805108-4-daniel@thingy.jp> References: <20260502072527.1805108-1-daniel@thingy.jp> <20260502072527.1805108-4-daniel@thingy.jp> Subject: Re: [PATCH 3/3] selftests/nolibc: Add test for getcwd() and readlink() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <92e2cc56-2e7f-4af0-bb14-fdb4abb305b1@weissschuh.net> May 2, 2026 09:25:45 Daniel Palmer : > Add a test for getcwd() that uses readlink() so tests that > at the same time. > > This is very basic, just getting what should be the same > string via getcwd() and readlink() and then checking they > are the same. > > Signed-off-by: Daniel Palmer > --- > tools/testing/selftests/nolibc/nolibc-test.c | 26 ++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing= /selftests/nolibc/nolibc-test.c > index 08610cacf030..54513fb9a16a 100644 > --- a/tools/testing/selftests/nolibc/nolibc-test.c > +++ b/tools/testing/selftests/nolibc/nolibc-test.c > @@ -849,6 +849,31 @@ static int test_dirent(void) > =C2=A0=C2=A0=C2=A0 return 0; > } > > +static int test_getcwd(void) > +{ > +=C2=A0=C2=A0 char cwd_syscall[1024]; > +=C2=A0=C2=A0 char cwd_proc[1024]; > +=C2=A0=C2=A0 ssize_t len; > + > +=C2=A0=C2=A0 /* Read where the link /proc/self/cwd points */ > +=C2=A0=C2=A0 len =3D readlink("/proc/self/cwd", cwd_proc, sizeof(cwd_pro= c) - 1); > +=C2=A0=C2=A0 if (len <=3D 0) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -1; > + > +=C2=A0=C2=A0 /* Terminate the string from readlink() */ > +=C2=A0=C2=A0 cwd_proc[len] =3D '\0'; > + > +=C2=A0=C2=A0 /* Get the cwd via syscall */ > +=C2=A0=C2=A0 if (getcwd(cwd_syscall, sizeof(cwd_syscall)) =3D=3D NULL) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -1; > + > +=C2=A0=C2=A0 /* Fail if they aren't the same */ > +=C2=A0=C2=A0 if (strcmp(cwd_proc, cwd_syscall) !=3D 0) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -1; > + > +=C2=A0=C2=A0 return 0; > +} > + > int test_getrandom(void) > { > =C2=A0=C2=A0=C2=A0 uint64_t rng =3D 0; > @@ -1477,6 +1502,7 @@ int run_syscall(int min, int max) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(clock_getres);=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSZR(1, clock_getres(CLOCK_MONOTONIC, &ts)= ); break; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(clock_gettime);=C2= =A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSZR(1, clock_gettime(CLOCK_MONOTONIC, &ts));= break; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(clock_settime);=C2= =A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSER(1, clock_settime(CLOCK_MONOTONIC, &ts), = -1, EINVAL); break; > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(getcwd);=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSZR(1, test_ge= tcwd()); break; EXPECT_SYSZR(proc, ...) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(getpid);=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSNE(1, getp= id(), -1); break; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(getppid);=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSNE(1, getppid= (), -1); break; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CASE_TEST(gettid);=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 EXPECT_SYSNE(has_get= tid, gettid(), -1); break; > -- > 2.53.0