From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E293ED3BA for ; Mon, 24 Aug 2026 10:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787566024; cv=none; b=C7iJOd1BoIUPN4a3EpqeZ/4YQUM/leopfjMbJ/AuwHtgh1gDafBR2n7ZnrDYyZ6zvaPtg3hKfGJ92nqNBDfbkL5M9NBwsaJJYu3SzTu6zDBGlDgfFivUFLJL6C1SXzGaJZ8KJy1E8vLPGgE4mKlDXLr6gPPs5LLHL7cJa/AW1Bo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787566024; c=relaxed/simple; bh=m7roA/WbP9oE0Ivr4nqo1RVFQf4lNWod3EUXNP/EtQg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TCwRkTO2p0/qBIkdP/RfwqriHDXiNLpnYe/VOuCA66IBRt+/9a00eSuoGPN5MahBU5fBfdylRQHm7TNUmKxkxzHugzyH4tV24oIxNE8JmUFDuFS68VYiKbCBmPjULqSziBYTGErr5fArpz3PXLOe3YeR5FjKXa4om2UzlvK3Adc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B70+cgdG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ETNIL/ZQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B70+cgdG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ETNIL/ZQ" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67O9WOad2036011 for ; Mon, 24 Aug 2026 10:07:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nqMW1kmMRC4PsfXJ0A+CF6X7lufuIo+KkppMVmucPMA=; b=B70+cgdGSs0AUqMW 7p6ub6k3S2mN35mGcKW6++Bw0tUDU0LIgZknNzSN9xFKMD/++FWgFFSDxyluEJwA dDMXHX3xCRemexgxydHW9pV5LifNn9lHvA7gW8vTcNBDUNQVIz5apZAvzchlcV3D SDt2elBHqzJKITVir8jcW3PC7S6Q7bEQozWKNUxX9qu3WCdM8rCMJOkd4SmG1Rd1 EoSg7FYLsGw8AV13eUbDdVrc21BZ4/fgyKLfrNPog+hK8HjjDpS1ISuL4lF78IHK PHodtsZgXVaMPuZWDKR2kUq3THVYng7rJRxq/dTzZK4ZdPZGbm8nqzAJoVaQetNV go+2Iw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8kdsg49m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 10:07:02 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38f57e31b6eso2977946a91.1 for ; Mon, 24 Aug 2026 03:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787566022; x=1788170822; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nqMW1kmMRC4PsfXJ0A+CF6X7lufuIo+KkppMVmucPMA=; b=ETNIL/ZQROF6riEUy+GhbAqOP9y1eJC+vFar6l0XUwEKKbfybXEZRmuBfxtMB3G7jQ JsI3xcQSEEOf0OZ+W1gIH1CcjAyeT9c0mYi58O3YCdKZBvCkVdJrMHp47Ack0bZPzlBv VD6xyCKuOY5L4619/3nu4EvuKMLN5jnDaXZnD/PFeIYgtAn+qkab0YUvWLpN8Jw+aRCq cQb1AqLpuGIk++YvgMcTIRp47rfp9k1A4bnQVGfrA/4vzh/GkZh+hxpNpxTrgIH6A5So nRYPdTdHEic7GvlEf/vtj0sQhFC1K+75dKz8mU18RrZelyM2lwkuG5t0tskWylbXqoa0 0LhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787566022; x=1788170822; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nqMW1kmMRC4PsfXJ0A+CF6X7lufuIo+KkppMVmucPMA=; b=gnYUoq9mXsbfNRb9gYnyZtrJT/ersEUKCuffa5xX2mhOYGSUHU5K1+TPHph01b7lLj Yz6zZOi+rWa276Q5DFvTA/b2/HeojjrtzfNrR+/ryClf9PnAwnjecE0pUiZiZyQ9iM+K U3xbybXwaacCeIewxxdnVdz3LI9tdWcYo1tX5/dDDrAUoHq/yOb7U0qAskktafiUA3cL cfAtfUqWd6nbEvSyLeukZC+xEbGLbS3ZBKfbrWSykXd+O7XORxEPIioigcC7Z1FlBQAF HPRuDzUsxANH6eH1AX+6GGYCzbTw8+kz1PUqZfykSvltzFRpxOmbSxkPJ5nOCuPsviXZ IFPA== X-Forwarded-Encrypted: i=1; AHgh+Rq+cq3CbWDsVLgzi77AHSpT3rOPyoNvh2a2OBBwYlic8xH4nFNiCc8pqVBOF21qoMcTcH+RWXT0JArXfvc=@vger.kernel.org X-Gm-Message-State: AFuF++mS3GMoD1f8rGGnWR0ZX3+SiYGA/Isf+cBsl0LbG/WxULNnzaS9 G3A/6dugCG6wUN/wLqw3fxqI+L6Ma8WMOLgBb+VJEf0Gt4LL8hQ+9a8Npsl35inwHL2Pg+nbYvw D3OKdQV1cE7yW22BnL9DkvI6K8W9P93mCVVZ83HwyzIC6RA5Pn2e15U2Nf8hVHrVGAt0= X-Gm-Gg: AR+sD10njoQM7elwoqDBXnABsdQ7t+IhswMSmpPtNm/V6MfQoQbPpsFqGyrNkUScsUo 5r3FCfdXAfljFdeteX8MMIJGEWsm/FeqKKOhcrm13FhMHlOXrmwRLlgc9UM5yYzdfZaNCy9J34D epgRkr6maQ8QSTEEu0Aa5YRy0jlFkQF6R83IbERT636uyl4JCl7qPUw5tDDfqkw3n21q01SG/nM 5qa8cpaSVLtBQO7dSZzTuhqrLU40Be4Bw+orb+yPyptgaeo5N0tf57VK56ms4CXc5iQfkvJhjVp ISN3QhusKBUryM8r10fdP/MUeX8tBQ1ednEJF+xsNMAvjv38/Q+70t2Wc9KoVw3Z8KauiBGNFrt D62t1few56cgkKvRr1pLWKtZxL1pTzxwtQA== X-Received: by 2002:a17:90b:2808:b0:37d:f983:7b5 with SMTP id 98e67ed59e1d1-395df289c4bmr32392480a91.9.1787566021921; Mon, 24 Aug 2026 03:07:01 -0700 (PDT) X-Received: by 2002:a17:90b:2808:b0:37d:f983:7b5 with SMTP id 98e67ed59e1d1-395df289c4bmr32392369a91.9.1787566021422; Mon, 24 Aug 2026 03:07:01 -0700 (PDT) Received: from [10.217.218.252] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-395c91849f3sm4676869a91.4.2026.08.24.03.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 03:07:00 -0700 (PDT) Message-ID: <92e89073-69d1-41ff-8545-d872b6b0c147@oss.qualcomm.com> Date: Mon, 24 Aug 2026 15:36:56 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/2] i2c: core: Add i2c_update_timeout() helper for dynamic transfer timeouts To: Mukesh Savaliya , Wolfram Sang , Andi Shyti , Dmitry Guzman Cc: Viken Dadhaniya , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260813-master-v7-0-3f9010cf9229@oss.qualcomm.com> <20260813-master-v7-1-3f9010cf9229@oss.qualcomm.com> <29719c5f-757d-426e-94ca-c221f45c00cf@oss.qualcomm.com> Content-Language: en-US From: Aniket RANDIVE In-Reply-To: <29719c5f-757d-426e-94ca-c221f45c00cf@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDA4NSBTYWx0ZWRfX/JxvYhX2Nh2S zwXp1Oix1MJ38rkbl0v1YmHdWYBS18sW3ACNISftK8JJ0qrQ3JlWEcYmn14KlNtBjBKRDglvLEC Jb8WzX3VTlHaXNsEuXyh6BgSapZVap0= X-Proofpoint-ORIG-GUID: 50SMMW3oya1ootkdajfhdJhipN25LTcN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDA4NSBTYWx0ZWRfX7GcQh5UiR2Lb zkWtTu9VwHxlMfseON6YPmMy8bi2tKIGFLqAFWCi+2Iph6QJCI3yA4sbyu6yf8hUpAiEs3sS2pj olqItNmScTFPmq/SCyRPYN/9XWBceVcERMSl/iaWLh0wZxungWIyI6UWkK4DBMJVSo3CLE+N4Yx 1VcQ7vD/+zv+LuWJ774eMs4mpmfsABpd0Z9G372MOLjAmCnWHJCfOYUGzezwkCiVIBX1xwHcwHk JIZ1ajIkW1x0BLCsRHKVsMyWsVNHjEbjNQQBLySGRx8NapEJDG6qmOiNp6NmsyiayzzNG9xc1rC sBqQNJk3mW9IR9IZhFWzJtZC6kqnHbKAq9N5oIDRi/y1gglEDRnj1uY3KGdIJtcQnVvSTldJ21A N3T/EHmJLBYWzyPG/E2VAv9SXKwtoM15fMFAdGZvudNzlv//niLACEERtfapakf0R6gFTELekcN JxxU0o5A4h1Ff1WUHiQ== X-Proofpoint-GUID: 50SMMW3oya1ootkdajfhdJhipN25LTcN X-Authority-Analysis: v=2.4 cv=d8DFDxjE c=1 sm=1 tr=0 ts=6a8c17c6 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=Q1tV2UWingJUxihUqQ0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_03,2026-08-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240085 On 8/24/2026 11:49 AM, Mukesh Savaliya wrote: > > > On 8/13/2026 11:15 AM, Aniket Randive wrote: > [...] > >> +void i2c_update_timeout(struct i2c_adapter *adap, u32 bus_freq_hz, >> +            size_t len, unsigned int safety_coeff, >> +            unsigned int min_usec) >> +{ >> +    u64 bit_usec = mul_u64_u32_div(len * 9, USEC_PER_SEC, bus_freq_hz); > let's validate bus_freq_hz to prevent from 0 value in case of any > abnormal caller. This scenario is highly unlikely. Most drivers operate with a default bus frequency, typically 400 kHz, and therefore the condition being checked is not expected to occur in practice. As a result, I do not believe this validation is necessary in this case. Thanks, Aniket > >> +    u64 total_usec = bit_usec * safety_coeff + min_usec; >> +    unsigned long jiffies_val; >> + >> +    /* Userspace-configured timeout always takes precedence. */ >> +    if (adap->user_timeout > 0) { >> +        adap->timeout = adap->user_timeout; >> +        return; >> +    } >> + >> +    jiffies_val = usecs_to_jiffies((unsigned int)min_t(u64, >> total_usec, UINT_MAX)); >> +    /* adap->timeout is int; guard against signed overflow. */ >> +    adap->timeout = (int)min_t(unsigned long, jiffies_val, INT_MAX); >> +} >> +EXPORT_SYMBOL_GPL(i2c_update_timeout); >> +#endif /* CONFIG_I2C_DYNAMIC_TIMEOUT */ >> + > > [...] >