From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78E6B2AF06 for ; Mon, 6 Jan 2025 17:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736185660; cv=none; b=jsepxkZBh/axgb+ml2CDOGncpiR5rrbuPREEwnrdnR2uccCRWQqQQB9xp6WGW3mHptxpO+rrJCbdWkx8j88JaciMwUQWA0q2cvNKz9jboNfW3Jzo9PXeWcsQGsQ+F39rkh1Eaz6lLgcJsDEcesO0sGiZkp6+fPTgS6vwDDA3bXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736185660; c=relaxed/simple; bh=Irf7TksMonOv1Z7QByLxUqPJAN1fAil/ez87c0wzuwE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c5stiZjDsVpsdimnz382xCDwSq3Ab3zPjyRbKLsSCDKdoaO2kuY4HN3751GIcsWN/wJJ7bzSw0z8Y2hmNWYpI4pQaDpZbOMZrWw4iJZ//t/JuyMHA7I0n+IIQWw/qtiFK5Q3yGRW2ya/SO7YyTOvkjF29OYAcAtozAthpXd9Sgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=aa9pbzbc; arc=none smtp.client-ip=209.85.166.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="aa9pbzbc" Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-844dfe4b136so457478339f.3 for ; Mon, 06 Jan 2025 09:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1736185657; x=1736790457; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I+OIAvhGznZ4LhzgR7qEdmgYN2V+vMWzwyMlZdaLlu8=; b=aa9pbzbcgphhjby1+MvZNmshqtGlDLwh8/7/ZGIRu93edTQR6xlG23cM4OVmRAXOSw +SBY6GMW+tKTIs4pDB2p4IacNjkYcUJqY+H3Ws4/p/291x9hEy7p83wy5w4WNPNBL6WJ zYUDp90tyOU04oH3/z9I/igPNrga8zuWnDakygOQH0VNgs5AY+BSbdGikBLmWFu6vBcx tGq+A/Lh7iK4/dNSduIYbB8/FJtzADXtNRhrdcAxwGBvIsXQ5JmJ+4CvnQio7EI4Ffsb Wzdez9ekEy9Eegl8v7IVIcD4ZdVVr+vVXupbKEr+ev2b8QbyZDeoLfx5yqgN3ZRbDFfd 2yZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736185657; x=1736790457; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I+OIAvhGznZ4LhzgR7qEdmgYN2V+vMWzwyMlZdaLlu8=; b=hamR00o+uUBNXfJCwhOl1+VEGkAlaOA8msbt2JPW/G2NUOE82Gw75m59nKyw4crBak RrNurwOyOdTuA+UspwII8YKPRl+VCXKTkR/KWfNdTo54Md08bWw8RbhoHOEdOewHNPcE TTMqU4FVa1i6g0UtZO7lcE5BnJ2NwQL0xdv19yMhm23bIkV4PiSugYlcR6kLtRiXlqjh 2N/n/TLJ6N/ajYmrYO85w/kqIcDQfQUKdj2csVpbuCsKvwUbzRVPqKf3Xr8QSgs87bYw rCmvQW7D6icSvYGl8644MfNWhayHow60TQtMVj5woqZ2HCpJbJHmgs4UnrQsQcjzHJ2v GCnw== X-Forwarded-Encrypted: i=1; AJvYcCXkM03nUus3j0YWdkVP2nOo3ubAybiMH7R5j1wTejlMq5moE5Kg4eFRKLUjPYbWXfP5fzvhswFW6bNcFQg=@vger.kernel.org X-Gm-Message-State: AOJu0YyIoNwKQPrjiKdh/UGjaCMciMIBZElLl698PAMZ2icVXpmd3qZK nC6UEwkb7jCuaVjsI90bjA/nuPqn4oQcx+OK2IH2K0RJOV6VslZdvYOlN/7j3AY= X-Gm-Gg: ASbGncvhK/stZ3hcudQiMBIYdrnR9Rg6cVgfT9MtQxtrgDIYO3d3/2BQDJhVw2J/zv+ bwfO/B21WCg0PylcJobKlCiKwPKXAB3xLVpE9gMR0wX6ohtAPgtX2jyHxE1ui7tkunsAsW2LCKn iDgC6UX7T4nVk9r6D7JppgpgRgOOD8IazX8AtkmhUUAU+FqQmEUSgxrnZMz65Qyy/MyFHNyC8l4 uwFN6s7LpDdM07joNuLTCfz5GEzRo2oV5Wo7FkkxNPkc23w4593eAdh6tQygZ+V4XPGJmQ9wt0Q odsO X-Google-Smtp-Source: AGHT+IF5QHH5dwNqH02ne6UcU8UgGBcFcqL5QVA97gSzeddMqTHh+4YCSY3Twcuawu3Fpq8gAFo5PQ== X-Received: by 2002:a05:6e02:216b:b0:3a7:a553:72f with SMTP id e9e14a558f8ab-3c2d51501d1mr460047345ab.18.1736185657580; Mon, 06 Jan 2025 09:47:37 -0800 (PST) Received: from [100.64.0.1] ([165.188.116.9]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e68c22176fsm9113793173.153.2025.01.06.09.47.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2025 09:47:37 -0800 (PST) Message-ID: <92eb2691-3b40-4549-83cf-fbdd0e98bf63@sifive.com> Date: Mon, 6 Jan 2025 11:47:35 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iommu/riscv: Fixup compile warning To: Alexandre Ghiti , guoren@kernel.org, tjeznach@rivosinc.com Cc: joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, paul.walmsley@sifive.com, palmer@dabbelt.com, baolu.lu@linux.intel.com, zong.li@sifive.com, iommu@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Guo Ren References: <20250103024616.3359159-1-guoren@kernel.org> From: Samuel Holland Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Alex, On 2025-01-06 4:31 AM, Alexandre Ghiti wrote: > On 03/01/2025 03:46, guoren@kernel.org wrote: >> From: Guo Ren >> >> When __BITS_PER_LONG == 32, size_t is defined as unsigned int rather > > > RISCV_IOMMU depends on 64BIT so how do you get __BITS_PER_LONG == 32? I am guessing this is from some downstream effort to compile a 64-bit kernel with an ILP32 ABI. However unsupported that may be, size_t is the nominal type used in both riscv_iommu_pte_fetch() and above in iommu_iotlb_gather_add_page(), so the change does make sense. Regards, Samuel >> than unsigned long. Therefore, we should use size_t to avoid >> type-checking errors. >> >> Fixes: 488ffbf18171 ("iommu/riscv: Paging domain support") >> Signed-off-by: Guo Ren >> Signed-off-by: Guo Ren >> Cc: Tomasz Jeznach >> --- >>   drivers/iommu/riscv/iommu.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/riscv/iommu.c b/drivers/iommu/riscv/iommu.c >> index 8a05def774bd..38d381164385 100644 >> --- a/drivers/iommu/riscv/iommu.c >> +++ b/drivers/iommu/riscv/iommu.c >> @@ -1270,7 +1270,7 @@ static phys_addr_t riscv_iommu_iova_to_phys(struct >> iommu_domain *iommu_domain, >>                           dma_addr_t iova) >>   { >>       struct riscv_iommu_domain *domain = iommu_domain_to_riscv(iommu_domain); >> -    unsigned long pte_size; >> +    size_t pte_size; >>       unsigned long *ptr; >>         ptr = riscv_iommu_pte_fetch(domain, iova, &pte_size);