From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E24344DA9 for ; Wed, 11 Feb 2026 03:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770780683; cv=none; b=q9VkI5Jm3YD52pfAie6yej7Q8G8qXYxuvXnxZoiEhbptcfDWt/l1q20fNQdX6grFpR9WeC9VrrSRvMcoxNM6Pd2+KDC+d35RBrFBS2EJqRaBQCRKAHt8g7NqsR7JpQisolB7SRtbOQu/ZoXPH0FQj8hVVX3nsnHFHymRCwMkt4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770780683; c=relaxed/simple; bh=kOKImVrwx74w4JAgLh1XqCZTCzZvDUq6NyV98ul3sTg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=bZDDvJ/yTgR8VAmGx90iiP0HL5iWBAWBYoOUjB7soc/6E2JmYRAlh6r/Bb/4vE/EVhVZoVn1/QCd5bzzDOFUFcl3iuEGlStAprFwW4E0Ewhs7yEhsgrAMsQ6vuGaUS+vr9A4TmpbTe5QKcLQYKFDxC/8KXIeZEcf0VWbn5y5gxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E9SZzjyz; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E9SZzjyz" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-354a7b089bbso3810903a91.2 for ; Tue, 10 Feb 2026 19:31:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770780681; x=1771385481; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=kOKImVrwx74w4JAgLh1XqCZTCzZvDUq6NyV98ul3sTg=; b=E9SZzjyzjd62aONPuax2pkSJIpl+8T7KlPv1CinGUhIh/zKcmIzE2UtCHXGi/5Nmwj ODJwYLCA9F1nLE3lp+ae+YYNmXRNXtHrgPxLBjWUL1ihVMmblnuWp/QJBVUl9la1qQmi FHAiL1kfxMJcXZOfzUc6ZwnQWNcsdzJogWw2TbhsTxo3PnIA45DPHQo8pWvTJXd0Lm41 fMQlG4mDyU44Dm6V7woJlMykgTbtgNs+RcvpVpINoKXf/At5zaLnkYknG1XgxWnwFMAW hlaYFJzFVMM3BZVUw3A5dyMebvH8E1cGiTt8bbxBPn2c7BRJS+mcUQuiCNKP4sG51+l8 2Yuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770780681; x=1771385481; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kOKImVrwx74w4JAgLh1XqCZTCzZvDUq6NyV98ul3sTg=; b=mPDAMCQatmwjlbttmFDLi1H7VJ0CMlPBye/69T4bS7To1P5D3XG32aDa9dduB1yGTu Rpc6/279tYJlRGHgnQW4cCeGb5Vq2J7IQhFd6DGADbs6ApNisYjIo88CjV3eJijQ9Tr0 pCnEQ3rpg114FdEdF3fYBnsPs8sOoctg2bWDW2blX23CI5VHcH5cM6DkCIfaWIfBD4Df Qf8UZrdO5vUn8go/pPgB4a8w4soF+zJPo7gH/lQAj4bgemH52FLqad8fHWDR3+xu2pqC oY/0xQ77XGERv8S0Qz2Af11XAIois4drVspcqg/ruN5tnbXJn7Zh6uC/8ukUsldUc0+d 0LRA== X-Forwarded-Encrypted: i=1; AJvYcCXlRWAfFfxrTXswZQw77jRE3Bnl99SZAQrt69esZYs+aMCnS/O37JiGJKz/Oaf70c2JWW6rbvjTJuy9Y3s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7czPdoo6uRLaF+5w3UWXxeoBzHo0ZwXGlv6kkw6OeCTE6ljG9 NQiM6TYMgNmMwmvoWH3oBgpX5LieGMpbee57C6eS1DMvw7VMQ9zs5t+3 X-Gm-Gg: AZuq6aLcQJdaope4gaYFEz+BSOA1aQIxZaX4zG9YRPa+AIGbfXMLK3UWw7uVjl3fx2L AnhMmmLMSeNqDwFJtrdKoj3r7DaHNHVFJwub03u9X0g3SQbhp08FJbR6jvbpXCXnqczFs2q9E89 gvpHzrMVWN8LULHanlOhIUsqJcF6Vt1o26S9BxaSADwYnaOoFCkZi5K2E0WxI50Zwd+wqgD91lB Fnav7w+BsTu6VcaHdWkZ4ya2luLVz0kyypIYVZupYu1sYfo+gNS2rqKGtv5D/xRCfCCW1saStfJ tIVwZ9jcl/K+tE8a5sDH061VWCAH0EokBqnjWOMDq76Upzs9ogi9D3JxG0YDs+c2JDxkOlscsZI V2uzdc1dQ0CAdbsyjUqO7uBdccu56IlHTjLQeiebCHjSpoUJdAOBMkzy+kL0nGuYQdJpq/rNeIy JCsEeie7oawn7JdeMiAePKg3MqNjW51NkQskWIvNr1rRudbj73brxKVP7sbSBPVEnhkIMyyg== X-Received: by 2002:a17:90b:350c:b0:356:268f:508 with SMTP id 98e67ed59e1d1-3567f8a17a6mr515278a91.35.1770780681443; Tue, 10 Feb 2026 19:31:21 -0800 (PST) Received: from [192.168.0.27] ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35662e531desm4467329a91.2.2026.02.10.19.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 19:31:20 -0800 (PST) Message-ID: <92ef85fe29b9e64766d8a901661a0a848cb73bf8.camel@gmail.com> Subject: Re: [PATCH v2 2/2] xfs: add static size checks for ioctl UABI From: Wilfred Mallawa To: Christoph Hellwig Cc: Carlos Maiolino , "Darrick J . Wong" , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 11 Feb 2026 13:31:16 +1000 In-Reply-To: <20260210153559.GB31245@lst.de> References: <20260210055942.2844783-2-wilfred.opensource@gmail.com> <20260210055942.2844783-5-wilfred.opensource@gmail.com> <20260210153559.GB31245@lst.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-02-10 at 16:35 +0100, Christoph Hellwig wrote: > On Tue, Feb 10, 2026 at 03:59:44PM +1000, Wilfred Mallawa wrote: > > From: Wilfred Mallawa > >=20 > > The ioctl structures in libxfs/xfs_fs.h are missing static size > > checks. > > It is useful to have static size checks for these structures as > > adding > > new fields to them could cause issues (e.g. extra padding that may > > be > > inserted by the compiler). So add these checks to xfs/xfs_ondisk.h. > >=20 > > Due to different padding/alignment requirements across different > > architectures, to avoid build failures, some structures are ommited > > from > > the size checks. For example, structures with "compat_" definitions > > in > > xfs/xfs_ioctl32.h are ommited. >=20 > Looks good: >=20 > Reviewed-by: Christoph Hellwig >=20 > I couldn't spot any whitespace issues either, although I'd personally > drop the last empty line if I had to nitpick. Fixed in V3, Thanks for the review! Wilfred