From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1C893451DA for ; Thu, 18 Dec 2025 13:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066061; cv=none; b=t20fyDFX6EmqHEwoJJ7AGsD3tDlfd9E87lYYWV2fXKmBkjwuUCmR8wtDU6MOVfd3ne1ybDOI6Dw+nGNWdiW6kXY329gklehVqAA32dxFLRSYMfmC/NZFM/2i10E6xkUG7SbMUhVTFaybLjAmwZMzW+B96e/bOFm9ETSg9YIzDeM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766066061; c=relaxed/simple; bh=C2r38V0186zCgV3wn8MPljqqx2DvRXHdoL95mnqxr5I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jYH4ganCitUi/fkxqoh5O4cCIQ4zeo7DdhmYHHrmNSL0D6RuQQnP7JfbKTPAEFOxED0wkruJk8PeKpGG+jlPyhgw9pSWnIESvet0MOCt0xJjp9VdfT8jFHitS9L00Vhw4p3xQ/c+3HsAk33/O2o1eE38J2T1LjCog/+/8NDAN/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UYvXeSl4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hTYnMvj1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UYvXeSl4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hTYnMvj1" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BI8rBg83447044 for ; Thu, 18 Dec 2025 13:54:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W95ZWbyv7ZebtdgUzuyg7nH2Tc3tRPvsWhfTYozeQfw=; b=UYvXeSl453Yk6zLA jOQcGjMzy/fA2El17C1UCC6hhj+fRd1tGT/MWGnn+JN6Ynj24yZ/pGgeMLP4x5e8 IqZ7P5nYS3WDizMrsxZQFzs8/ZxGsSGZ9+MQaCYkiBfFu9eg7vbZoomuk+nI+ZHT pOo6KzDXbo3zqcqH2uwtE0ejXfnm9Wnf9STe6kA4Oy9dMwL1bidJVU7zbwoQP3oW mlO0mHkZedxB33Q/BVnf3EV/3z74nnSns0SXNWVgqhyByMxGiz4hvJgOGIqQwDm/ 75rWZju3j5z3L/3pjLO8AgwhuXLGWwp3GOXFFFTBWvk07o+61jsQJW1mayffC6Tg /Ugemg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b4egb91ey-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 18 Dec 2025 13:54:18 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee05927208so2183231cf.1 for ; Thu, 18 Dec 2025 05:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766066058; x=1766670858; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W95ZWbyv7ZebtdgUzuyg7nH2Tc3tRPvsWhfTYozeQfw=; b=hTYnMvj12fS5wh4MdfwidFoB4MPdiIHuB2vSrcGnleNMqan0bFINgU4cC9sCz57YLz 8c5omNgz6C4+HDHpRbVB/3moBx7KhdMhFH4U51rVk3WEpMh83TBNiyrkNi9/2uyMS0eC xGr3PvfrNnSX9a43XKcKNR9EB/y8rT9rRbO4+1iJgl6tH5oivvIfqsrOTGxnM9og45Jc z8li7lggqKtTDHB6bhu3BQIeOI7VvlCrN5E3RSO10gPLrS8aA4LilTXIq3bcIdbrKPCS z8GhfTLYs3Z+QCBz7BCXD1kJq62XBQ4i7s2m7UrFWRU3a3urwS6EvMTewM4Idp8AzuBg bQVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766066058; x=1766670858; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W95ZWbyv7ZebtdgUzuyg7nH2Tc3tRPvsWhfTYozeQfw=; b=XWVZ/MO4T/+1J0EHaJl7mvE0yC0oR8RtffZ7v62E8WTYYJg9ccm+pYl8rGX6ybRsP6 zyu5zAeQvLDUcAmnqS2fvgA9UFff2KIAM2J/XZmFGqXkGRAGl/OeQjJTme7rfQ2yN1lv PoRUs0MI8NtPFyA4hTdzJpLRVy5ggzQt8fILBixeMMBAaclD64LoYwprwCN6peVcNxTP Ds3B/gpVccE73J0sy9KbQPwT5kA6588QqM3/dx8aJ3I4pIf7R+axMXgZuOPeHKDG5OFp 5TT/W6GHw6kXh5p8Hz1yH1jqnobvwys+NL6RxTMYmyvV3Q3dMbP0zB9HtKZzWBLtoQPw QlkA== X-Forwarded-Encrypted: i=1; AJvYcCVWMM54oFQFOBFd31W+8f6xqg1WxluoIwob9XCCHAdTY1Il1ePUIKz6ypP/XwQgIvWS2kuDN29OD6f0wbY=@vger.kernel.org X-Gm-Message-State: AOJu0YxhEEBm+LoP/jgVXhaxQMNLBIHS8odhWjODntd4nv/5egKWxF98 cnYqFzkUgGyjWAYEkIihp1dCLONqf7gwYPPk8tKRvXKhKw81qyTCSsKJEeLAwenzNouBya7/1r8 U6t41q7VinQT81WGD8BmMigeYGF4vWXBxffYCUNH1+tgciX2SN7NtZZcmKM3W3UL8iCg= X-Gm-Gg: AY/fxX5ynPHbJK98l290o82fqcm20mczM6gWjz6o0mCZndubQBgmUmXO32JbyRKDDxa IHkSMfPCx7X0GBNxeA3ujoAP/OyGgRauQ8yGLOK4gu4h7QxqkdhCIkQus3Y1HKztkuriFANjLJP XIhT99vsko80aK62EgBMfXsHS81j3YrtRo3IADaTqRSwnE+NtKEyF/JDTSxy2qINOjsm58pq9zd yZWGchk1nQHrAec7miAcXRu31GH6FauVTRmSZm98OGBZRrKGTX9zVzxLFPz+LbONC2EZyt3G4HC eS4cPxTugE7uFzqI7352Ioz4970WMt2ohw6wNfCs4BSsHvMTeF3NRgMUWSYH/ttLQmCAwX2MFHM 6vKMI6b6fNoUjgIiuu4CQD4SkCNeIIyL0B6TXxcAHwLXEmJoGo9r7bEN+ioFXNyIXMQ== X-Received: by 2002:a05:622a:341:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f361152409mr20232971cf.9.1766066057854; Thu, 18 Dec 2025 05:54:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBlqC2m/dbjcpakq5xyRubRns6wW9qQ+MVm+nu5mEbtTBjt6LW/ckyVfsGNqX0AxDXLnM9sA== X-Received: by 2002:a05:622a:341:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4f361152409mr20232751cf.9.1766066057380; Thu, 18 Dec 2025 05:54:17 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8022f93e99sm237087366b.2.2025.12.18.05.54.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Dec 2025 05:54:16 -0800 (PST) Message-ID: <92f0e801-032f-4c8a-8bb4-ecb3af48af0a@oss.qualcomm.com> Date: Thu, 18 Dec 2025 14:54:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/mdp5: drop support for MSM8998, SDM630 and SDM660 To: Dmitry Baryshkov Cc: Alexey Minnekhanov , "marijn.suijten@somainline.org" , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Sajna , barnabas.czeman@mainlining.org References: <20251211-mdp5-drop-dpu3-v1-1-0a0186d92757@oss.qualcomm.com> <8e1d33ff-d902-4ae9-9162-e00d17a5e6d1@postmarketos.org> <24f29ff0-99d0-4175-a6c9-f402ce99f645@oss.qualcomm.com> <7dcs7n4pbdhmm4ujgqnek4setujzqxhkdsf3tuf4ggymajj3rj@xzapix7ujzr6> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7dcs7n4pbdhmm4ujgqnek4setujzqxhkdsf3tuf4ggymajj3rj@xzapix7ujzr6> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE4MDExNSBTYWx0ZWRfX/Azw97mMRNoO JYK+PjqzXNyXyjdb0CcE89VvWlBdxSTNqJWbcg+5+DtAoPSCBUjSBi7qM6mCLfvWmp3mLRDFobH nrGpMpy5byEdVx15ADQFQz6B1fftERc+Pct4XMKsxQpX02mJVGQrkkJq+U5vtyNUKMntst3PpUh Xg7mt0Xt12nsadS+gxiWfQ5ePnuXrrHb14LWO4adw40IewJjN+IymeRrD+0LfdeA1pC54Su4OKy GDwrNJCdnEn6ttMyVEKkVltICewC6g1kosnLkyarIO3ee9Ln4pYz4H7ZHTIgHf/S9O0ZnbYnhVd dB+Cv50uxSy10NGLqL5LjKkP3Tc82nSlrD1yGHMmRGJHbf6NWjjzMnXCbsFIa1tTp8VoDV2zK2l 1mNBoEKVp1xV5RkYOmlgfP8FicDvYg== X-Authority-Analysis: v=2.4 cv=M9tA6iws c=1 sm=1 tr=0 ts=6944078a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=NEAV23lmAAAA:8 a=sMkN4vr61ZO4f_miHF8A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: q42f31Bdz3KO9sdYh48CgbsyYrCSqKJR X-Proofpoint-ORIG-GUID: q42f31Bdz3KO9sdYh48CgbsyYrCSqKJR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-18_02,2025-12-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512180115 On 12/18/25 2:49 PM, Dmitry Baryshkov wrote: > On Thu, Dec 18, 2025 at 12:23:49PM +0100, Konrad Dybcio wrote: >> On 12/17/25 5:34 PM, Dmitry Baryshkov wrote: >>> On Wed, Dec 17, 2025 at 06:05:31PM +0300, Alexey Minnekhanov wrote: >>>> On 11.12.2025 04:25, Dmitry Baryshkov wrote: >>>>> Currently MDP5 3.x (MSM8998, SDM630 and SDM660) platforms are support >>>>> by both DPU and MDP5 drivers. Support for them in the DPU driver is >>>>> mature enough, so it's no longer sensible to keep them enabled in the >>>>> MDP5 driver. Not to mention that MSM8998 never used an MDP5 compatible >>>>> string. Drop support for the MDP5 3.x genration inside the MDP5 >>>>> driver and migrate those to the DPU driver only. >>>>> >>>>> Note: this will break if one uses the DT generated before v6.3 as they >>>>> had only the generic, "qcom,mdp5" compatible string for SDM630 and >>>>> SDM660. However granted that we had two LTS releases inbetween I don't >>>>> think it is an issue. >>>>> >>>> >>>> I've retested DPU driver on our downstream release based on 6.18 (by >>>> using msm.prefer_mdp5=false kernel cmdline parameter) on all devices >>>> at my disposal, and I can confirm DPU driver working fine an all SDM660, >>>> SDM636 ones, but not on SDM630. Some logs from sdm630-sony-nile-pioneer >>>> (Sony Xperia XA2): >>> >>> Unfortunately I only have SDM660 and video DSI usecase here. BTW: is >>> your SDM636 / SDM660 using CMD or video panel? >>> >>>> >>>> [ 2.356546] msm_dpu c901000.display-controller: bound c994000.dsi (ops >>>> dsi_ops [msm]) >>>> [ 2.357328] adreno 5000000.gpu: GPU speedbin fuse 146 (0x92), mapped to >>>> opp-supp-hw 0x4 >>>> [ 2.364802] msm_dpu c901000.display-controller: bound 5000000.gpu (ops >>>> a3xx_ops [msm]) >>>> [ 2.444649] [drm:dpu_kms_hw_init:1173] dpu hardware revision:0x30030000 >>>> [ 2.449793] [drm] Initialized msm 1.13.0 for c901000.display-controller >>>> on minor 1 >>>> ... >>>> [ 2.911900] [drm:_dpu_encoder_phys_cmd_wait_for_ctl_start:654] [dpu >>>> error]enc33 intf1 ctl start interrupt wait failed >>>> [ 2.911916] [drm:dpu_kms_wait_for_commit_done:525] [dpu error]wait for >>>> commit done returned -22 >>>> ... >>>> [ 3.176171] [drm:_dpu_encoder_phys_cmd_wait_for_ctl_start:654] [dpu >>>> error]enc33 intf1 ctl start interrupt wait failed >>>> [ 3.176367] [drm:dpu_kms_wait_for_commit_done:525] [dpu error]wait for >>>> commit done returned -22 >>>> >>>> Which results in horrendous ~3-5 fps in shell. >>>> >>>> The block "enc33 intf1 ctl start interrupt wait failed" + "wait for >>>> commit done returned -22" is repeated few times per second whenever >>>> the display is turned on, and stops when it's turned off. >>>> >>>> Meanwhile it is working fine using MDP5 driver (msm.prefer_mdp5=true). >>> >>> It's interesting. Would you please capture the devcoredump for the >>> platform? There will be a lot of blocks, I'm interested in INTF_1, CTL >>> and top_0. >>> >>> Also, as a debugging check, would you mind patching >>> dpu_encoder_phys_cmd_wait_for_commit_done() so that it always calls >>> dpu_encoder_phys_cmd_wait_for_tx_complete()? I will check if there are >>> any differences for CTL_START and similar registers, but it will take >>> some time. >>> >>>> Well, as fine as possible considering [1], using several FD_MESA_DEBUG >>>> tricks to work around GPU issues. >>>> >>>> P.S. I have not yet tested MSM8998, but I can try if required >>> >>> As far as I remember, MDP5 on MSM8998 has never been wired (as in never >>> committed to the DTSI). Angelo has enabled and Freebox people have >>> tested DPU on MSM8998, but I think it was limited to video / HDMI >>> usecases. >> >> I think we poked at both, back in the day (tm) and DPU worked on msm8998- >> sony-maple (sharp,ls055d1sx04 cmd mode panel) with the funny CMD mode hack >> (due to a register field not existing on <845?) >> >> https://github.com/SoMainline/linux/commit/14e0517e2fd5eee116a32db624b09856c60fa022 > > Ok, so my guess was correct and CTL_START is not present there. Checking > the regmaps, there is no intr_start too. Let me cook the patchset. FWIW it's not something I came up with.. But I can't fully recall the original finder. Maybe it was one of the MSM8996/MSM8998/SDM845-mainline contributors? It was difficult to find, so I'd like to credit the author but I'm afraid I can't find it.. Konrad