From: David Laight <David.Laight@ACULAB.COM>
To: 'Jan Beulich' <JBeulich@suse.com>,
"mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] x86: modernize sync_bitops.h
Date: Wed, 21 Nov 2018 11:55:04 +0000 [thread overview]
Message-ID: <92f590595593498eaa1f91a17875126f@AcuMS.aculab.com> (raw)
In-Reply-To: <5BF52F4D02000078001FE5C1@prv1-mh.provo.novell.com>
From: Jan Beulich
> Sent: 21 November 2018 10:11
>
> Add missing insn suffixes and use rmwcc.h just like was (more or less)
> recently done for bitops.h as well.
Why? bts (etc) on memory don't really have an 'operand size'.
IIRC the suffix determines the width of the %cx register that selects the bit number.
I'd have to look up what the "Ir" constraint means.
IIRC the i386 book just said that the cpu might (aka will) read/write 4 bytes
surrounding the required byte.
More recent books say it does an aligned 4 byte read/write.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2018-11-21 11:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 10:24 [PATCH] " Jan Beulich
2018-06-26 7:18 ` Ingo Molnar
2018-06-26 7:26 ` Jan Beulich
[not found] ` <5B30C2C302000000000FA99B@prv1-mh.provo.novell.com>
[not found] ` <5B30C2C302000078001FE5A0@prv1-mh.provo.novell.com>
2018-11-21 10:11 ` [PATCH v2] " Jan Beulich
2018-11-21 11:55 ` David Laight [this message]
2018-11-21 13:02 ` Jan Beulich
2018-11-21 13:49 ` David Laight
2018-11-21 14:41 ` Jan Beulich
2018-11-21 15:53 ` David Laight
2018-11-27 19:51 ` Sean Christopherson
[not found] ` <5BF52F4D02000000001006ED@prv1-mh.provo.novell.com>
[not found] ` <5BF52F4D020000780022227E@prv1-mh.provo.novell.com>
2019-03-27 15:15 ` [PATCH v2 RESEND] " Jan Beulich
2019-04-10 8:47 ` [tip:x86/asm] x86/asm: Modernize sync_bitops.h tip-bot for Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92f590595593498eaa1f91a17875126f@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®