From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kselftest/arm64: Increase frequency of signal delivery in fp-stress
Date: Tue, 29 Oct 2024 18:44:28 +0000 [thread overview]
Message-ID: <92fb0694-7a55-4e2f-9b59-8263a9dc58bc@sirena.org.uk> (raw)
In-Reply-To: <ZyECqagB1tGdE4uz@J2N7QTR9R3.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]
On Tue, Oct 29, 2024 at 03:43:37PM +0000, Mark Rutland wrote:
> On those emulated platforms (FVP?), does this change trigger the faukure
> more often?
Yes.
> I gave this a quick test, and with this change, running fp-stress on a
> defconfig kernel running on 1 CPU triggers the "Bad SVCR: 0" splat in
> 35/100 runs. Hacking that down to 5ms brings that to 89/100 runs. So
> even if we have to keep this high for an emulated platform, it'd
> probably be worth being able to override that as a parameter?
I was getting better numbers than that with the default multi-CPU setups
on my particular machine, most runs were showing something IIRC. I do
agree that it'd be a useful command line argument to add incrementally.
> Otherwise, maybe it's worth increasing the timeout for the fp-stress
> test specifically? The docs at:
> https://docs.kernel.org/dev-tools/kselftest.html#timeout-for-selftests
> ... imply that is possible, but don't say exactly how, and it seems
> legitimate for a stress test.
IIRC it's per suite and there's a bunch of pushback on using it in
default configurations since the selftests are expected to run quickly
in other cases where I'd have said it was a reasonable change to make.
Stress tests are not entirely idiomatic for kselftest, it's supposed to
run quickly.
> > +#define SIGNAL_INTERVAL_MS 25
> > +#define LOG_INTERVALS (1000 / SIGNAL_INTERVAL_MS)
> Running this, I see that by default test logs:
> # Will run for 400s
> ... for a timeout that's actually ~10s, due to the following, which isn't in
> the diff:
> if (timeout > 0)
> ksft_print_msg("Will run for %ds\n", timeout);
> ... so that probably wants an update to either convert to seconds or be in
> terms of signals, and likewise for the "timeout remaining" message below.
> Otherwise, this looks good to me.
Oh, yeah - we should probably just remove the unit from that one. I
never see it due to all the spam from the subprocesses starting.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-10-29 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 0:10 [PATCH 0/2] kselftest/arm64: fp-stress signal delivery interval improvements Mark Brown
2024-10-29 0:10 ` [PATCH 1/2] kselftest/arm64: Increase frequency of signal delivery in fp-stress Mark Brown
2024-10-29 15:43 ` Mark Rutland
2024-10-29 18:44 ` Mark Brown [this message]
2024-10-29 0:10 ` [PATCH 2/2] kselftest/arm64: Lower poll interval while waiting for fp-stress children Mark Brown
2024-10-29 15:47 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92fb0694-7a55-4e2f-9b59-8263a9dc58bc@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®