From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754771AbdDRQuc (ORCPT ); Tue, 18 Apr 2017 12:50:32 -0400 Received: from mout.web.de ([212.227.15.14]:60583 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbdDRQu3 (ORCPT ); Tue, 18 Apr 2017 12:50:29 -0400 Subject: [PATCH 1/6] ACPI-fan: Use devm_kcalloc() in acpi_fan_get_fps() From: SF Markus Elfring To: linux-acpi@vger.kernel.org, Borislav Petkov , Chun-Yi Lee , Colin Ian King , Dan Williams , Len Brown , Linda Knippers , "Rafael J. Wysocki" , Tony Luck , Vishal Verma , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org References: <077115e4-8ec3-9c6d-0374-8ffc5e0f85c0@users.sourceforge.net> Message-ID: <930132d9-b878-e787-a67d-71113e5c211e@users.sourceforge.net> Date: Tue, 18 Apr 2017 18:50:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <077115e4-8ec3-9c6d-0374-8ffc5e0f85c0@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:p2/dD0ScZDxe8LDH7gwyPBUJ2Fmja/BnhugzHO/+psFm2ar2O2o HaiPINeFE+HezbxTCbfqVl9IMRGI6HkeS7U10ra9B7y2jAVIHBHlztvauixH6FksPmysIZX SvRV7ZosQXYfsWzPqdFn92XiRBmHqAtHhc/tfxby1FlrEbG20rLs7o+Jr1gv2R0PZKlhE44 e6vBKIF82f7pm8Lh5vrkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:CCpQ9oecRhc=:WMl+JgptCugkhtQRpJaS6i 2wwkgI3994b7rg8NXz5qiwAb6FUsZGgXQ/WOoKGFvN75RuSK9orXR+dYQnwSKZGtK3k5oJJRG 0HAiBzTL+iVqR3a+bOofmB849kf2RkcvMV4U439nPpYhcu/pF8LMs5tfwb3X3cQ1sT0EO/pkd Ov21KTEnXDS/Z1voFJSRM3Pi6X1Ji5ujnCUb0udRuCaXtWDjPj1HHzeoVm7gaz1g7WQbnWxZZ SqOC10FxHgEgKQ5bMOX43TKC0cQWKYArNBkrz0sG6CmOgT052tqjqzTM7+4neb7XtTQ1hSmjY a2F70GEEjrZqxfV/M4Bvz+kK+++oUIWFK3A+vSnPArhIa/7HAkrr0trjpENxGKIiDlOSNRG0y C6aCQnDZXsG+Lj/k9VF1VYYllqjxsQwgjVO0q9TmMo01uTzahX9r6z1e14OzpK4vsh6LtTPno 8KxN4suCyHGvi7JKkHql1ErdOCQTsbUbQ0xuUqGhk9KgWBLgTdK1tIhuR9n5S3VAphkWoTVTt b6juo3rKn/F2NOSvuR/HkRuWiccJXWOeAVe0ExIsfwbkjZc2fjKLvQSwzQ+LrcwEt72cDzzvy AAQcDsspcD4HLY3PNLjBQqwce0mbP27gE8LpZEfWlMpgtP9X2IIt6eHWMPwq5swq6eNJ4B8Of xIrxarPwFmCHMCytRGoUEMYHhRqiLNY5/OPfoLZJdQ1aldGC9meHpQ40j8V1Kue12GXCGETSn vBBMH3PtkDZhWl+4fgZJuouFYvDwoKTzft1WSTU0qRcR8rlvDm+463PDxtHga4tXqRpEz/Ha4 fKIgmZf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 18 Apr 2017 17:00:39 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/acpi/fan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index 6cf4988206f2..92878c7c523b 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -298,8 +298,7 @@ static int acpi_fan_get_fps(struct acpi_device *device) } fan->fps_count = obj->package.count - 1; /* minus revision field */ - fan->fps = devm_kzalloc(&device->dev, - fan->fps_count * sizeof(struct acpi_fan_fps), + fan->fps = devm_kcalloc(&device->dev, fan->fps_count, sizeof(*fan->fps), GFP_KERNEL); if (!fan->fps) { dev_err(&device->dev, "Not enough memory\n"); -- 2.12.2