mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stanislav Zaikin <zstaseg@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/3] dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible
Date: Fri, 11 Sep 2026 11:52:27 +0200	[thread overview]
Message-ID: <930e17e8-8fdf-46c4-9e89-3eb1d7cd58aa@gmail.com> (raw)
In-Reply-To: <aqHLuHr-Vf3gtz2T@venus>

On 9/9/26 11:16 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Aug 21, 2026 at 02:37:09PM +0200, Stanislav Zaikin wrote:
>> Add the compatible string used by Xiaomi 12 Lite 5G (taoyao) so its
>> battery manager can be matched to a device-specific variant in
>> qcom_battmgr.
>>
>> Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>> index 16ad4f5698fc..8ca057c4e3e6 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>> @@ -41,6 +41,7 @@ properties:
>>         - items:
>>             - enum:
>>                 - qcom,sm7325-pmic-glink
>> +              - xiaomi,taoyao-pmic-glink
>>             - const: qcom,qcm6490-pmic-glink
>>             - const: qcom,pmic-glink
> 
> Is the implementation compatible with qcom,qcm6490-pmic-glink? The
> driver does not bind that compatible, so I can't tell. Maybe some
> Qualcomm people can answer this question. Please send new version
> without the RFC tag, so that DT binding maintainers review this
> patch series.
> 
> Greetings,
> 
> -- Sebastian

Hi,

Thank you for the review.

Yes, we still need qcom,qcm6490-pmic-glink for usci_glink driver 
(there's a quirk that all sm7325-based handset uses: spacewar, dubai).

Will send a new version without RFC tag.

-- 
Best regards,
Stanislav


  reply	other threads:[~2026-09-11  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21 12:37 [RFC PATCH v3 0/3] Add Xiaomi 12 Lite 5G (taoyao) battery support Stanislav Zaikin
2026-08-21 12:37 ` [RFC PATCH v3 1/3] dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible Stanislav Zaikin
2026-09-09 21:16   ` Sebastian Reichel
2026-09-11  9:52     ` Stanislav Zaikin [this message]
2026-08-21 12:37 ` [RFC PATCH v3 2/3] power: supply: qcom_battmgr: add Xiaomi taoyao support Stanislav Zaikin
2026-08-25  8:42   ` Konrad Dybcio
2026-08-21 12:37 ` [RFC PATCH v3 3/3] arm64: dts: qcom: sm7325-xiaomi-taoyao: switch to device-specific pmic-glink compatible Stanislav Zaikin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=930e17e8-8fdf-46c4-9e89-3eb1d7cd58aa@gmail.com \
    --to=zstaseg@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®