mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Tejun Heo <tj@kernel.org>, Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / QoS: Fix workqueue deadlock when using pm_qos_update_request_timeout()
Date: Wed, 14 Aug 2013 00:54:18 +0200	[thread overview]
Message-ID: <9317874.UKPmemvZzk@vostro.rjw.lan> (raw)
In-Reply-To: <20130813221325.GD28996@mtj.dyndns.org>

On Tuesday, August 13, 2013 06:13:25 PM Tejun Heo wrote:
> Hello,
> 
> On Tue, Aug 13, 2013 at 02:12:40PM -0700, Stephen Boyd wrote:
> > @@ -308,7 +319,7 @@ static void pm_qos_work_fn(struct work_struct *work)
> >  						  struct pm_qos_request,
> >  						  work);
> >  
> > -	pm_qos_update_request(req, PM_QOS_DEFAULT_VALUE);
> > +	__pm_qos_update_request(req, PM_QOS_DEFAULT_VALUE);
> 
> Maybe a short comment explaining why this is different would be nice?
> Other than that,
> 
>  Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks guys, I'm going to push that as a fix for 3.11-rc6 and stable.

Rafael


      reply	other threads:[~2013-08-13 22:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 20:13 Stephen Boyd
2013-08-13 16:37 ` Stephen Boyd
2013-08-13 16:43 ` Tejun Heo
2013-08-13 16:46   ` Stephen Boyd
2013-08-13 17:01     ` Tejun Heo
2013-08-13 20:49       ` Rafael J. Wysocki
2013-08-13 20:49         ` Stephen Boyd
2013-08-13 21:12         ` Stephen Boyd
2013-08-13 22:13           ` Tejun Heo
2013-08-13 22:54             ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9317874.UKPmemvZzk@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®