From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-110.freemail.mail.aliyun.com (out30-110.freemail.mail.aliyun.com [115.124.30.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A80017995; Mon, 15 Jan 2024 14:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0W-j1yLV_1705329597; Received: from 30.27.74.27(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0W-j1yLV_1705329597) by smtp.aliyun-inc.com; Mon, 15 Jan 2024 22:39:59 +0800 Message-ID: <931bcf87-efdf-478f-869b-fcb1260ac1cc@linux.alibaba.com> Date: Mon, 15 Jan 2024 22:39:57 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] erofs: Don't use certain internal folio_*() functions To: Matthew Wilcox Cc: linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, David Howells , Christian Brauner , Jeff Layton , LKML , Chao Yu , Yue Hu , Jeffle Xu References: <20240115083337.1355191-1-hsiangkao@linux.alibaba.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Matthew, On 2024/1/15 22:06, Matthew Wilcox wrote: > On Mon, Jan 15, 2024 at 04:33:37PM +0800, Gao Xiang wrote: >> From: David Howells >> >> Filesystems should use folio->index and folio->mapping, instead of >> folio_index(folio), folio_mapping() and folio_file_mapping() since >> they know that it's in the pagecache. >> >> Change this automagically with: >> >> perl -p -i -e 's/folio_mapping[(]([^)]*)[)]/\1->mapping/g' fs/erofs/*.c >> perl -p -i -e 's/folio_file_mapping[(]([^)]*)[)]/\1->mapping/g' fs/erofs/*.c >> perl -p -i -e 's/folio_index[(]([^)]*)[)]/\1->index/g' fs/erofs/*.c >> >> Reported-by: Matthew Wilcox >> Signed-off-by: David Howells >> Reviewed-by: Jeff Layton >> Cc: Chao Yu >> Cc: Yue Hu >> Cc: Jeffle Xu >> Cc: linux-erofs@lists.ozlabs.org >> Cc: linux-fsdevel@vger.kernel.org >> Signed-off-by: Gao Xiang >> --- >> Hi folks, >> >> I tend to apply this patch upstream since compressed data fscache >> adaption touches this part too. If there is no objection, I'm >> going to take this patch separately for -next shortly.. > > Could you change the subject? It's not that the functions are > "internal", it's that filesystems don't need to use them because they're > guaranteed to not see swap pages. Maybe just s/internal/unnecessary/ Yes, the subject line was inherited from the original one. Such helpers are useful if the type of a folio is unknown, let me revise it. Thanks, Gao Xiang