From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 282143939AF; Wed, 18 Mar 2026 11:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833591; cv=none; b=g6x8mBU3nH7ZHFfmjkAtz1BUwwBA8ugN36ME9fUTYFUsfNq/EYClz1+AJVuEKVu4hZphclkDETL1nM903ozFQQukxG3mXNyjfGQpsJUjaoot8zlbdxjn36VdUWEpyS4Cc9MPkR9vmyMPXQ8MdQcwp0EcEAn+dVqoTfgbu7MDSiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773833591; c=relaxed/simple; bh=YEj8bJTZScxY2qVm7WnrDujqI+DtPSQ2M+4Z7hJjhAk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uMVtCL8rrp8hYTLbOjRa4Uv7fW+4SkSVtucm95mjImOk7da7lo4bA7OtNU2sryPRkNaKlenN7JLW6s7WGVTuDVAZ9CGalZ+Lqhf2ui1wwg9+la1FPu+9DwIbXUwCxIStUZx7JygHoiQtvh5xbsZkFSpCFcyH5q5OpmVIx0Ffp8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JYG1UqOF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JYG1UqOF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD488C19421; Wed, 18 Mar 2026 11:33:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773833590; bh=YEj8bJTZScxY2qVm7WnrDujqI+DtPSQ2M+4Z7hJjhAk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JYG1UqOF72U7xdAoMhlDaaoiuW6hlyFsV21wqJRWXOrZMifKD6ATZhumcDlHPtgz5 oaaICEOWWhFUVy+5/V/0I7MkKOK7ZzqDFwHgA5mJDOpY288V3OfnHlii7Oyy8PX3Ap RYrwMu4+xFNt1OOQDzP/5yaupLj3BVWOHVztBC10EaXZtKZCOsaTJVH9rb+5isx0Ga rr/MXS8CcTcLlbKK3E6De1J7AwC1Er1Mn6kb7NyRSKAlmVsOecAjdSbWIiw7P+o7At +bMjsTqAEPrK2RNtEM1eVC7VFnjXr4f2AkSkUE58ppy+N9cbURz5wM+MCYYxLAtvht GSr/Inth1b7Rw== Message-ID: <931beb71-868d-499c-9c1a-14d1ae777abf@kernel.org> Date: Wed, 18 Mar 2026 12:33:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/12] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk To: Harshal Dev , Dmitry Baryshkov Cc: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich , Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Kuldeep Singh References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> <20260317-qcom_ice_power_and_clk_vote-v3-1-53371dbabd6a@oss.qualcomm.com> <20260318-aboriginal-peach-bird-cacb8c@quoll> <24d4926d-63d0-479d-b938-6438364e9998@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <24d4926d-63d0-479d-b938-6438364e9998@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/03/2026 11:30, Harshal Dev wrote: > > > On 3/18/2026 12:52 PM, Krzysztof Kozlowski wrote: >> On Tue, Mar 17, 2026 at 05:12:36PM +0200, Dmitry Baryshkov wrote: >>> On Tue, Mar 17, 2026 at 02:50:40PM +0530, Harshal Dev wrote: >>>> Update the inline-crypto engine DT binding in a backward compatible manner >>>> to allow specifying up to two clocks along with their names and associated >>>> power-domain. >>> >>> This should come after the "why" part. >>> >>>> >>>> When the 'clk_ignore_unused' flag is not passed on the kernel command line >>>> occasional unclocked ICE hardware register access are observed when the >>>> kernel disables the unused 'iface' clock before ICE can probe. On the other >>>> hand, when the 'pd_ignore_unused' flag is not passed on the command line, >>>> clock 'stuck' issues are observed if the power-domain required by ICE >>>> hardware is unused and thus disabled before ICE probe could happen. >>> >>> You can simply say that ICE requires these clocks and these power >>> domains to function. Accessing the hardware can fail if they are >>> disabled by the kernel for whater reasons. >> >> Yeah, mentioning clk_ignore_unused/pd is redundant here. > > Ack. > >> >>> >>>> >>>> To avoid these scenarios, the 'iface' clock and the associated power-domain >>>> should be specified in the ICE device tree node and enabled by ICE. >> >> And this repeats the first paragraph. > > Ack. > >> >>>> >>>> Fixes: f6ff91a47ac57 ("dt-bindings: crypto: Add Qualcomm Inline Crypto Engine") >>>> Signed-off-by: Harshal Dev >>>> --- >>>> .../bindings/crypto/qcom,inline-crypto-engine.yaml | 16 +++++++++++++++- >>>> 1 file changed, 15 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>> index 876bf90ed96e..99c541e7fa8c 100644 >>>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml >>>> @@ -30,6 +30,16 @@ properties: >>>> maxItems: 1 >>>> >>>> clocks: >>>> + minItems: 1 >>>> + maxItems: 2 >>>> + >>>> + clock-names: >>>> + minItems: 1 >>>> + items: >>>> + - const: core >>>> + - const: iface >>>> + >>>> + power-domains: >>>> maxItems: 1 >> >> >> 1. What the DTS is doing here? > > Okay. I will add a description of the expectation imposed by this binding on > the DTS in the commit message of this patch. You target this to fixes. Your subject and PATCH prefix should state that. DTS is irrelevant in the git history in this context. I stated previous the reason why this must go to the fixes. Best regards, Krzysztof